CHAT_MSG_? gone?

[Jayhawk]

I was wondering, as my addons seem to be broken, were Events such as CHAT_MSG_SPELL_AURA_GONE_SELF and CHAT_MSG_SPELL_PERIODIC_SELF_BUFFS removed or..?

[Shirik]

You must have missed the biggest part of 2.4 Check out the UI changes thread in the news area.

[Jayhawk]

Well, I knew they were changing the combat log, what I didn't know was that they were going to remove the original functionality

[Shirik]

Anything you could do before you can do now (and more), you just have to use the new events outlined in Iriel's post on that page.

[Jayhawk]

Is there a simple tutorial explaining how to get the new one to behave in a way to parse this kind of information again?

Such as :

function PetInfoFu:CHAT_MSG_SPELL_AURA_GONE_SELF()
    -- catch the Feed Pet Effect fades
    if string.find(arg1, BS["Feed Pet Effect"]) ~= nil then 
        isFeedingPet = false
    end
    if string.find(arg1, BS["Improved Mend Pet"]) ~= nil  or 
        string.find(arg1, BS["Mend Pet"]) ~= nil then
        if self.petMendFrame ~= nil then 
            self.petMendFrame:Hide()
        end
    end
end

Iriels stuff looks... confusing

[Shirik]

Have you tried taking a look at http://wowwiki.com/COMBAT_LOG_EVENT_Details yet? Unfortunately I haven't learned the new system yet myself, aside from absolute basics (no time), so I can't be of more assistance than that, unfortunately.

[Jayhawk]

Oh...help...
This is going to cost me half of forever to figure out.
Thanks for the help, though

[Seerah]

Hope you get it figured out, Jayhawk.

[archondan]

Originally Posted by Jayhawk Oh...help... This is going to cost me half of forever to figure out. Thanks for the help, though

Jayhawk,

The new combatlog / events are a tad confusing but seem be to be very powerful. I, my self, am still trying to figure out all the ins and outs of the new system but here is how I made sense of the new format.

1. Log into WoW and turn on CombatLog.txt ( console command /combatlog )
2. Cast/use the specific spell or ability you are looking for.
3. Logout of WoW and open Logs/CombatLog.txt.
4. Look for the event. In my case
--3/28 18:57:21.039 SPELL_ENERGIZE,0xF730004CD400ED3C,"Shadowfiend",0x1111,0x00000000005D7859,"Quella",0x511,34650,"Mana Leech",0x20,345,0
4. In the addon Register for the "COMBAT_LOG" event.
5. Create a filter with CombatLogAddFilter(EVENT,srcFlags,dstFlag)
In my case it was CombatLogAddFilter("SPELL_ENERGIZE",0x1111,0x511)

Now when ever an event matches the filer, as in the event above, the COMBAT_LOG event is fired. So now my addon only has to parse the exact event I am looking for instead of every combat related event.

I *think* I understand the basics

Hope this helps some.

[Jayhawk]

Thanks Seerah, I think I did.

For PetInfoFu, I got the following:

self:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")

function PetInfoFu:COMBAT_LOG_EVENT_UNFILTERED(_, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, spellId, spellName, spellSchool, amount, ...)

    -- pet as destination
    if (dstName ~= nil) and 
       (dstName == UnitName("pet")) then
        if eventType == "SPELL_AURA_APPLIED" then
            if self.db.char.showMendPetFrame then
                if spellName == BS["Improved Mend Pet"] or 
                   spellName == BS["Mend Pet"] then
                   self:PetMendFrame()
                end
            end        
            if spellName == BS["Feed Pet Effect"] then -- feeding pet, start tracking 
                isFeedingPet = true
            end           
        elseif eventType == "SPELL_AURA_REMOVED" then
            if (spellName == BS["Improved Mend Pet"]) or 
               (spellName == BS["Mend Pet"]) then
                if self.petMendFrame ~= nil then 
                    self.petMendFrame:Hide()
                end
            end
            if spellName == BS["Feed Pet Effect"] then 
                isFeedingPet = false
            end           
        elseif eventType == "SPELL_CAST_SUCCESS" then
            -- if spellName == BS["Improved Revive Pet"] or 
            --    spellName == BS["Revive Pet"] then
            --     self:CalculateEstimatedHappiness(-350)
            -- end
        elseif eventType == "SPELL_PERIODIC_ENERGIZE" then
            if spellName == BS["Feed Pet Effect"] then 
                -- amount will contain the numer of happiness gained

            end           
        else
        end
    end
    
    -- pet as source
    if (srcName ~= nil) and 
       (srcName == UnitName("pet")) then
        if eventType == "UNIT_DIED" then
            DoSomething
        end
    end
    
    -- player as destination
    if (dstName ~= nil) and 
       (dstName == UnitName("player")) then
        if eventType == "SPELL_AURA_APPLIED" then
            -- strangely dismiss pet is applying an aura to the player
            DoSomething
        end
    end    
-- COMBATLOG:AddMessage('PetInfoFu: CLE '..crayon:Orange(srcName)..' '..crayon:Orange(dstName)..' '..crayon:Orange(eventType)..' '..crayon:Orange(spellName))  

end

It's not pretty as yet, but it works. Hardest part is figuring out which spell is what, for event type. I used the debugger at the end for that.
Archondan, that should work too, I think mine's more...lazy I haven't worked with the filters yet, may do so later.

I think... the current code works more cleanly, though. Further cleaning up, I guess, may be done by getting spellID's rather than comparing SpellNames.

[Seerah]

SpellIDs don't need to be localized, whereas spell names do, iirc.

[Jayhawk]

That's what I figured, sadly spellIDs are fairly "unreadable" and I haven't seen a list of constants as yet (I must admit I'm too lazy to make one myself at this stage). I'll be uploading this version so I have at leas an updated version, then, time permitting I'll get a list of spellIDs and get rid of Babble-Spell.

(Of course, I still need to get busy with SkillsPlusFu)

[Layrajha]

Originally Posted by Jayhawk That's what I figured, sadly spellIDs are fairly "unreadable" and I haven't seen a list of constants as yet (I must admit I'm too lazy to make one myself at this stage).

I don't think there's any list in Blizzard's UI at least, if that's what you mean. The localizations of the IDs are probably hidden in the mpq files. What makes me think that you can't reach the names from the IDs is simply that addons like DBM and Omen have a lua file to create these tables Of course, I'm trusting their authors on this one, but well, they've probably investigated?


(no, they haven't? well, sorry then :<)

[Akryn]

just fyi, you normally don't want to use COMBAT_LOG_EVENT or change the filters unless your goal is to replace the combat log. changing the filters affects everything including the blizzard combat log.

for almost all addons, the event you want is COMBAT_LOG_EVENT_UNFILTERED

[archondan]

Originally Posted by Akryn just fyi, you normally don't want to use COMBAT_LOG_EVENT or change the filters unless your goal is to replace the combat log. changing the filters affects everything including the blizzard combat log. for almost all addons, the event you want is COMBAT_LOG_EVENT_UNFILTERED

Are you positive? I just ran a couple of simple tests with my addon. It sets up a filter for SPELL_ENERGIZE combat log event from the shadowfiend's mana leech. When i cast shadowfiend, I still see my smite damage and other events in the combat log.

So it *appears* that the combat filter I setup does not affect the combat log chat window.

Please correct me if i am wrong. I'm still trying to figure out the finer details of the new combat log

[Akryn]

i honestly haven't played around enough with filtering enough to know for sure, but my understanding was that every time you add a filter, it gets added globally; so that if someone did not want to see those events, and you added a filter for them, they would start to show up anyway.

COMBAT_LOG_EVENT fires for every frame that is registered for it, but you can filter it so that it doesn't fire at all except under certain circumstances. you can't tell the game to only fire it for specific frames though.

[Jayhawk]

That's an interesting conundrum, Akryn, thanks.
As for the SpellID's I'm sure there will be a library at some stage

I had a friendly person give me an alternative to the code I used. He uses an interesting approach to filtering:

function PetInfoFu:COMBAT_LOG_EVENT_UNFILTERED( timestamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, spellID, spellName, spellSchool, amount, ... )
   if dstFlags == bit.band( dstFlags, bit.bor( COMBATLOG_OBJECT_AFFILIATION_MINE,
                                               COMBATLOG_OBJECT_REACTION_FRIENDLY,
                                               COMBATLOG_OBJECT_CONTROL_PLAYER,
                                               COMBATLOG_OBJECT_TYPE_PET ) ) then
        DoSomething
    end
end

Also interesting is that where I'm using the eventType as base for my 'case' he used the spellID. I wonder which is more efficient, but it's probably dependent on what one tries to do.

[Layrajha]

Originally Posted by Jayhawk I had a friendly person give me an alternative to the code I used. He uses an interesting approach to filtering: function PetInfoFu:COMBAT_LOG_EVENT_UNFILTERED( timestamp, eventType, srcGUID, srcName, srcFlags, dstGUID, dstName, dstFlags, spellID, spellName, spellSchool, amount, ... ) if dstFlags == bit.band( dstFlags, bit.bor( COMBATLOG_OBJECT_AFFILIATION_MINE, COMBATLOG_OBJECT_REACTION_FRIENDLY, COMBATLOG_OBJECT_CONTROL_PLAYER, COMBATLOG_OBJECT_TYPE_PET ) ) then DoSomething end end

Well, really, this is the kind of approach that was expected in the changes, I believe. Because, well, even if Lua isn't the best language to manipulate binary numbers, here we are given the data that the game uses, and there are obviously filters of this kind used all the time.

I would probably use

if band(event_s_dstFlags, bnot_of_my_filter's_dstFlags) ~= 0 then
  blabla
end

instead of

if band(event's_dstFlags, my_filter's_dstFlags) == event's_dstFlags then
  blabla
end

but I can't find any proper justification for that I just understand it better, and I usually prefer to compare things to fixed values and not to have the same variable on the two sides of my equalities. But both give the same result and are understandable, and I don't think that you'd feel any difference CPU-wise.

[Jayhawk]

Hmmm-kay. Bit logic isn't quite my cup of tea, so I guess I'll stick with the way as was suggested to me earlier I hope to find some time this weekend to go fiddle with it.

[Layrajha]

Originally Posted by Jayhawk Hmmm-kay. Bit logic isn't quite my cup of tea, so I guess I'll stick with the way as was suggested to me earlier I hope to find some time this weekend to go fiddle with it.

Well, both expressions mean:
"All the bits that are 1s in the event's flags should be at 1 as well in my filter's flags."
It's a binary "⇒", basically.