oUF 1.5.5 -> 1.5.6 changelog

zork · 02-05-11, 06:05 AM

haste could you post the most noticable changes between both versions?

https://github.com/haste/oUF/commits/master?page=1

haste · 02-05-11, 06:39 AM

Short summary would be:
- Vehicle element merged into the core (it causes one issue because I'm limiting updating however, see Issue 69 on github. Solution not tested yet).
- New element: AltPowerBar
- Split things up in separate files to make it less messy to work with. There's still a couple of messy functions in ouf.lua however.
- Event handlers with multiple functions are converted back to single functions when possible. Previously they would remain dispatchers.
- bossN units don't use OnUpdate anymore.
- The aura tables don't have hidden holes anymore. Previously oUF would create all icons in a sequence[1].
- Post and Pre updates for entire frames. These only execute when oUF runs a full update of the frame. This is basically a proper solution to injecting code into self.__elements.

I just skimmed the git shortlog, but that should be everything major.

[1] Let's say we had 8 auras on a unit, and our aura code filtered out aura ids 3 4 6 7. In 1.5.5 and previous oUF would create the entire sequence of icons (1 2 3 4 5 6 7 8) and just hide 3 4 6 and 7. With 1.5.6 oUF will only create 1 2 3 4 and assign these to be 3 4 6 7.

Hopefully that made some sense :P.

haste · 02-05-11, 03:39 PM

Vehicle issues should be solved with 1.5.7.

Dawn · 02-05-11, 07:13 PM

Originally Posted by haste

...
- The aura tables don't have hidden holes anymore. Previously oUF would create all icons in a sequence[1].
...

[1] Let's say we had 8 auras on a unit, and our aura code filtered out aura ids 3 4 6 7. In 1.5.5 and previous oUF would create the entire sequence of icons (1 2 3 4 5 6 7 8) and just hide 3 4 6 and 7. With 1.5.6 oUF will only create 1 2 3 4 and assign these to be 3 4 6 7.

Yeah, that's actually a pretty awesome change for raidframes with an aura filter that only show 1 icon at a time.

zork · 02-06-11, 06:39 AM

Currently testing 1.5.7. Do you need some specific tests? Vehicle combat, raid etc?

haste · 02-06-11, 08:43 AM

Not really. General testing is always needed however.

mojosdojo · 02-06-11, 06:01 PM

Originally Posted by haste

Short summary would be:
- bossN units don't use OnUpdate anymore.

This seems to have the effect that my boss frames are not updating anymore. They get updated when I mouse over them, but that's as far as it goes.

haste · 02-07-11, 12:04 AM

Originally Posted by mojosdojo

This seems to have the effect that my boss frames are not updating anymore. They get updated when I mouse over them, but that's as far as it goes.

How are you spawning them? Mousing over the frame shouldn't trigger any updates either.

zork · 02-07-11, 03:07 AM

I'm going to check bossframes tonight. Running 1.5.7. Currently no problems.

haste · 02-07-11, 03:12 AM

You can test boss frames in SFK and DM normal, as far as I know they are the only low level normal instances with boss units.

(Sent from my phone)

mojosdojo · 02-07-11, 04:37 AM

Originally Posted by haste

You can test boss frames in SFK and DM normal, as far as I know they are the only low level normal instances with boss units.

Ah, great, didn't know that. I did some testing and reverted https://github.com/haste/oUF/commit/...7756f730ca12da which results in normally updating boss frames.

I'm using oUF_Phanx which uses a spawn function for all frames (around line 450 in core.lua). It reads a table from config.lua, I edited the table to additionally spawn the boss frames.

Hope that helps.

haste · 02-07-11, 06:13 AM

That doesn't really answer my question about how they are spawned. I'll have a look at this when I get home.

(Sent from my phone)

mojosdojo · 02-07-11, 06:41 AM

No, it doesn't but it's neither my layout nor am I into oUF api. That's why I can't give you a more specific answer, as long as you aren't more specific on what you actually need to know.

haste · 02-07-11, 06:50 AM

Test with the Git version of oUF_Lily, and see if you can recreate the issue. I can't say I've had any issue with it myself.

If the issue exists with oUF_Lily as well, then I need to know what WoW version you are on. 4.0. 3 should have fixed the boss unit issue, and I don't know of a region that doesn't have that patch yet.

(Sent from my phone)

Talyrius · 02-07-11, 08:50 AM

The boss frames aren't updating anymore unless I target them. I observed this while fighting Cho'gall.

haste · 02-07-11, 11:09 AM

boss units: Verified. Seems like it's a regression. It was working at some point.

zork · 02-08-11, 02:27 AM

Wierd. The bossframe in my daily heroic updated normally yesterday.

Spawn:
http://code.google.com/p/rothui/sour...units/boss.lua

But maybe I got lucky.

mojosdojo · 02-08-11, 05:38 AM

They would update if you were targeting the boss, but even then it wasn't reliable.

zork · 02-08-11, 04:32 PM

Correct. Could verify that on Conclave of the Winds encounter. (Used 2.5.7 on that try)

2.5.8 is already available with a fix, so who cares.