Help with Table

rx12network · 06-08-12, 04:35 PM

Heyho,

i just try to beginn with lua.. but got my first problem... i try to make a table with indexes. i think you will know what i mean when you read the code below..

my problem is that the table will fill up in the loop (its ok) but he write just one line and overwrite it again again and again bla...

maybe someone can tell me how to work with auto-adding-rows in the loop.

P.s. sry for my bad eng - im german

Code:

ChatFrame1:AddMessage("----------------"); -- make seperator


for i=1,GetNumRaidMembers() do
   local name, rang, grp, lvl, klasse, class, zone, online, tot = GetRaidRosterInfo(i); -- read raidinfos
   
   if type(charinfo) ~= "table" then --check tableexist
      
      -- MAKE LIST with standart values if not exist
      charinfo = {}
      
      charinfo.cname = 1;
      charinfo.crang = 1;
      charinfo.cvisit = 0;
      charinfo.czone = 1;
      
   else  --otherwise
      
      
      if charinfo.cvisit ~= nil then  --check if player meeted befor
     
         
         charinfo.cname = name;  --fill db with values
         charinfo.crang = rang;
         charinfo.cvisit = 1;
         charinfo.czone = zone;
         
         print(charinfo.czone, charinfo.cname, charinfo.cvisit) --check
         
         
         ChatFrame1:AddMessage("Noch keine Begegnungen mit ".. charinfo.cname ..""); --chatmessage no visits befor
         
         
         
      else
         ChatFrame1:AddMessage("B: " .. charinfo.cname .. "| " .. charinfo.cvisit) -if visited chatmessage how often
         
         
         
         
      end
   end   
   
   
   
end

thanks

Haleth · 06-08-12, 05:18 PM

Your table will look like this:

Code:

charinfo = {
	["cname"] = name,
	["crang"] = rang,
	["cvisit"] = 1,
	["czone"] = zone,
}

And you just update those 4 values with every iteration over the table.

What you want, I think, is this:

Code:

charinfo = {
	["1"] = {
		["cname"] = name,
		["crang"] = rang,
		["cvisit"] = 1,
		["czone"] = zone,
	},
	["2"] = {
		["cname"] = name,
		["crang"] = rang,
		["cvisit"] = 1,
		["czone"] = zone,
	},...
}

I don't have access to WoW atm but try this:

Code:

...
	charinfo[i] = {
		["cname"] = name,
		["crang"] = rang,
		["cvisit"] = 1,
		["czone"] = zone,
	}
...

p3lim · 06-08-12, 05:22 PM

charinfo[i].cname = name
.. etc

Rilgamon · 06-09-12, 01:35 AM

I'm not in game ... an easier way is to store the return of the function directly into a table.

Lua Code:

local charinfo = {} -- use local variables where possible. Dont use generic names like 'charinfo' when you create global variables.
for i=1,GetNumRaidMembers() do
    local newchar = {GetRaidRosterInfo(i)} -- read raidinfos as a table
    if(newchar[1] ) then -- only continue if name has a value 
        local found = false
        for key, value in ipairs(charinfo) do -- check your 'charinfo' if the name exists.
            if(value[1] == newchar[1]) then
                print("Found")
                found = true
                break -- stop the for-loop
            end
        end
        if(not found) then
            print("New char")
            charinfo[#charinfo + 1] = newchar
        end
    end
end

rx12network · 06-09-12, 05:57 AM

heyho,

thanks for the good and fast replys

i tried it now so and it looks that it work

just the part with

if name == value then (please look in the code)

dont work realy couse its first cvisit, number and after it is cname, name. tried to lookup the index with

if value[1] == name but dont work too

again big thanks for helping a newbie

Lua Code:

ChatFrame1:AddMessage("----------------");
 
 
for i=1,GetNumRaidMembers() do
   local name, rang, grp, lvl, klasse, class, zone, online, tot = GetRaidRosterInfo(i);
   
   
   if type(chari[i]) ~= "table" then
      
      -- MAKE LIST
      
      chari[i] = { 
         cname = 0, crang = 0, cvisit = 1, czone = 0
      }
      print("lol")
      
   else
      
      for key, value in pairs(chari[i]) do
        
         if name == value then
             print(key, value)
            print("Found")
               ChatFrame1:AddMessage("B: " .. chari[i]["cname"] .. " | " .. chari[i]["cvisit"])
               chari[i]["cvisit"] = chari[i]["cvisit"] +1
               break
               
            end
            
            for key, value in pairs(chari[i]) do
               print(key, value)
               if value ~= name then
                  
                  print("Not found")
                  chari[i] = { 
                     cname = name, crang = rang, cvisit = 1, czone = zone
                  }
                  
                  break
               end 
               
               
            end
         end   
         
      end
      
   end

**EDIT

Is there no way to work with a database? its stupid to work with nonshowed tables.. i saw gathermate for ex. work with a downable database from wowhead.
Some way for better parsing and multicolumtables like sql would be nice for select statements.

Phanx · 06-09-12, 07:43 AM

Originally Posted by rx12network

Is there no way to work with a database? its stupid to work with nonshowed tables.. i saw gathermate for ex. work with a downable database from wowhead.
Some way for better parsing and multicolumtables like sql would be nice for select statements.

See Things Addons/Macros Can't Do. In particular, addons cannot see, read from, or write to any files on the hard disk, so no, it is not possible to work with any kind of "real" database like SQLite.

Addons that use the term "database" refer to data stored in simple Lua tables, including the addon that provides GatherMate with data from Wowhead.

I don't know what you mean by "nonshowed tables", but Lua tables are extremely simple to work with, and there's not really any need for complex SQL statements. It would be easy (though tedious and pointless) to write a wrapper around basic table operations to support SQL statements, but it would be far more effort than just using the basic table operations, so I can't imagine anyone actually doing it.

Finally, if you describe what goal you actually want to accomplish, we can almost certainly be more helpful in showing you the easiest way to achieve that goal.

Anyway, here are some examples that may or may not be helpful; without knowing what you actually want to do, it's pretty hard to tell you the best way to do it.

Lua Code:

-- Main storage table:
local alldata = {}
 
-- Populate the table:
local function UpdateData()
    local numRaidMembers = GetNumRaidMembers()
 
    for i = 1, numRaidMembers do
        -- Get info about this raid member:
        local name, rank, subgroup, level, className, class, zone, online, isDead, role, isML, combatRole = GetRaidRosterInfo(i)
 
        local chardata
 
        -- Check if data already exists at this index:
        if alldata[i] then
            -- If so, clear it and reuse the table:
            chardata = wipe(alldata[i])
        else
            -- Otherwise, create a new table:
            chardata = {}
        end
 
        -- Fill in the table:
        chardata.index, chardata.name, chardata.rank, chardata.subgroup, chardata.level, chardata.className, chardata.class, chardata.zone, chardata.online, chardata.dead, chardata.role, chardata.masterLooter, chardata.combatRole = i, name, rank, subgroup, level, className, class, zone, online, isDead, role, isML, combatRole
 
        -- Create or update the data at this index in the main storage table:
        alldata[i] = chardata
    end
 
    if numRaidMembers < #alldata then
        -- Remove data at unused indices:
        for i = numRaidMembers + 1, #alldata do
            -- It would be more efficient to recycle the tables, but
            -- that is beyond the scope of this simple example, so here
            -- we will just let the garbage collector handle it:
            alldata[i] = nil
        end
    end
end
 
-- Update the table each time the raid roster changes:
local frame = CreateFrame("Frame")
frame:RegisterEvent("RAID_ROSTER_UPDATE")
frame:SetScript("OnEvent", UpdateData)

To get information about a character by their name:

Lua Code:

-- Function to return information about the named character:
local function GetCharacterByName(name)
    -- Loop through the data at each index:
    for i, chardata in ipairs(alldata) do
        -- Check the data's name value against the search value:
        if chardat.name == name then
            -- If it matches, return the character's data table.
            return chardata
        end
    end
end
 
-- Get information about the character whose name is "Benny":
local Benny = GetCharacterByName("Benny")
if Benny then
    print(string.format("%s is a level %d %s in group %d at index %d.", Benny.name, Benny.level, Benny.className, Benny.subgroup, Benny.index))
else
    print("Benny is not in the raid.")
end

To get a count of all characters who are rogues:

Lua Code:

-- Function to get a count of all characters with the specified class:
local function GetNumCharactersByClass(class)
    local count = 0
    for i, chardata in ipairs(alldata) do
        if chardata.class == class then
            count = count + 1
        end
    end
    return count
end
 
-- Get a count of all rogues:
print(string.format("There are %d rogues in the raid.", GetNumCharactersByClass("ROGUE")))

To get information about all the characters in group 3:

Lua Code:

-- Function to get information about all characters in a group:
local function GetCharactersByGroup(group)
    local results = {}
    for i, chardata in ipairs(alldata) do
        if chardata.subgroup == group then
            tinsert(results, chardata)
        end
    end
    return results
end
 
-- Get information about group 3:
local group3 = GetCharactersByGroup(3)
if #group3 == 0 then
    print("Group 3 is empty!")
else
    local names
    for i, chardata in ipairs(group3) do
        if names then
            if i == #group3 then
                -- Last name on the list:
                names = names .. ", and " .. chardata.name
            else
                -- Name in the middle of the list:
                names = names .. ", " .. chardata.name
            end
        else
            -- First name on the list:
            names = chardata.name
        end
    end
    print(string.format("There are %d characters in group 3: %s.", #group3, names))
end

Rilgamon · 06-09-12, 08:04 AM

Its difficult to help without knowing a little bit more about how you want to use the information.
Writing in your table using the current raidslot as index makes it difficult to keep the data valid since raidslots can change when someone is moved around,joins or leaves. And if you want to gather the informations over a longer period with different raids then the ids are meaningless.

If you want to store information about a char and store it in savedvariables perhaps you should use the name (and server) instead of the raidslot as index.

rx12network · 06-09-12, 08:23 AM

at first big thanks at Phanx for the nice codesnippets ^_^

what i want to do:
i hear in teamspeak in random raids always "hey.. i think i saw you before blabla"

so i want to try to write a addon that catch informations from persons that are in the raid and save it with timestamp, class, lvl etc (much of them from raidrosterinfo).

So when raid is full the addon can check ahh u saw person xy 6 times before.. with a click in the gui he can lookup more information about the person.

i know it will cost much of time.. im reading atm the book "Beginning Lua with World of Warcraft".
And i downloadet me the LuaBrowser (addon for wow)... its helpfull to understand tables in lua ^^ i think i think to complicated from c# and sqllite hehe

------ EDIT ------
i think i finaly got it to work

here is the code

Lua Code:

ChatFrame1:AddMessage("----------------"); -- Add Message to Chat
 
 
for i=1,GetNumRaidMembers() do  --Get Raid Information
   local name, rang, grp, lvl, klasse, class, zone, online, tot = GetRaidRosterInfo(i);
   
   
   
   if type(RaidChecker) ~= "table" then  --check if table exist
      
      -- MAKE LIST
      
      RaidChecker = {
      }
      
      
   else --otherwise
      
      if RaidChecker[name] == nil then  --if name not in table
         
         RaidChecker[name] = {  --put informations in table
            cname = name,
            cvisit = 1,
            crang = rang,
            clvl = lvl,
            cklasse = klasse,
            cclass = class,
            zone = zone
         }
         
         print("Neue Nutzer Angelegt!") --just debugging
         break
         
      end 
      
      
      
      for key, value in pairs(RaidChecker) do
         
         if RaidChecker[name]["cname"] == name then --if name exist
            
            
            ChatFrame1:AddMessage("B: " .. RaidChecker[name]["cname"] .. " | " .. RaidChecker[name]["cvisit"])
            RaidChecker[name]["cvisit"] = RaidChecker[name]["cvisit"] +1 --ad one visit
            print("User found, adding a visit")
            break
            
         end
         
      end
      
      
      
      
      
      
   end   
   
end

Torhal · 06-09-12, 10:52 PM

Originally Posted by Phanx

It would be easy (though tedious and pointless) to write a wrapper around basic table operations to support SQL statements, but it would be far more effort than just using the basic table operations, so I can't imagine anyone actually doing it.

Actually, ckknight went a little insane and wrote the 9k-lines LibLinq. Though not actually SQL, it's damn close and I still have no idea why he did this.

Dridzt · 06-10-12, 04:13 PM

Humbedooh had started LibSQL-1.0 but he dropped it at the same time he dropped WoW

Phanx · 06-10-12, 09:57 PM

Still, why bother with all that overhead? Not only will using Lua table operations directly always be more efficient than going through a wrapper, but understanding what you're actually doing will make you a better programmer.

Torhal · 06-11-12, 12:08 AM

Originally Posted by Phanx

Still, why bother with all that overhead? Not only will using Lua table operations directly always be more efficient than going through a wrapper, but understanding what you're actually doing will make you a better programmer.

I totally agree - I was just pointing out that there ARE folks who are that insane.