ADDON_LOADED does not work

[evilbib]

So this code below does nothing. No errors.
If I remove the "if addon" line it works, but then it will be executed multiple times. This did work before 6.2.

Somebody can help me?

local function ApplySkin(self, event, addon)
    if addon == "Skada" then
        local SkadaDisplayBar = Skada.displays["bar"]
        hooksecurefunc(SkadaDisplayBar, "AddDisplayOptions", function(self, win, options)
            options.titleoptions = nil
            options.windowoptions = nil
        end)
        hooksecurefunc(SkadaDisplayBar, "Create", function(self, win)
            local skada = win.bargroup          
            local skadaBorder = CreateFrame("Frame", nil, skada, skada)
            skadaBorder:SetAllPoints()
            skadaBorder:CreateBeautyBorder(12)
            skadaBorder:SetBeautyBorderPadding(3)
        end)
        hooksecurefunc(SkadaDisplayBar, "ApplySettings", function(self, win)
            local skada = win.bargroup
            skada:SetBackdrop({ 
                bgFile = "Interface\\Tooltips\\UI-Tooltip-Background", 
                edgeFile = nil, tile = false, tileSize = 0, edgeSize = 32, 
                insets = { left = 0, right = 0, top = 0, bottom = 0 }
            })
            skada:SetBackdropColor(0, 0, 0, 0.8)
        end)
    end
end
 
local f = CreateFrame("Frame")
f:RegisterEvent("ADDON_LOADED")
f:SetScript("OnEvent", ApplySkin)

[Tim]

Do keep in mind that that your addon can load before or after Skada. If your addon loads before Skada then there's nothing to apply the skin to. However, if it loads afterwards then you would be good to go.

Try adding Skada to your dependencies (optional or required, whichever) and go from there. Also remember to report lua errors.

[evilbib]

Originally Posted by Tim Do keep in mind that that your addon can load before or after Skada. If your addon loads before Skada then there's nothing to apply the skin to. However, if it loads afterwards then you would be good to go. Try adding Skada to your dependencies (optional or required, whichever) and go from there. Also remember to report lua errors.

Skada is in my dependencies. Also I gave my addon an letter that comes after s but nothing helps and like I said there are no LUA errors.

[Banknorris]

You can also check for the existence of SkadaDisplayBar

if SkadaDisplayBar then
    --call a function that hooks SkadaDisplayBar
else
    f:RegisterEvent("ADDON_LOADED")
end

[elcius]

most likely skada is not ready, check when it actually builds the displays, because i doubt it does it on load.
the most resilient solution would be to just wait until it's ready:

C_Timer.NewTicker(0.1, function(self)
	local SkadaDisplayBar = Skada.displays["bar"];
	if not SkadaDisplayBar then -- you may need to check other stuff also
		return
	end
	hooksecurefunc(SkadaDisplayBar, "AddDisplayOptions", function(self, win, options)
		options.titleoptions = nil
		options.windowoptions = nil
	end)
	hooksecurefunc(SkadaDisplayBar, "Create", function(self, win)
		local skada = win.bargroup          
		local skadaBorder = CreateFrame("Frame", nil, skada, skada)
		skadaBorder:SetAllPoints()
		skadaBorder:CreateBeautyBorder(12)
		skadaBorder:SetBeautyBorderPadding(3)
	end)
	hooksecurefunc(SkadaDisplayBar, "ApplySettings", function(self, win)
		local skada = win.bargroup
		skada:SetBackdrop({ 
			bgFile = "Interface\\Tooltips\\UI-Tooltip-Background", 
			edgeFile = nil, tile = false, tileSize = 0, edgeSize = 32, 
			insets = { left = 0, right = 0, top = 0, bottom = 0 }
		})
		skada:SetBackdropColor(0, 0, 0, 0.8)
	end)
	self:Cancel();
end, 1e4);

[Seerah]

If Skada is in your dependencies, then it will be loaded before your addon. This means that Skada's ADDON_LOADED event will fire before your code is run. Which means that it's loaded already, and you don't need to wait for it.

[evilbib]

if event == "PLAYER_ENTERING_WORLD" then
        C_Timer.NewTicker(0.1, function(self)
            local SkadaDisplayBar = Skada.displays["bar"]
            if not SkadaBarWindowDamage then 
                return
            end
            SkadaBarWindowDamage:CreateBeautyBorder(12)
            hooksecurefunc(SkadaDisplayBar, "AddDisplayOptions", function(self, win, options)
                options.titleoptions = nil
                options.windowoptions = nil
            end)
            hooksecurefunc(SkadaDisplayBar, "ApplySettings", function(self, win)
                local skada = win.bargroup
                skada:SetBackdrop({ 
                    bgFile = "Interface\\Tooltips\\UI-Tooltip-Background", 
                    edgeFile = nil, tile = false, tileSize = 0, edgeSize = 32, 
                    insets = { left = 0, right = 0, top = 0, bottom = 0 }
                })
                skada:SetBackdropColor(0, 0, 0, 0.8)
            end)
            self:Cancel()
        end, 1e4)
    end

This is what I have now and it works.

But still I wonder why it stopped working all of a sudden, I also tried older Skada versions.

[meribold]

Originally Posted by Seerah If Skada is in your dependencies, then it will be loaded before your addon. This means that Skada's ADDON_LOADED event will fire before your code is run. Which means that it's loaded already, and you don't need to wait for it.

This. Think about it, when the client gets to loading your event handler, ADDON_LOADED has already been posted for Skada, while your AddOn had no chance to react to it yet.

The question is why this even used to work.

Edit: I would suggest just checking for your own AddOn's name instead of "Skada".

[evilbib]

Originally Posted by meribold This. Think about it, when the client gets to loading your event handler, ADDON_LOADED has already been posted for Skada, while your AddOn had no chance to react to it yet. The question is why this even used to work. Edit: I would suggest just checking for your own AddOn's name instead of "Skada".

I added Skada to my dependencies after the first answer.

[Lombra]

Make a simpler program to troubleshoot it from the top. Maybe disable some other addons if you're getting spammed by this.

if IsAddOnLoaded("Skada") then
	print("Skada is already loaded")
else
	local f = CreateFrame("Frame")
	f:RegisterEvent("ADDON_LOADED")
	f:SetScript("OnEvent", print)
end

[evilbib]

Sorry guys I am retarded, I updated the addon nCore which has skada as OptionalDeps. I tried reloading with only skada and my addon but since nCore was already loaded I didn't notice. Now I removed skada from nCore and my initial code works again.