GarrisonMissionListButtonTemplate button -> replace OnClick = ADDON_ACTION_FORBIDDEN

[sezz]

Code: (click on a mission and press escape twice to close mission + main frame to get the error)

local GarrisonMissionButton_OnClickHook = function(self, button)
    GarrisonMissionButton_OnClick(self, button);
end
 
local GarrisonMissionList_UpdateHook = function(self)
    local availableMissionsTabShown = not OrderHallMissionFrame.MissionTab.MissionList.showInProgress;
    local missions = availableMissionsTabShown and OrderHallMissionFrame.MissionTab.MissionList.availableMissions or OrderHallMissionFrame.MissionTab.MissionList.inProgressMissions;
    local numMissions = #missions;
 
    if (numMissions > 0) then
        local scrollFrame = OrderHallMissionFrame.MissionTab.MissionList.listScroll;
        local buttons = scrollFrame.buttons;
        local offset = HybridScrollFrame_GetOffset(scrollFrame);
        local numButtons = #buttons;
 
        for i = 1, numButtons do
            local button = buttons[i];
            local index = offset + i;
 
            if (index <= numMissions) then
                local mission = missions[i + offset];
                if (not button.hooked) then
                    button:RegisterForClicks("LeftButtonUp", "RightButtonUp");
                    button:SetScript("OnClick", GarrisonMissionButton_OnClickHook);
                    button.hooked = true;
                end
            end
        end
    end
end
 
local f = CreateFrame("Frame");
f:RegisterEvent("ADDON_LOADED");
f:SetScript("OnEvent", function(self, event, addon)
    if (addon == "Blizzard_OrderHallUI") then
        hooksecurefunc(OrderHallMissionFrame.MissionTab.MissionList, "Update", GarrisonMissionList_UpdateHook);
        self:UnregisterEvent(event);
    end
end);

Error:

Message: ADDON_ACTION_FORBIDDEN: OrderHallTaint tried to call the protected function 'SpellStopCasting()'.
Time: 06/08/16 13:30:59
Count: 1
Stack: [C]: in function `SpellStopCasting'
Interface\FrameXML\UIParent.lua:3660: in function `ToggleGameMenu'
[string "TOGGLEGAMEMENU"]:1: in function <[string "TOGGLEGAMEMENU"]:1>

Locals: <none>

Any idea why this is happening or how to workaround this? It works fine at WoD garrisons in Legion (and of couse in WoD).
The reason why I'm replacing OnClick is to handle RightButtonUp (GarrisonMissionButton_OnClick doesn't care about button).

I'm not getting the error when removing SpellStopCasting() and SpellStopTargeting() from ToggleGameMenu() (or when moving securecall("CloseAllWindows") up 2 lines) and UnitCastingInfo("player") returns nil.

PS: @Dolby: This cloudflare protection is so annoying, it shows up *everytime* before previewing this post.

[elcius]

you can't just call GarrisonMissionButton_OnClick, if you want to hook the click handler, use button:HookScript('OnClick',function() .. end)

[Miiru]

I have had a lot of these errors myself while hooking stuff at the orderhall ui. The (basicly) same function work at the garrison ui without any error.
Going to the orderhall and typing /run OrderHallMissionFrame:MissionCompleteInitialize() will get the same taint as you posted, whilst at the agrrison
/run GarrisonMissionFrame:MissionCompleteInitialize() wont get any taint error. I also noticed that OrderHallMissionFrame.MissionPage,"EscapePressed" will easily cause taint :/
To me it almost seems like it puts the palyer in a state comparable to an incombat state and thus causing.

[sezz]

Originally Posted by elcius you can't just call GarrisonMissionButton_OnClick, if you want to hook the click handler, use button:HookScript('OnClick',function() .. end)

I don't want to hook it because Blizzard doesn't check for LeftButton and I don't want to show mission details when clicking a mission with the right mouse button.

But I did another test by adding a frame on top of the button that catches the clicks (so the mission button's OnClick handler doesn't get executed) and I still get the error, even if my OnClick handler is as simple as this (and basically does nothing, it only sets isZoneSupport, just like Blizzard does in OrderHallMission.OnClickMission):

local missionButton = self:GetParent();
local missionFrame = missionButton:GetParent():GetParent():GetParent():GetParent():GetParent();
local missionInfo = missionButton.info;
missionFrame.MissionTab.isZoneSupport = missionInfo.isZoneSupport;

This is easily reproducable without any addons by clicking a mission, executing

/run OrderHallMissionFrame.MissionTab.isZoneSupport = OrderHallMissionFrame.MissionTab.isZoneSupport;

and pressing escape twice.

[sezz]

seems fixed now