Detect mail from ah

[Tntdruid]

Hello,

first my code:

function Accountant_DetectAhMail()
    local numItems = GetInboxNumItems()
    local invoiceType = GetInboxInvoiceInfo(numItems)
    if invoiceType == "seller" then
    auditorMode = "AH";
        else
    auditorMode = "MAIL";
    end
end

I'm trying to Detect if the mail is from a succesfull auction, it never return the AH or MAIL, i'm still new to lua stuff, been looking at
http://wowprogramming.com/docs/api/GetInboxInvoiceInfo
http://wowprogramming.com/docs/api/GetInboxNumItems

[Duugu]

I don't know what the invoiceType string exactly looks like, but I guess it is something like "Sold item: Seller ..."?

In that case you'll have to search for the pattern "seller" inside the string. Comparing the full string does not work as "seller" is not equal to "Sold item: Seller ....".

if string.find(invoiceType, "seller") then

If you are unsure if it is "seller" or "Seller" or "SELLER" or whatever, then it could be helpful to convert invoiceType before comparing them:

if string.find(string.lower(invoiceType), "seller") then

And last but not least you should declare auditorMode as local and return it with you function:

function Accountant_DetectAhMail()
    local numItems = GetInboxNumItems()
    local invoiceType = GetInboxInvoiceInfo(numItems)
    local auditorMode
    if invoiceType == "seller" then
        auditorMode = "AH";
    else
        auditorMode = "MAIL";
    end
    return auditorMode
end

If you do not use auditorMode somewhere else then this would be a better way to do it:

function Accountant_DetectAhMail()
    local numItems = GetInboxNumItems()
    local invoiceType = GetInboxInvoiceInfo(numItems)
    if invoiceType == "seller" then
        return "AH"
    else
        return "MAIL"
    end
end

Personally I would return a boolean instead of a string as this is a bit easyer to handle. Like

function Accountant_DetectAhMail()
    local numItems = GetInboxNumItems()
    local invoiceType = GetInboxInvoiceInfo(numItems)
    if invoiceType == "seller" then
        return true
    end
end

Then use it like

if Accountant_DetectAhMail() then
    --
end

instead of doing something like

if Accountant_DetectAhMail() == "AH" then
    --
end

[e]
And if you're not using multiple files with you addon, then you should probably declare you function as local:

local function Accountant_DetectAhMail()
    local numItems = GetInboxNumItems()
    local invoiceType = GetInboxInvoiceInfo(numItems)
    if invoiceType == "seller" then
        return true
    end
end

[Tntdruid]

Very nice thanks for the help, gonna play a bit whit it

[Tntdruid]

Still don't fire when i get money from the ah in the mail.

[Duugu]

do'h ... just had overwritten my on old post

[Tntdruid]

Tested the last code you added, its never print any thing.

[Duugu]

Hm. Wowprogramming says

numItems, totalItems = GetInboxNumItems() Returns: •numItems - Number of mails in the player's inbox (number) •totalItems - Total number of items both in the inbox and on the server. (number)

I'm not sure what the difference is as I never did something with the mail api.
Totally guessing: the first one is the number of mails the player had opened at least once, and the second one is the number of opened and unopened mails?

You could try:

local function Accountant_DetectAhMail()
    local numItems, totalItems = GetInboxNumItems()
    for x = 1, totalItems do    
        local invoiceType = GetInboxInvoiceInfo(x)
        print(x, invoiceType)
        if string.find(string.lower(invoiceType), "seller") then
            return true
        end
    end
end

Does this change anything?

[Tntdruid]

Still return nill, there are like no info on google about that

[Duugu]

I'll look into it later on. Don't have any access to a wow client right now.

[Tntdruid]

Sure no problems

[Duugu]

Looks as GetInboxNumItems() returns the number of mails in your inbox that were in it when you opened it the last time.
I would say you can't query GetInboxNumItems() (or at least don't get up-to-date results) without an open inbox.

What does happen if you open your mailbox and then use the function?

[Tntdruid]

When i open the mailbox i get:
Message: Interface\AddOns\Accountant_Classic\Accountant.lua:459: attempt to call global 'Accountant_DetectAhMail' (a nil value)
Time: 09/23/14 17:51:09
Count: 1
Stack: Interface\AddOns\Accountant_Classic\Accountant.lua:459: in function `Accountant_OnEvent'
[string "*:OnEvent"]:1: in function <[string "*:OnEvent"]:1>
[C]: in function `TurnOrActionStop'
[string "TURNORACTION"]:4: in function <[string "TURNORACTION"]:1>

Locals: self = AccountantFrame {
0 = <userdata>
numTabs = 5
selectedTab = AccountantFrameTab1 {
}
}
event = "MAIL_SHOW"
arg1 = nil
arg2 = nil
oldmode = ""
(*temporary) = nil
(*temporary) = "attempt to call global 'Accountant_DetectAhMail' (a nil value)"


link to the code https://github.com/Tntdruid/Accounta...Accountant.lua

[Duugu]

Remove the local keyword from

local function Accountant_DetectAhMail()

There's another problem. You can't check on MAIL_SHOW as this event is triggered if the inbox is opened. There won't be any data at this point as the client needs a moment to query the mail data from the server.
Use MAIL_INBOX_UPDATE instead:

elseif event == "MAIL_INBOX_UPDATE" then
        Accountant_DetectAhMail();

and add

self:RegisterEvent("MAIL_INBOX_UPDATE");

to Accountant_RegisterEvents(self)

[Tntdruid]

it's still trigger the OTHER event and not the AH.

Can see seller is corect for mail from ah whit gold.

[Duugu]

Did you remove

458     elseif event == "MAIL_SHOW" then 
459         Accountant_DetectAhMail();

?

[Tntdruid]

yes its gone

[Duugu]

Well, then let's talk about what you're trying to accomplish.

Are you looking for something like this?

...
elseif event == "MAIL_INBOX_UPDATE" then
    if Accountant_DetectAhMail() then
        Accountant_Mode = "AH"
    end
...

function Accountant_DetectAhMail()
    local numItems, totalItems = GetInboxNumItems()
    for x = 1, totalItems do    
        local invoiceType = GetInboxInvoiceInfo(x)
        if invoiceType == "seller" then
            return true
        end
    end
end

[Tntdruid]

I want the AH when i sell stuff on ah, MAIL for normal mails.

[Tntdruid]

Originally Posted by Duugu Well, then let's talk about what you're trying to accomplish. Are you looking for something like this? ... elseif event == "MAIL_INBOX_UPDATE" then     if Accountant_DetectAhMail() then         Accountant_Mode = "AH"     end ... function Accountant_DetectAhMail()     local numItems, totalItems = GetInboxNumItems()     for x = 1, totalItems do             local invoiceType = GetInboxInvoiceInfo(x)         if invoiceType == "seller" then             return true         end     end end

This code works 100%, only problem if i send gold to an alt its gonna show up as AH and not in the MAIL section

[Phanx]

Originally Posted by Tntdruid This code works 100%, only problem if i send gold to an alt its gonna show up as AH and not in the MAIL section

Based on a reading of the documentation for GetInboxInvoiceInfo that function would not return any data for mail not sent by the AH itself. If you want to see if non-AH messages have gold attached, use GetInboxHeaderInfo instead.