Problem with GetItemQualityColor

[Mayron]

Hi everyone,

I have a bug which I cannot seem to fix or figure out what is causing it. I have this code:

local function updateIcons()
    if not PaperDollFrame:IsShown() then return end
    
    for i, slot in next, slots do
        if i == 18 then i = 19 end
        local link = GetInventoryItemLink("player", i)
        local slotName = _G["Character"..slot.."Slot"]
        local iconBorder = _G["mui_" .. "Character" .. slot .. "Slot"]          
        
        if link then
            slotName.icon:SetAlpha(1)
            local r, g, b, _ = GetItemQualityColor(select(3, GetItemInfo(link)))
            iconBorder:SetBackdropBorderColor(r, g, b, 1)
            iconBorder:SetBackdropColor(r,g,b,0.2)          
        end
    end
end

running with this:

PaperDollFrame:HookScript("OnShow", updateIcons)
    ef:RegisterEvent("UNIT_INVENTORY_CHANGED")
    ef:SetScript("OnEvent", updateIcons)

in a PLAYER_LOGIN event. However this line:

local r, g, b, _ = GetItemQualityColor(select(3, GetItemInfo(link)))

shows this lua error each time I login:

Message: Interface\AddOns\MayronUI_Core\Skinning.lua:174: Usage: GetItemQualityColor(index)
Time: 05/04/14 22:10:48
Count: 15
Stack: [C]: ?
[C]: in function `GetItemQualityColor'
Interface\AddOns\MayronUI_Core\Skinning.lua:174: in function <Interface\AddOns\MayronUI_Core\Skinning.lua:163>

Locals:

It is just to get item icons fro mthe character frame and color the border depending on the items rarity value. I am not sure why this is happening because the player has logged in and it does actually work, but I get the error saying I'm using it incorrectly? I'm not sure and hopefully the code makes sense to know what I am trying to do. If anyone has any advice or a fix for me then that would be brilliant but if you need extra information let me know. Thanks in advance guys!


Usage: GetItemQualityColor(index)

[Lombra]

Either the link you get is bad, or GetItemInfo doesn't return stuff still, I reckon.

There seems to be a function GetInventoryItemQuality you can use instead.

[Malakahh]

According to this: http://wowpedia.org/API_GetItemInfo
If you have not seen (I imagine this means your client have not yet made a call to GetItemInfo on some level, either through blizz code or otherwise) the item before in the current session, this function will return nil and asynchronously query the item from the server, which would break your current code.
I think a workaround would then be to, on PLAYER_ENTERING_WORLD, loop through all equipped items and call GetItemInfo() in order to query the server so that you now have "seen" the item, so that they are ready for when your OnShow is called.

EDIT:
Lombra's solution seems to be designed for your exact purpose, go with that.

[Mayron]

Thanks guys, I am not sure how I overlooked that method. Will try it tonight