KC_EnhancedTrades v0.98 through current

[Kaelten]

I'm starting a new thread as the old one has gotten rather long.

Please post bugs and feature requests here.

Thanks guys.

Kael

[Kaelten]

I guess no one has found any bugs so far... only been a few hundred dls. At least I hope thats what the silence means.

[Kaelten]

hmm more than 24 hours without a bug report.... Now my fear is turning into being hopeful, lol

[cyatis]

Downloaded version 98a.

To keep this post short.
Your mod is excellent, awesome job.
All of the previous bugs seem to be fixed. (Hunter, Item updates etc.)
It runs without noticable lag here.
Thanks for adding feature "not visited bank", I found it useful even in testing your mod this round.
Alt support - It works as designed and intended.

My next post will be about refining some parts of the mod even more.
Thanks for your time and awesome rewrite,
Cyatis

[Kaelten]

Hehe, glad to hear it. I was worried that the silence ment the bugs where to insidious to find... which they still might be. lol. Thanks for the feedback and anything you can post in the way of suggestions and the like would be appriciated. Also take a look at the roadmap, might be of interest to you.

[leftler]

I sent you a PM on Wolrld of war.net but i dont know if you got it.


two requests, PLESE PLESE PLESE keep a feature like /tsf in, it was so helpfull so many times.

also a request, If we mouseover a reagent like cole or mageweve or even thred, put in the tooltip how many we have alredy on us and in the bank, it makes farming for herbs so much nicer.

[cyatis]

My benchmark of a good mod is practical use. Here is just an idea for you to think about.

The last line of the mod though useful is limited in scope, yet adding even more information to the tradeskill frames wouldn't be very desirable imho.

Idea: Instead of adding even more to the tradeskill window for alts, maybe an extension that displays a tooltip for your recipes as you mouse over your tradeskill recipes, would do the trick for alts. Then perhaps, only show the extra tooltip if (i+b+v+alts) would exceed (i+b+v), or simply when needed.

Idea: Ability to turn the extra tooltip on and off, obvious enough.

Just an idea, example tooltip format:
--------------------
Total possible items: (i+v+b+alts) ... might do without if tooltip well placed
Recipe: ( recipe name)
Requires: # (item name), # (next item name), etc... +buyable and dropping zeroes from list
-- might need an extra linefeed here....
(character insert name) has: # (item name), # (next item name) etc... dropping zeroes from list
(if no items for the list then don't display the character)
Next character, repeats loop until done....

Clean it looks something like this:

Total possible items: 32
Recipe: elixir of wisdom
Requires: 2 mageroyal, 1 briarthorn, 1 empty vial(buyable)

Onetradeskillguy has: 12 mageroyal
Twotradeskillguy has: 52 mageroyal, 10 briarthorn
Fourtradeskillguy has: 22 briarthorn, 8 empty vial(buyable)

Thanks for your time,
Cyatis

[Cluey]

hi Kaelten I have been using 0.98a since you uploaded it, I have grabbed 0.98b but I haven't used it yet and the change notes didn't indicate anything to do with a bit of a bug I have been noticing.
I should say that my flat mate is also noticing it.

When we open the blacksmithing, tailoring or enchanting window and then expand one of the trees and click on an item we are getting the wrong reagents in it.
We have to close and reopen the trade skill, sometimes more than once, to get the right ones to show up.
I also get an error from auctioneer if I mouse-over one of the 'wrong' reagents, it basically says "that shouldn't be there".

Overall this is a great mod and I am glad you have taken it up as Pinky had left his for a while and it was generating a lot of errors in the log files.

[Gaal]

How about this bug. EnhancedTrades STILL has version 1700 in it's TOC file!

It doesn't stop me, as I usually fix them myself if they aren't broken (after much testing) but still...

[DSanai]

Kael, KC_ET is causing an error in the Beast Training window (I also run BeastMaster to sort my pet skills; not sure if that's relevant -- but it might be, because the error is thrown after the first grouping displays).

It's causing the first set of skills to display, then a bunch of blank space (which, if you scroll down, will suddenly jump to the next set). It's weird, that's all I got to say.

It has to do with the Unhook command, for some reason. I wish I could tell you more, but BugSack is being a PITA.

I think it's here:

function KC_EnhancedTradesClass:CraftShow()
self.dataCache:reset();
if (GetCraftName() == KC_ENHANCEDTRADES_TEXT_BEASTTRAIN) then
self:Unhook("CraftFrame_SetSelection");
self:Unhook("CraftFrame_Update");
KC_EnhancedTrades_CFButton:Hide()
CraftFrame_Update();
end
end

I ran myDebug to check the value of GetCraftName, and that's alright. Specifically, the error seems to refer to this: self:Unhook("CraftFrame_Update");

Disabling KC_ET allows things to return to normal.

[duckpuppy]

I had been using KCET up to patch 1.8, and disabled it when 1.8 came out until it was fixed... I just updated KCET to 1.1a (deleted the KCET and KC_Items folders before updating) and now the tradeskill windows show [0] for EVERY item and the bank counts aren't showing on any of the reagents. If I turn off smart display of counts, then every item shows [0/0/0/0] (I have the 'a' option off). I also run ReagentInfo and myBank if that makes a difference... any suggestions?

[duckpuppy]

OK, I just got it to work... it didn't pick up any info until I took something out of my bank and put it back in... all the bank counts and everything appeared once I did that. I had thought it only took a visit to the bank and opening the bank screen once to sync KCET. Sorry if this is in a readme somewhere, I'm kinda slow today.

[Kaelten]

thats probably a 1.8 issue I forgot to fix.

[Leviathan]

Hi Kaelten,

You seem to be ignoring the bug report sub-forum so I think I'll just repost the issue in here.

An error shows whenever I open the pet training frame mentioning somehting like no hook for craftFrame_update or something like that.

Thank you for the great add-ons.

[DSanai]

Originally Posted by Leviathan Hi Kaelten, You seem to be ignoring the bug report sub-forum so I think I'll just repost the issue in here. An error shows whenever I open the pet training frame mentioning somehting like no hook for craftFrame_update or something like that. Thank you for the great add-ons.

I mentioned this in post 64; haven't heard anything on it. I've been trying to think of a way to fix it, without any success. I'm glad you posted that you have the same issue though -- I had been wondering if it was an incompatibility with something else.

Any ideas, Kael? I don't want to release the new Emerald without KCET, but I may have to if Hunters can't train their pets with it installed.

[Spryte]

Goodday,
Once again A Great Program!
Lastnight I installed latest versions of ACE ...Kcitems and KcEnhanced trades..
first time ever on this PC.
No errors and all seems to work fine Except When I click the + next to exit to open menu/options it does nothing...
is there a / comand to get into settings/options?

[DSanai]

Originally Posted by Spryte Goodday, Once again A Great Program! Lastnight I installed latest versions of ACE ...Kcitems and KcEnhanced trades.. first time ever on this PC. No errors and all seems to work fine Except When I click the + next to exit to open menu/options it does nothing... is there a / comand to get into settings/options?

BibWindowMods can prevent the + button from working, because it takes over the bar to make it movable. MobileFrames does not interfere, just FYI.

Both mods have slash commands, though. KC Items is /kci and KC_ET is /kcet

[Spryte]

Dsanai,
Thank You for taking the time to reply,
I'am in your debt....You hit the nail right on the head! i use bibmod,I love the buttons.

Thanks For Helping me

Spryte