Question: Cooldown Tracking for Specific Spell

[palalu]

Hi,

I am trying to track cooldown of a specific spell and i am using script below.

local trigger = CreateFrame("Frame")
local track = CreateFrame("Frame")
trigger:SetScript("OnEvent", function(self, event, ...) return self[event](self, ...) end) 
trigger:RegisterEvent("UNIT_SPELLCAST_SUCCEEDED")

function trigger:UNIT_SPELLCAST_SUCCEEDED(unitID, spell, rank, lineID, spellID)
        if not spellID == 107428 then return end
                if spellID == 107428 then
                   track:SetScript("OnUpdate", function(self)
                   local start, duration, enabled = GetSpellCooldown(107428);
                      if start == 0 then
                          PlaySoundFile("Sound\\Character\\BloodElf\\BloodElfMaleCheer02.wav")
                          track:SetScript('OnUpdate',nil)
                      end
                    end)
       end 
end

I am new to LUA scripting , and I am curious if there's a better way in doing this.

ps:wrong section.. should be on Lua/XML Help sorry

thanks

[Malsomnus]

Have you considered using the SPELL_UPDATE_COOLDOWN event for this? Haven't used it myself but it seems like it could work better here.

Plus, on a more general note, I suggest putting that spell ID number in a variable so you don't have to repeat it, and you really should keep proper indentation to make everything more readable

[palalu]

Hi, Thanks for your input.. Gonna try things out with that event

[Phanx]

local isOnCooldown

local f = CreateFrame("Frame")
f:RegisterEvent("SPELL_UPDATE_COOLDOWN")
f:SetScript("OnEvent", function(f, event, ...)
	local start, duration = GetSpellCooldown(107428) -- Rising Sun Kick
	if start > 0 and duration > 0 then
		-- Cooldown started or is still in progress.
		isOnCooldown = true
	elseif isOnCooldown then
		-- Cooldown was in progress, but is now ended.
		isOnCooldown = nil
		PlaySoundFile("Sound\\Character\\BloodElf\\BloodElfMaleCheer02.wav")
	end
end)