Need help simplifying this

[Ne0nguy]

I am trying to create a function that returns True if the player can invite a player to a group or raid but false any other time.

I was able to come up with something but there has to be a way to simplify it.. can anyone give me suggestions?

function CanInvite()
	if(GetNumRaidMembers() > 0 and IsRaidLeader()) then
		return True;
	elseif(GetNumPartyMembers() > 0 and IsPartyLeader()) then
		return True;
	elseif(GetNumPartyMembers() == 0 and GetNumRaidMembers() == 0) then
		return True;
	else
		return False;
	end
end

[Tekkub]

local function CanInvite()
	return GetNumRaidMembers() == 0 and (GetNumPartyMembers() == 0 or IsPartyLeader()) or IsRaidLeader()
end

No real point in wasting the memory for a closure, just stick the logic into your if call directly.

[SDPhantom]

Try this... It's the only way I can think of to shorten it.

function CanInvite()
	return (GetNumRaidMembers() > 1 and IsRaidLeader()) or (GetNumPartyMembers() > 0 and IsPartyLeader()) or (GetNumPartyMembers() <= 0 and GetNumRaidMembers() <= 1);
end

What this does is turn all of the conditions into a single boolean comparison statement. If any of the conditions are true, it'll return so, else it'll be false.



Note: I corrected a couple things, mainly GetNumRaidMembers() does include the player as well, so you need to check if this is greater than 1, not 0.

Edit: Also to note the last condition checking if not in a party or raid has been corrected as well.

[Ne0nguy]

Thanks for the help guys.
Tekkub's example did exactly what I needed it to do.