Text in fram sometimes show wrong text

[Wolfenstein]

Hi everyone. I am pretty new to coding wow addons.

I have written this to keep track of a fire mages fireball crit chance.

FirelordFrame = CreateFrame("Frame", "FirelordFrame", UIParent)
FirelordFrame:RegisterEvent("UNIT_AURA")

function FirelordFrame_OnEvent(self, event, ...)
    local frame = self.frame
    if not frame then
	frame = CreateFrame('Frame', nil, UIParent, 'TimeToDieFrameTemplate')
        frame:EnableMouse(false)
        frame.bg:Hide()
        frame:SetWidth(128)
        frame:SetHeight(128)
        frame:SetPoint("CENTER",-32,0)
        frame.text = frame:CreateFontString(nil, "OVERLAY") --Create a FontString to display text
        frame.text:SetFont("Fonts\\FRIZQT__.TTF", 32, "THICKOUTLINE " )
        frame.text:SetTextColor(1, .75, 0)
        frame.text:SetAllPoints()
        frame.text:SetText("")
        frame.text:Show()
        frame:Show()
	self.frame = frame
	end
    local name, rank, icon, count = UnitBuff("player","Enhanced Pyrotechnics")
    if name
    then
        chanse = GetCombatRatingBonus(CR_CRIT_SPELL)
        ballCrit = (25 + chanse)*1.1 + 10*count
        intCrit = math.floor(ballCrit)
        DEFAULT_CHAT_FRAME:AddMessage("ballCrit = " .. intCrit)
        frame.text:SetText(intCrit)
    else
        frame.text:SetText("")
    end
end

FirelordFrame:SetScript("OnEvent",FirelordFrame_OnEvent)

The message in chat is always what I want it to be but the visible frame sometimes show the wrong number and I cannot figure out why.

The first image show a screen shoot of what I want and how it works most of the time.


But sometimes it looks like this.


What confuses me the most is that the number are obviously right because the chat message always show the number it should. Only the graphic on the screen gets it wrong.

[Fizzlemizz]

You've got some unnecessary globals.

local FirelordFrame = CreateFrame("Frame", "FirelordFrame", UIParent)
FirelordFrame:SetWidth(128)
FirelordFrame:SetHeight(128)
FirelordFrame:SetPoint("CENTER",-32,0)
FirelordFrame.text = FirelordFrame:CreateFontString(nil, "OVERLAY") --Create a FontString to display text
FirelordFrame.text:SetFont("Fonts\\FRIZQT__.TTF", 32, "THICKOUTLINE " )
FirelordFrame.text:SetTextColor(1, .75, 0)
FirelordFrame.text:SetAllPoints()
FirelordFrame:RegisterEvent("UNIT_AURA")
 
local function FirelordFrame_OnEvent(self, event, ...)
    local name, rank, icon, count = UnitBuff("player","Enhanced Pyrotechnics")
    if not name then
        self.text:SetText("")
        return
    end
    local chanse = GetCombatRatingBonus(CR_CRIT_SPELL)
    local ballCrit = (25 + chanse)*1.1 + 10*count
    local intCrit = math.floor(ballCrit)
    DEFAULT_CHAT_FRAME:AddMessage("ballCrit = " .. intCrit)
    self.text:SetText(intCrit)
end
 
FirelordFrame:SetScript("OnEvent", FirelordFrame_OnEvent)

[Lombra]

That makes no sense, but maybe try this:

frame.text:SetText(tostring(intCrit))

[Wolfenstein]

Originally Posted by Fizzlemizz You've got some unnecessary globals. local FirelordFrame = CreateFrame("Frame", "FirelordFrame", UIParent) FirelordFrame:SetWidth(128) FirelordFrame:SetHeight(128) FirelordFrame:SetPoint("CENTER",-32,0) FirelordFrame.text = FirelordFrame:CreateFontString(nil, "OVERLAY") --Create a FontString to display text FirelordFrame.text:SetFont("Fonts\\FRIZQT__.TTF", 32, "THICKOUTLINE " ) FirelordFrame.text:SetTextColor(1, .75, 0) FirelordFrame.text:SetAllPoints() FirelordFrame:RegisterEvent("UNIT_AURA")   local function FirelordFrame_OnEvent(self, event, ...)     local name, rank, icon, count = UnitBuff("player","Enhanced Pyrotechnics")     if not name then         self.text:SetText("")         return     end     local chanse = GetCombatRatingBonus(CR_CRIT_SPELL)     local ballCrit = (25 + chanse)*1.1 + 10*count     local intCrit = math.floor(ballCrit)     DEFAULT_CHAT_FRAME:AddMessage("ballCrit = " .. intCrit)     self.text:SetText(intCrit) end   FirelordFrame:SetScript("OnEvent", FirelordFrame_OnEvent)

That fixed the problem but I am still confused as to why the error happened. It worked most of the time. It only got it an occasional flicker.

[Fizzlemizz]

Possibly a second use of your original global FirelordFrame.frame.text by another addon. Just a guess but it was the first thing I thought possible when I read the code.

EDIT: Also possible:
Your global intCrit variable was "occasionaly" being updated by another addon between:

DEFAULT_CHAT_FRAME:AddMessage("ballCrit = " .. intCrit)

and

frame.text:SetText(intCrit)

Just because two lines of code appear one after another in your addon doesn't mean your computer doesn't execute other code (say from another addon) between them (or even different parts of each lines execution). It's also good reason to make sure ALL global variable names you use are unique to your addon.

[Phanx]

Originally Posted by Fizzlemizz It's also good reason to make sure ALL global variable names you use are unique to your addon.

And an even better reason to make sure you don't set any global variables unless it's actually necessary.