Fixing nameplate addon for Legion

[Joker119]

I know Legion brought ALOT of changes to how nameplates work, but I've been out of the coding area since basically WoD first released, and am rather rusty at it.

With this addon, i get the following errors:
rNamePlates.lua:116: attempt to index field 'nameFrame' (a nil value)
rNamePlates.lua:314: attempt to call method 'GetVertexColor' (a nil value)
rNamePlates.lua:338: attempt to index field 'healthBar' (a nil value)


https://github.com/galaxy119/rNamePl...NamePlates.lua

[Phanx]

You no longer need to scan anonymous children/regions and make assumptions; everything is available through named keys now, eg:

<nameplate>.UnitFrame.healthBar
<nameplate>.UnitFrame.castBar

See Blizzard_NamePlates.xml to find the rest of the elements.

You also don't need to scan WorldFrame children anymore; events are fired when a nameplate is created, or its unit changes. See Blizzard_NamePlates.lua for details.

[Joker119]

So what would be the best way to go about updating it?
There's no features of the old one i need (now that auras are included on default nameplates) but I very much want to keep my diablo3 style skin for the nameplates.

Would it be easier to just rewrite the addon to reskin the default frames?

[Seerah]

It's quite possible that zork is working on it. /shrug

[Joker119]

Originally Posted by Seerah It's quite possible that zork is working on it. /shrug

I can already confirm he is NOT.
He has no intentions of updating Roth UI for Legion, hence why he let me take over Roth UI and oUF_Diablo.

This includes rNamePlates

[Resike]

Originally Posted by Galaxy119 I can already confirm he is NOT. He has no intentions of updating Roth UI for Legion, hence why he let me take over Roth UI and oUF_Diablo. This includes rNamePlates

Oh noes, but why?

[Joker119]

Originally Posted by Resike Oh noes, but why?

He simply has no desire to continue Roth UI.
He's working on another more simplistic one, and only keeping up new versions of the addons needed for that, rNamePlates aswell as a number of others are officially abandoned by him and he let me pick them up as my own to maintain them.

[Seerah]

If zork messages Cairenn or Dolby, those addons and their pages can be transferred to you then.

[Phanx]

Originally Posted by Galaxy119 So what would be the best way to go about updating it? There's no features of the old one i need (now that auras are included on default nameplates) but I very much want to keep my diablo3 style skin for the nameplates. Would it be easier to just rewrite the addon to reskin the default frames?

You probably just need to change how you find the nameplates (replace that OnUpdate script scanning all the WorldFrame's children with an OnEvent script listening for the new events to detect when a nameplate is created) and how you refer to the elements (instead of "frame.healthBar = frame:GetChildren()" and then referring to "frame.healthBar", just refer to "frame.UnitFrame.healthBar").

Everything else you're doing as a style mod (changing textures/fonts, and moving stuff around) shouldn't really need many/any changes.

[Joker119]

Originally Posted by Phanx You probably just need to change how you find the nameplates (replace that OnUpdate script scanning all the WorldFrame's children with an OnEvent script listening for the new events to detect when a nameplate is created) and how you refer to the elements (instead of "frame.healthBar = frame:GetChildren()" and then referring to "frame.healthBar", just refer to "frame.UnitFrame.healthBar"). Everything else you're doing as a style mod (changing textures/fonts, and moving stuff around) shouldn't really need many/any changes.

I actually found it significantly easier to re-write the entire thing than try and sift through zork's code and fix it.

Thanks very much for the help, I had no idea about the nameplate changes, so thanks.


I'll be able to re-include rNamePlates with me next update to Roth UI