Target NPC

[Nimhfree]

I want to be able to step through my code and put breakpoints, etc. :-)

[Seerah]

Or... http://www.wowinterface.com/download...66-WowLua.html

[urbley]

Ok so I have a crude little frame with all my buttons on it and I have created a set of hidden buttons on the UI with my macrotext targetting code for each permutation of Nazgrim's adds. I can just type /click myButton and it's all good but I've set the frame buttons to use those buttons and nothing seems to happen :/ Any ideas? I'll give an example.

local targetSAButton = CreateFrame("Button", "targetSA", UIParent, "SecureActionButtonTemplate")
    targetSAButton:Hide()
    targetSAButton:SetAttribute("type", "macro")
    targetSAButton:SetAttribute("macrotext", [[
/cleartarget
/tar [@Kor'kron Assassin, nodead] Kor'kron Assassin
/script SetRaidTarget('target', 7)
/cleartarget
/tar [@Kor'kron Warshaman, nodead] Kor'kron Warshaman
/script SetRaidTarget('target', 8)
/rw Warshaman + Assassin]])
 
local saButton = CreateFrame("button", "NazAddsFrameSAButton", NazAddsFrame, "UIPanelButtonTemplate")
    saButton:SetHeight(20)
    saButton:SetWidth(40)
    saButton:SetPoint("TOPLEFT", NazAddsFrame, "TOPLEFT", 12, -12)
    saButton:SetText("S+A")
    saButton:SetAttribute("type", "macro")
    saButton:SetAttribute("macrotext", "/click targetSA")

I hope you're all having a more exciting Saturday night that I am

[Phanx]

You're still using slightly wrong macro commands. This is not valid:

/tar [@Kor'kron Assassin, nodead] Kor'kron Assassin

You cannot use a mob name with the @targetUnit conditional. I assume your goal is to avoid setting the icon on a dead unit, in which case you should go back and re-read the last code I posted in this thread, and copy it.

Not only will it only set icons on live targets, but it also uses /targetexact instead of /tar (which is short for just plain old /target) so if no target by the specified name is available, it won't target the next closest match (which in this case might be a Kor'kron War Shaman instead of a Kor'kron Assassin). Since you're using macrotext attributes, and not traditional buttons, you are not limited to 255 characters and do not need to use less-than-optimal commands just because they're shorter.

[Vrul]

As Phanx pointed out again, you can't target like you are trying. You are also creating a button that does nothing but /click another button? I think this does what you want (or close):

local marker, message = 8

SLASH_GeneralNazgrimMarker1 = "/gnm"
SlashCmdList.GeneralNazgrimMarker = function(command)
	if command == "reset" then
		SetRaidTarget("player", 8)
		SetRaidTarget("player", 7)
		SetRaidTarget("player", 0)
		marker, message = 8, nil
	end
	if UnitExists("target") and not UnitIsDead("target") then
		SetRaidTarget("target", marker)
		marker = marker - 1
		local name = UnitName("target"):match("%a+$")
		if message then
			message = message .. " + " .. name
		else
			message = name
		end
	end
	if command == "warn" then
		if message and IsInGroup() then
			SendChatMessage(message, "RAID_WARNING")
		end
	end
end

local button = CreateFrame("Button", "GeneralNazgrimMarker", UIParent, "SecureActionButtonTemplate,UIPanelButtonTemplate")
button:SetSize(40, 20)
button:SetPoint("CENTER")
button:SetText("GNM")
button:SetAttribute("type", "macro")
button:SetAttribute("macrotext", [[
/cleartarget
/targetexact Kor'kron Warshaman
/gnm reset
/cleartarget
/targetexact Kor'kron Arcweaver
/gnm
/cleartarget
/targetexact Kor'kron Assassin
/gnm
/cleartarget
/targetexact Kor'kron Ironblade
/gnm warn
/cleartarget
/targetexact Kor'kron Warshaman
/targetexact [dead][noexists] Kor'kron Arcweaver
/targetexact [dead][noexists] Kor'kron Assassin
/targetexact [dead][noexists] Kor'kron Ironblade
/targetexact [dead][noexists] General Nazgrim
]])

If you remove the raid warning spam it would allow you to spam the button when expecting the adds and when the first is about to die (to auto target):

local marker = 8

SLASH_GeneralNazgrimMarker1 = "/gnm"
SlashCmdList.GeneralNazgrimMarker = function(command)
	if command == "reset" then
		SetRaidTarget("player", 8)
		SetRaidTarget("player", 7)
		SetRaidTarget("player", 0)
		marker = 8
	end
	if UnitExists("target") and not UnitIsDead("target") then
		SetRaidTarget("target", marker)
		marker = marker - 1
	end
end

local button = CreateFrame("Button", "GeneralNazgrimMarker", UIParent, "SecureActionButtonTemplate,UIPanelButtonTemplate")
button:SetSize(40, 20)
button:SetPoint("CENTER")
button:SetText("GNM")
button:SetAttribute("type", "macro")
button:SetAttribute("macrotext", [[
/cleartarget
/targetexact Kor'kron Warshaman
/gnm reset
/cleartarget
/targetexact Kor'kron Arcweaver
/gnm
/cleartarget
/targetexact Kor'kron Assassin
/gnm
/cleartarget
/targetexact Kor'kron Ironblade
/gnm
/cleartarget
/targetexact Kor'kron Warshaman
/targetexact [dead][noexists] Kor'kron Arcweaver
/targetexact [dead][noexists] Kor'kron Assassin
/targetexact [dead][noexists] Kor'kron Ironblade
/targetexact [dead][noexists] General Nazgrim
]])

And honestly all you really need is something spammable for targeting/marking the most important add:

local button = CreateFrame("Button", "GeneralNazgrimMarker", UIParent, "SecureActionButtonTemplate,UIPanelButtonTemplate")
button:SetSize(40, 20)
button:SetPoint("CENTER")
button:SetText("GNM")
button:SetAttribute("type", "macro")
button:SetAttribute("macrotext", [[
/targetmarker [@player] 8
/targetmarker [@player] 0
/cleartarget
/targetexact Kor'kron Warshaman
/targetexact [dead][noexists] Kor'kron Arcweaver
/targetexact [dead][noexists] Kor'kron Assassin
/targetexact [dead][noexists] Kor'kron Ironblade
/targetmarker [exists,nodead] 8
/targetexact [dead][noexists] General Nazgrim
]])