Is this correct LUA?

[unlimit]

So, I tried to play with some LUA and VFL things again.

function dscd()
	local divinestormcd, duration, enabled = GetSpellCooldown("Divine Storm");
	if ( divinestormcd > 0 and duration > 1.5) then
		VFL.AdaptiveSchedule(dstas, 0.1, dst);
	end
end;
VFL.AdaptiveSchedule(nil, 0.1, dscd);

function dst()
	local divinestormcd, duration, enabled = GetSpellCooldown("Divine Storm");
	if ( divinestormcd > 0 and duration > 1.5) then
		nil
	else
		print("Divine Storm Ready!") and VFL.AdaptiveUnschedule(dstas);
	end
end;

I want RDX to track my Divine Storm cooldown for me, and this is what I got. (stole most of the script from other sources, and tried to scrap it all together X_X)

[unlimit]

Tried this, I THINK it's more efficient, or no?

function dst()
	local divinestormcd, duration, enabled = GetSpellCooldown("Divine Storm");
	if not ( divinestormcd > 0 and duration > 1.5) then
		print("Divine Storm Ready!") and VFL.AdaptiveUnschedule(dstas);
	end
end;

function dscd()
	local divinestormcd, duration, enabled = GetSpellCooldown("Divine Storm");
	if ( divinestormcd > 0 and duration > 1.5) then
		VFL.AdaptiveSchedule(dstas, 0.1, dst);
	end
end;
VFL.AdaptiveSchedule(nil, 0.1, dscd);

[Brainn]

	if not ( divinestormcd > 0 and duration > 1.5) then
		print("Divine Storm Ready!") and VFL.AdaptiveUnschedule(dstas);
	end

this is not valid lua code.

use this instead:

	if not ( divinestormcd > 0 and duration > 1.5) then
		print("Divine Storm Ready!");
                VFL.AdaptiveUnschedule(dstas);
	end

i dont think the changes you made in the second post provide any significant performance improvemts, but checking for the cd every 0.1 seconds is a very inefficient way to handle this. there should be some events you can use.
create an anonymous frame and register an event to that frame, then use the OnEvent handler to call your cd-checking function.
check the event-section on wowwiki for a event that suites your needs.

[Dgrimes]

With RDX you actually don't need to create any frames to bind custom events.

You would want to use the function

WoWEvents:Bind("EVENT_NAME", nil, function to call on event);

I tried finding out what the

 nil

was for but I was unable to determine the functionality of that variable spot.

If you are hooking this into in autoexec you would want to add after the function you are calling to check the argument that was passed through the event and the rest of the code.

[Brainn]

dgrimes is right, you can use WoWEvents:Bind() instead of an anonymous frame to handle your events, im just too used to using frames from the time before RDX supported scripting in the way it does now

for the "nil" part, i dont know if it would work with that in there, but for understanding what it should do in there ill abstract the code a bit:

if somestuff then 
   do nothing ==> this is the "nil" part
else
   do stuff
end

thats why he used

if not somestuff then
   do stuff
end

in the second version.

[unlimit]

Actually Brainn, I believe he means nil in:

WoWEvents:Bind("EVENT_NAME", nil, function to call on event);

I think Dg knows what Nil means otherwise :P

[Dgrimes]

Ok here is the code you can use:

local function dscd()
   local start, duration, enabled = GetSpellCooldown(53385);

    if (duration > 1.5) and ( start > 0) then
    local timeleft = (start + duration) - GetTime();
    
    VFL.ZMSchedule(timeleft, function() VFL.print("Divine Storm Ready!"); end);
    end
end


WoWEvents:Bind("SPELL_UPDATE_COOLDOWN", nil, dscd);

That should work for you.

[unlimit]

Originally Posted by Dgrimes Ok here is the code you can use: local function dscd() local start, duration, enabled = GetSpellCooldown(53385); if (duration > 1.5) and ( start > 0) then local timeleft = (start + duration) - GetTime(); VFL.ZMSchedule(timeleft, function() VFL.print("Divine Storm Ready!"); end); end end WoWEvents:Bind("SPELL_UPDATE_COOLDOWN", nil, dscd); That should work for you.

Ah, this would work perfectly if not for a little trick.

There's a method to my madness in using an adaptiveschedule, in that regular timers don't work with my 2P T10 retribution, which has a 40% on hit to cause Divine Storm to reset cooldown.

I have no set time that I know when Divine Storm will come back up, so I figured the most efficient way to do this was for it to update as often as possible?

The combat log reports this, "Divine Storm!" when the 2 piece T10 goes off, according to wowhead. http://www.wowhead.com/spell=70769

So maybe it can be done more efficiently with other binds, but I'm not sure.

I wish there was an easy way to do it. x3

[sigg]

Hello

To bind a single function to an event :
WoWEvents:Bind("EVENT_NAME", nil, function() end, "id");

To unbind the function :
WoWEvents:Unbind("id");

To bind a frame (or a table) to an event :
local Obj = createFrame();
Obj.func = function() ... end;
WoWEvents:Bind("EVENT_NAME", Obj, Obj.func, "id");

To unbind a frame (or a table) :
WoWEvents:Unbind("id");

The power of RDX :
RDXEvents (for the Unit Engine) (See UDB file for the list of events)
OmniEvents (for the combat logs)
DesktopEvents (for the desktop change and all)
BossmodsEvents (for the bossmods)
etc ...

Cheers
Sigg