Combat weapons check

[llubtoille]

Hiya

I've a good habit of taking off my weapons in a wipe, but a bad habit of not re-equipping them (on my priest).

So given my total lack of a experience with wow addons or programming of any form, I thought I'd try and make an addon to alert me.

Basically when I enter combat, I want it to check my wand slot, and if it's empty I want it to play a soundfile,
I've borrowed quite a bit from tentonhammer.com, however I've pretty much hit a dead end.

This is what I've got so far, are there any glaring errors anyone can spot?

Weapons.xml
<Script file="Weapons.lua"/>
<Frame name="WeaponCore">
<Scripts>
<OnLoad>WeaponLoad();</OnLoad>
<OnEvent>WeaponEvent();</OnEvent>
</Scripts>
</Frame>

Weapons.lua
function WeaponLoad()
this:RegisterEvent("PLAYER_REGEN_DISABLED");
end

function WeaponEvent()
if("HasWandEquipped")=nil then
PlaySound("Interface\\AddOns\\Weapons\\Weapons.mp3")
end

Thanks =D

[Mischback]

a) You don't need to mess with the xml... Your addon will be so small, it will create a slight overhead, that you don't really need.

b) Your code is almost correct, though:

-- create a frame
local frame = CreateFrame('Frame')
frame:RegisterEvent('PLAYER_REGEN_DISABLED')
frame:SetScript('OnEvent', function(self, event)
    -- check for correct event (you don't really need this)
    if ( event ~= 'PLAYER_REGEN_DISABLED' ) then return end
 
    if ( HasWandEquipped() ) then 
        -- do stuff here (play sound)
    end
end)

This should do the trick.

However, personally I would suggest to use IsEquippedItemType() with a slightly more complex condition to check for a combination of Main-hand and Range-slot (this would cover classes without wands).

[llubtoille]

Yay!
That works great,
I was originally looking for MainhandHasWeapon or something similar,
there's an OffhandHasWeapon is seems, but not mainhand for some reason...

I figure wand will do for now, as it's only really on my casters I wont notice if my weapon's equipped or not,
Whereas for melee and I'd imagine hunters, it's fairly obvious when half your screens greyed out XD