Quantcast
Lags on quest objective update - Page 2 - WoWInterface
 
Thread Tools Display Modes
02-19-14, 06:10 AM   #21
sidrat12
A Defias Bandit
Join Date: Feb 2014
Posts: 2
Carbonite.Quests\NxQuest.lua:4375: bad argument #1 to 'ipairs'

Has any one sorted out the problem with the ipairs for NxQuest.lua line 4375.

function Nx.Quest:FindCur (qId, qIndex)

if type (qId) == "string" then -- Quest title?

for n, v in ipairs (self.CurQ) do
if v.Title == qId then
return n, v, qId
end
end

return
end

if qIndex and qId == 0 then
local i, cur = self:FindCurByIndex (qIndex)
return i, cur, cur.Title -- Also return string type id
end

assert (qId > 0)

for n, v in ipairs (self.CurQ) do -- line 4375
if v.QId == qId then
return n, v, qId
end
end
end

bugsack errer reported for Carbonite.Quests\NxQuest.lua

7x Carbonite.Quests\NxQuest.lua:4375: bad argument #1 to 'ipairs' (table expected, got nil)
[C]: in function `ipairs'
Carbonite.Quests\NxQuest.lua:4375: in function `FindCur'
Carbonite.Quests\NxQuest.lua:8266: in function `RemoveWatch'
DugisGuideViewerZ\Guides.lua:1376: in function `WatchQuest'
DugisGuideViewerZ\DugisGuideViewer.lua:2067: in function `SettingFrameChkOnClick'
DugisGuideViewerZ\DugisGuideViewer.lua:666: in function `OnLoad'
DugisGuideViewerZ\DugisGuideViewer.lua:2450: in function `?'
DugisGuideViewerZ\DugisGuideViewer.lua:100: in function <DugisGuideViewerZ\DugisGuideViewer.lua:89>
[C]: ?

Locals:
self = <table> {
RecordQuests = <function> defined @Carbonite.Quests\NxQuest.lua:3047
UnpackCategory = <function> defined @Carbonite.Quests\NxQuest.lua:9641
IsTargeted = <function> defined @Carbonite.Quests\NxQuest.lua:9417
Menu_OnTrack = <function> defined @Carbonite.Quests\NxQuest.lua:2822
GetLogIdLevel = <function> defined @Carbonite.Quests\NxQuest.lua:3838
Menu_OnShowQuest = <function> defined @Carbonite.Quests\NxQuest.lua:2835
GetQuestReward = <function> defined @Carbonite.Quests\NxQuest.lua:2872
DecodeComRcv = <function> defined @Carbonite.Quests\NxQuest.lua:10343
MsgNotInDB = <function> defined @Carbonite.Quests\NxQuest.lua:4798
OnChat_msg_raid_boss_whisper = <function> defined @Carbonite.Quests\NxQuest.lua:4842
Watch = <table> {
}
FinishQuest = <function> defined @Carbonite.Quests\NxQuest.lua:2881
CalcDistances = <function> defined @Carbonite.Quests\NxQuest.lua:9860
SortQuests = <function> defined @Carbonite.Quests\NxQuest.lua:3885
SetCols = <function> defined @Carbonite.Quests\NxQuest.lua:2752
TooltipHook = <function> defined @Carbonite.Quests\NxQuest.lua:4875
CheckQuestSE = <function> defined @Carbonite.Quests\NxQuest.lua:2762
CurQSetPreviousDone = <function> defined @Carbonite.Quests\NxQuest.lua:3706
OnChat_msg_combat_faction_change = <function> defined @Carbonite.Quests\NxQuest.lua:4056
CaptureGetCount = <function> defined @Carbonite.Quests\NxQuest.lua:4221
TooltipProcess2 = <function> defined @Carbonite.Quests\NxQuest.lua:4906
UpdateQuestDetailsTimer = <function> defined @Carbonite.Quests\NxQuest.lua:7552
BuildQSendData = <function> defined @Carbonite.Quests\NxQuest.lua:4732
GetClosestObjectivePos = <function> defined @Carbonite.Quests\NxQuest.lua:9992
OnChat_msg_addon = <function> defined @Carbonite.Quests\NxQuest.lua:1936
CalcWatchColors = <function> defined @Carbonite.Quests\NxQuest.lua:2788
ExtractTitle = <function> defined @Carbonite.Quests\NxQuest.lua:3862
CalcCNumMax = <function> defined @Carbonite.Quests\NxQuest.lua:3689
ScanBlizzQuestDataZone = <function> defined @Carbonite.Quests\NxQuest.lua:3617
BuildComSend = <function> defined @Carbonite.Quests\NxQuest.lua:10283
FindCur = <function> defined @Carbonite.Quests\NxQuest.lua:4355
WatchAll = <function> defined @Carbonite.Quests\NxQuest.lua:4482
SelectBlizz = <function> defined @Carbonite.Quests\NxQuest.lua:2924
IconOnEnter = <function> defined @Carbonite.Quests\NxQuest.lua:7479
ShowUIPanel = <function> defined @Carbonite.Quests\NxQuest.lua:5406
UnpackLocPtOff = <function> defined @Carbonite.Quests\NxQuest.lua:10695
QuestQueryTimer = <function> defined @Carbonite.Quests\NxQuest.lua:3793
GetObjectiveType = <function> defined @Carbonite.Quests\NxQuest.lua:9689
PartyUpdateTimer = <function> defined @Carbonite.Quests\NxQuest.lua:10572
UnpackLocRect = <function> defined @Carbonite.Quests\NxQuest.lua:10685
UnpackObjectiveNew = <function> defined @Carbonite.Quests\NxQuest.lua:10674
PartySendTimer = <function> defined @Carbonite.Quests\NxQuest.lua:10652
MapChanged = <function> defined @Carbonite.Quests\NxQuest.lua:3590
PartyBuildSendData = <function> defined @Carbonite.Quests\NxQuest.lua:10590
PartyStartSend = <function> defined @Carbonite.Quests\NxQuest.lua:10579
OnPartyMsg = <function> defined @Carbonite.Quests\NxQuest.lua:10504
OnParty_members_changed = <func


example of API ipairs from http://www.wowwiki.com/API_ipairs

Note that ipairs() starts at index 1 and stops counting as soon as it reaches a nil value. Example:

> t = { [0] = "zero", --will not be counted
[1] = "one", --will be counted; 1
[2] = "two", --will be counted; 2
[3] = "three", --will be counted; 3
["four"] = "four", --will not be counted; returns 3
[5] = "five" } --will never be reached
> for i,v in ipairs(t) do print(i..":"..v) end
1: one
2: two
3: three

Note that t[0] is never reached because it starts counting at [1], t["four"] is never reached because it is not an array index, and t[5] is never reached because the iterator ceases when it checks t[4] and finds a nil value.
 
02-19-14, 07:28 PM   #22
Sparkplug
A Cyclonian
 
Sparkplug's Avatar
Join Date: Aug 2012
Posts: 40
Originally Posted by sidrat12 View Post
Has any one sorted out the problem with the ipairs for NxQuest.lua line 4375.

bugsack errer reported for Carbonite.Quests\NxQuest.lua

7x Carbonite.Quests\NxQuest.lua:4375: bad argument #1 to 'ipairs' (table expected, got nil)
[C]: in function `ipairs'
Carbonite.Quests\NxQuest.lua:4375: in function `FindCur'
Carbonite.Quests\NxQuest.lua:8266: in function `RemoveWatch'
DugisGuideViewerZ\Guides.lua:1376: in function `WatchQuest'
DugisGuideViewerZ\DugisGuideViewer.lua:2067: in function `SettingFrameChkOnClick'
DugisGuideViewerZ\DugisGuideViewer.lua:666: in function `OnLoad'
DugisGuideViewerZ\DugisGuideViewer.lua:2450: in function `?'
DugisGuideViewerZ\DugisGuideViewer.lua:100: in function <DugisGuideViewerZ\DugisGuideViewer.lua:89>
[C]: ?
I haven't been getting this error. I see DugisGuideViewerZ in that error message too though. Have you tried disabling that and seeing if you still get that error? It could be interference between the two addons. Also what version of Carbonite are you using? (This should also probably go in a separate thread since it doesn't pertain to the original topic...)

Last edited by Sparkplug : 02-19-14 at 07:31 PM. Reason: snipped out more of the quote
 
02-20-14, 01:29 AM   #23
sidrat12
A Defias Bandit
Join Date: Feb 2014
Posts: 2
Carbonite 5.4.0 alpha 2

Im using Carbonite 5.4.0 alpha 2, and DugiGuidesViewer 6.722 , the newest one out .

with DugiGuidesViewer turned off i don't get the error about ipairs, is the any way to make them compatible so boath can be on at the same time as i use DugiGuidesViewer a lot, any sugestion about modifying one or the other would be some help.

thanks for your time.
 
02-20-14, 09:08 AM   #24
Nimhfree
A Frostmaul Preserver
AddOn Author - Click to view addons
Join Date: Aug 2006
Posts: 264
I do not have the Dugi's guide. I have seen issues with them in the past, though when they are informed about the problem they seem to fix things.

It appears that Dugi's guide code calls into the Carbonite code. If you look at:

DugisGuideViewerZ\Guides.lua:1376: in function `WatchQuest'

you will probably see a line with:

Nx.Quest.Watch:RemoveWatch

I would guess the Dugi's guide is attempting to be compatible with Carbonite users and is attempting to do the right thing by updating Carbonite when it does its thing. However, it seems they might not have initialized the Carbonite system or perhaps kept it in sync to the extent that calling directly into this routine needs.

I would report this issue to Dugi's guide people and have them investigate.
 
02-20-14, 12:10 PM   #25
Sparkplug
A Cyclonian
 
Sparkplug's Avatar
Join Date: Aug 2012
Posts: 40
I was looking around on Dugi's forums last night and looks like they only made it compatible with the non-beta version. You might want to try convincing them to make it compatible with the beta but that would be up to them.
 
02-22-14, 10:11 AM   #26
samnilla
A Deviate Faerie Dragon
Join Date: Dec 2013
Posts: 13
I can confirm also that by removing pettracker my game has improved significantly. There is still a very slight pause, but it is very insignificant and doesn't affect game play anymore. Thank you for this tip.
 
03-05-14, 05:38 AM   #27
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
So I beleive I have found the problem... Carbonite does a quick scan of every area for quest updates.. Pettracker has things it does everytime the map is updated which combined with the rapid map switching carbonite does, creates a small lag

I do set a variable when carbonite is about to do it's scan and unset it after which addons encountering this problem can check for, and in a quick test of adding it to pettracker it seems to be fixed

Can someone else who is having the problem try adding this to pettracker.lua on line 61 it should be right under
function Addon:WORLD_MAP_UPDATE()

Code:
	if Nx and Nx.Quest and Nx.Quest.WorldUpdate then
		return
	end
 
03-05-14, 09:23 AM   #28
Wrebel
A Defias Bandit
Join Date: Feb 2013
Posts: 2
You, sir, are wonderful. Your fix works like a charm
 
03-05-14, 02:13 PM   #29
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
Glad to hear it worked for you.. if other's also report it fixed the problem i'll take it to the creator of Pettracker so they can hopefully include it as a compatability thing between our addons.
 
03-07-14, 03:55 AM   #30
Sparkplug
A Cyclonian
 
Sparkplug's Avatar
Join Date: Aug 2012
Posts: 40
Seems to work as far as I can tell. Thanks Rythal!
 
03-07-14, 01:12 PM   #31
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
Submitted it to jaliborc... lets see what comes of it.
 
03-08-14, 08:09 PM   #32
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
Update: Heard back from jaliborc, which resulted in todays new update to carbonite.

Both so he can fix the lag issue caused between our addons within pettracker (my part is done now), and also to add new functions he was asking about so he can better support Carbonite within Pettracker.
 
03-09-14, 10:48 PM   #33
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
And it's out! the latest Pettracker released today, works with 5.4.2 alpha 2 and later to stop the lag issue.

For you pettracker users, not sure when but I believe you can expect native carbonite support soon, all the changes I made in alpha 2 and 3 were specifically done for him so he can make pettracker work with carbonite natively.
 
03-10-14, 10:24 PM   #34
crazzzzi
A Flamescale Wyrmkin
 
crazzzzi's Avatar
Join Date: Mar 2010
Posts: 117
firstly, thanks for all the great work. what exactly does the swap view button do on the objective window? when i press it, it just seems to minimize the window.
 
03-10-14, 10:43 PM   #35
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
Originally Posted by crazzzzi View Post
firstly, thanks for all the great work. what exactly does the swap view button do on the objective window? when i press it, it just seems to minimize the window.
It's for alternate information displays, so addons like pettracker have an alternate place to display information which they would normally insert into the blizzard quest tracker.

It looks minimized because it's empty, nothing has put information into it yet.
 
03-11-14, 08:56 PM   #36
crazzzzi
A Flamescale Wyrmkin
 
crazzzzi's Avatar
Join Date: Mar 2010
Posts: 117
ah, i see, thx for the explanation, i thought for a minute i missed a setting, keep up the good work
 
04-06-14, 03:16 AM   #37
hotluck
A Defias Bandit
 
hotluck's Avatar
Join Date: Nov 2010
Posts: 3
This probably won't be of any help but before I installed the latest version (5.4.2 Alpha 5) when it came out I hadn't noticed any problems. Now there is a little lag but my biggest problem is that it takes up to 10 seconds for the quest list/watcher to update with the new information on the status of my quests after quests kills/updates. I don't use Pettracker.
 
04-08-14, 12:34 AM   #38
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,458
I'll take a look at it... it's possible when I was trying to narrow down what was causing the problem I left something commented out.
 
 

WoWInterface » Featured Projects » Carbonite » Carbonite Archive » Lags on quest objective update

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off