Blizz LOD interface changes

[Grimsin]

So something has changed in the way the bliz LOD addons work like the calendar and the debugtools. more specific maybe is the fact that they actually function now. two examples... one is with the calender invite notification i had made now does not work right for some odd reason. More noticeable is the button i made for /framestack, it just passed the slash command to chat but that now does not work. Anyone have any ideas or know what exactly was changed? The patch notes are vague... always are.

This is my run slash command function... make a button and put /framestack as the slash command to pass and tell me what you think?

function addon:RunSlashCmd(cmd)
	local slash, rest = cmd:match("^(%S+)%s*(.-)$")
	for name, func in pairs(SlashCmdList) do
		local i, slashCmd = 1
		repeat
			slashCmd = _G['SLASH_' .. name .. i]
			if slashCmd == slash then
				func(rest)
				return true
			end
			i = i + 1
		until not slashCmd
	end
end

[SDPhantom]

Blizz screwed around with the slash command tables so it's a little difficult to scan them. However, there are a few ways you can approach this. What I would recommend is to call SlashCmdList.FRAMESTACK() directly. No need to scan since the function is right there.

[Grimsin]

im going to try that, another option i just found works is to make a function that looks like this and run it...

function addon:FrameStack()
	LoadAddOn("Blizzard_DebugTools")
	FrameStackTooltip_Toggle(showHidden)
end

Also does not explain the calender issues but that issue may just be my half arsed code for it.

[Xrystal]

Hmm LoadOnDemand changes .. perhaps another sneak peek. It would explain why my many combo plugins for nUI now do something different if 2 or more of them are turned on. In the fact that it ignores my load/unload commands, which, seeing as the toc in the addons themselves are not showing load on demand functionality, is the way it should be working haha

[Grimsin]

in the bliz addons? LOD set to 1 means its a load on demand addon right?

Oh and on the framestack issue reason i think it has to do with the LOD working now is because if i ran that FrameStackTooltip_Toggle(showHidden) function it would fire an error but cause my /framestack button to work again. Also if i /framestack then fire that function it will not error and my framestack beings to function. Its like not all of the debugtool code is actually loaded until you call the bliz /framestack function on its own which is why i was thinking maybe the LOD is functioning right now... digging into it more with the calender issue since the framestack issue was an easy fix with your direct grab from the slash command list

[Xrystal]

My apologies .. I meant addons in general .. I noticed a non breaking effect to my addons that would be explained by this if they had made it so that LoadOnDemand works as expected now than seemingly always before from what I could see.

[Grimsin]

Originally Posted by Xrystal My apologies .. I meant addons in general .. I noticed a non breaking effect to my addons that would be explained by this if they had made it so that LoadOnDemand works as expected now than seemingly always before from what I could see.

Hmm my own LOD stuff works the same as it always has which seemed proper? Its all the bliz LOD addons that seem to be functioning now like normal addons as apposed to just always being on like they were before. Maybe none of it works and we are all just very confused

[Xrystal]

Yeah, maybe its just another of those loading order changes they sneak in that involves changing our code again rofl

[Ketho]

Originally Posted by SDPhantom Blizz screwed around with the slash command tables so it's a little difficult to scan them. [...]

Could you expand on that? did they do something involving metatables?
I'm just very very confused on how SlashCmdList works right now in 4.3 :|

[Grimsin]

I noticed that the one other place in GrimUI where i used that code to pass a / command through is working intermittently.

[SDPhantom]

Originally Posted by Ketho Could you expand on that? did they do something involving metatables? I'm just very very confused on how SlashCmdList works right now in 4.3 :|

I'll post the relevant parts so you can look at it.

The first quoted code sets up a second table as a metatable to move entries into after their hashes have been stored. This is to keep track of which entries have been processed and which are still waiting. When a new entry is added, the second quoted block of code starts the hashing process again when a slash command is run.



Main chunk of ChatFrame.lua:2419

function ChatFrame_SetupListProxyTable(list)
    if ( getmetatable(list) ) then
        return;
    end
    
    setmetatable(list, { __index = {} });
end
 
function ChatFrame_ImportListToHash(list, hash)
    for k, v in pairs(list) do
        local i = 1;
        local tag = _G["SLASH_"..k..i];
        while(tag) do
            tag = strupper(tag);
            if ( hash ) then
                hash[tag] = v;
            end
            hash_ChatTypeInfoList[tag] = k; --Also need to import it here for all types.
            i = i + 1;
            tag = _G["SLASH_"..k..i];
        end
        --Add the item we removed to the proxy table.
        local proxyTable = getmetatable(list).__index;
        proxyTable[k] = v;
    end
    
    table.wipe(list);
end
 
function ChatFrame_ImportEmoteTokensToHash()
    local i = 1;
    local j = 1;
    local cmdString = _G["EMOTE"..i.."_CMD"..j];
    while ( i <= MAXEMOTEINDEX ) do
        local token = _G["EMOTE"..i.."_TOKEN"];
        -- if the code in here changes - change the corresponding code above
        if ( token ) then
            hash_EmoteTokenList[strupper(cmdString)] = token;   -- add to hash
        end
        j = j + 1;
        cmdString = _G["EMOTE"..i.."_CMD"..j];
        if ( not cmdString ) then
            i = i + 1;
            j = 1;
            cmdString = _G["EMOTE"..i.."_CMD"..j];
        end
    end
end
 
function ChatFrame_ImportAllListsToHash()
    ChatFrame_ImportListToHash(SecureCmdList, hash_SecureCmdList);
    ChatFrame_ImportListToHash(SlashCmdList, hash_SlashCmdList);
    ChatFrame_ImportListToHash(ChatTypeInfo);
end
 
ChatFrame_SetupListProxyTable(SecureCmdList);
ChatFrame_SetupListProxyTable(SlashCmdList);
ChatFrame_SetupListProxyTable(ChatTypeInfo);
ChatFrame_ImportAllListsToHash();
ChatFrame_ImportEmoteTokensToHash();

ChatEdit_ParseText() in ChatFrame.lua:4272

if ( send == 1 and hash_SecureCmdList[command] ) then
        hash_SecureCmdList[command](strtrim(msg));
        editBox:AddHistoryLine(text);
        ChatEdit_OnEscapePressed(editBox);
        return;
    end
 
    ChatFrame_ImportAllListsToHash();
    
    -- Handle chat types. No need for a securecall here, since we should be done with anything secure.
    if ( ChatEdit_HandleChatType(editBox, msg, command, send) ) then
        return;
    end
 
    if ( send == 0 ) then
        return;
    end
 
    -- Check the hash tables for slash commands and emotes to see if we've run this before. 
    if ( hash_SlashCmdList[command] ) then
        -- if the code in here changes - change the corresponding code below
        hash_SlashCmdList[command](strtrim(msg), editBox);
        editBox:AddHistoryLine(text);
        ChatEdit_OnEscapePressed(editBox);
        return;
    elseif ( hash_EmoteTokenList[command] ) then
        -- if the code in here changes - change the corresponding code below
        DoEmote(hash_EmoteTokenList[command], msg);
        editBox:AddHistoryLine(text);
        ChatEdit_OnEscapePressed(editBox);
        return;
    end

[Grimsin]

Originally Posted by SDPhantom Blizz screwed around with the slash command tables so it's a little difficult to scan them. However, there are a few ways you can approach this. What I would recommend is to call SlashCmdList.FRAMESTACK() directly. No need to scan since the function is right there.

is there a function like that for /roll?

[Ketho]

Originally Posted by Grimsin is there a function like that for /roll?

afaik this should be it: [1] [2]

[SDPhantom]

Originally Posted by Grimsin Originally Posted by SDPhantom Blizz screwed around with the slash command tables so it's a little difficult to scan them. However, there are a few ways you can approach this. What I would recommend is to call SlashCmdList.FRAMESTACK() directly. No need to scan since the function is right there. is there a function like that for /roll?

Here's an explanation on how that call was made. All non-secure slash command functions are stored in the table SlashCmdList with a token as the key. For example, /framestack has "FRAMESTACK" as its token and can be called by SlashCmdList["FRAMESTACK"](). Note any string index that follows the same naming restrictions as a Lua variable can be indexed with dot notation, this would allow someone to make the same call with SlashCmdList.FRAMESTACK().

To find the token for a slash command, you need to open up GlobalStrings.lua and look through the SLASH_* entries. All of the slash definitions are stored in these variables in which the naming convention is SLASH_<Token><Index>. <Index> is just a sequential number that allows there to be multiple slash definitions for each token.

Originally Posted by Ketho afaik this should be it: [1] [2]

Ketho's links show the definition of such function in ChatFrame.lua. Notice the token for /roll is "RANDOMROLL" so the resulting call would be SlashCmdList["RANDOMROLL"]() or SlashCmdList.RANDOMROLL().

This specific command appears to be a wrapper for RandomRoll(min,max) so it would be best to call that directly anyway. Both arguments appear to be required, so a standard 1-100 roll would be RandomRoll(1,100).