UnitDebuff() + GetSpellInfo()

[wille480]

Hello fellas! i am new here so if the thread is posted wrong in anyway that will be why!

On to the question.

So i am progressing helya mythic and decided to make a addon, not going that well..
-----------------------------------------------------------------------------------------------------------
local total = 0
local added = 1
local TaintOfTheSea = GetSpellInfo(228054)


if UnitDebuff("player", TaintOfTheSea) then
function onUpdate(self,elapsed)

repeat
C_Timer.After(1.2, function() SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name) end)
total = total + added
until total == 2
end
end


if total == 2 then
C_Timer.After(1, function() SendChatMessage("Dispell on {moon} in 5", "Yell", nil, name) end)
C_Timer.After(2, function() SendChatMessage("Dispell on {moon} in 4", "Yell", nil, name) end)
C_Timer.After(3.2, function() SendChatMessage("Dispell on {moon} in 3", "Yell", nil, name) end)
C_Timer.After(4.2, function() SendChatMessage("Dispell on {moon} in 2", "Yell", nil, name) end)
C_Timer.After(5.2, function() SendChatMessage("Dispell on {moon} in 1", "Yell", nil, name) end)
end
-----------------------------------------------------------------------------------------------------------------------
Okay so here is my code , It does not give any error inside world of warcraft at all but when i get Taint of The sea" debuff on my characther it doesn't do the following code i want to!
What am i doing wrong? what do i have to add to tell the program that if i get "Taint of the sea" i want to do the fellowing code after the if statement!

kty<3
Best regards
wille480

[Tosaido]

Hi, i see many structure issues with your code, and am still a-little unsure on what you where trying to achieve

- Your code will only run once (on startup) if it's not part of a function.
at [ if UnitDebuff("player", TaintOfTheSea) then... ] for instance, this will only be run once.
- You have created a global function called onUpdate, which is a bad idea.


Try this code. I have yet to test it, but in theory it seems fine.

local TaintOfTheSea = GetSpellInfo(228054)
local Ticker = 5
 
local function UpdateDuration()
    if Ticker > 0 then
        SendChatMessage("Dispell on {moon} in " .. Ticker, "Yell", nil, name)
        Ticker = Ticker - 1
 
        C_Timer.After(1, UpdateDuration)
    else
        Ticker = 5
    end
end
 
local function UNIT_AURA()
    if UnitDebuff("player", TaintOfTheSea) then
        SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name)
        UpdateDuration()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

If you have any questions or concerns, just ask

[wille480]

Oh hey Thanks for answer!

Hehe ye it is abit messy i am also very new to lua , i program in c# but kinda different. I did realise myself after that function OnUpdate was terrible , It did not even run my below script even , So i tested out and removed and then the below code was working but still not the if statement for Taint of the sea!

I do highly appricate the answer and i will test it out now! , Will come back with result: )

Okay so basicly what i wanted to achieve in this code was if player gets the debuff taint of the sea , I want the
SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name)
to go out 3 times , and after the 3 times start a function with the dispell in .. countdown!
-----------------------------------------------------------------------------------------------------------------------------------

--So first
if UnitDebuff("player", TaintOfTheSea) then
SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name) -- Want this line to be yelled 3 times with 1.5 seconds delay between each SendChatMessage

-- after it have been yelled 3 times i want a countdown for dispell to go out!

local Ticker = 5
local function UpdateDuration()
if Ticker > 0 then
SendChatMessage("Dispell on {moon} in " .. Ticker, "Yell", nil, name)
Ticker = Ticker - 1
-------------------------------------------------------------------------------------------------------------------------------------------------------
I hope i clearified it well enough now! , what i think in the code you sent me is that they are in wrong order? Because first commes chat message move to moon, and then countdown for dispell , it looks like they are in the wrong order in the code you sent but i will try it out!

Thanks so far^^<3
Best regards!

[wille480]

Update!

Hello again
Okay so the code you sent to me works only that it is in wrong order and the dispell counter is a little bugged, it repeats itself from 5 down to 1 and then does that whole 3 times!

I tried to sort out the code you sent me to place the text in the right order like the way i wanted,

local TaintOfTheSea = GetSpellInfo(228054)
local total = 0
 
 local function UNIT_AURA()
    if UnitDebuff("player", TaintOfTheSea) then
        repeat
        C_Timer.After(1.5, function() SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name) end)
        total = total + 1
        until total == 3
    end 
            -- next
            if total == 3 then
            local function UpdateDuration()
            C_Timer.After(1, function() SendChatMessage("Dispell on {moon} in 5", "Yell", nil, name) end)
            C_Timer.After(2, function() SendChatMessage("Dispell on {moon} in 4", "Yell", nil, name) end)
            C_Timer.After(3.2, function() SendChatMessage("Dispell on {moon} in 3", "Yell", nil, name) end)
            C_Timer.After(4.2, function() SendChatMessage("Dispell on {moon} in 2", "Yell", nil, name) end)
            C_Timer.After(5.2, function() SendChatMessage("Dispell on {moon} in 1", "Yell", nil, name) end)
            end
        end
    end  
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

Okay so here is my new code that i scrapted together from the code you first sent me!
Only that this code i have now disconnectes me when i get the debuff and freezez a bit. The SendChatMessage still works only that it disconnectes me and i have no clue why.

But basicly here in this code this is the order i want it in! First comes - move to moon - command and after that then - dispell on moon in ..

Best regards!

[Tosaido]

With this code it will display the move message 3 times, 1.5 seconds apart. Then it will display the dispel message counting down from 5 to 0.

Do i have that order correct?

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = 8
 
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DispelMessage     = "Dispel on {moon} in "
 
local function UpdateTicker()
    if Ticker < 0 then 
        Ticker = 8
        return 
    end
 
    SendChatMessage( (Ticker > 5) and MoveMessage or DispelMessage .. Ticker , "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After( (Ticker > 5) and 1.5 or 1 , UpdateTicker)
end
 
local function UNIT_AURA()
    if UnitDebuff("player", TaintOfTheSea) then
        UpdateTicker()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

A few things wrong with this code you posted ill point out:

local TaintOfTheSea = GetSpellInfo(228054)
local total = 0
 
 local function UNIT_AURA()
    if UnitDebuff("player", TaintOfTheSea) then
 
        -- This repeat loop won't work, it will cause all 3 of the chat messages to be displayed all at once after 1.5 seconds
 
        repeat
        C_Timer.After(1.5, function() SendChatMessage("{moon} MOVE TO MOON {moon}", "Yell", nil, name) end)
        total = total + 1
        until total == 3
    end 
 
    if total == 3 then
 
        -- Not sure why this function is here. The code within it will do nothing, unless the function is called
 
        local function UpdateDuration()
            C_Timer.After(1, function() SendChatMessage("Dispell on {moon} in 5", "Yell", nil, name) end)
            C_Timer.After(2, function() SendChatMessage("Dispell on {moon} in 4", "Yell", nil, name) end)
            C_Timer.After(3.2, function() SendChatMessage("Dispell on {moon} in 3", "Yell", nil, name) end)
            C_Timer.After(4.2, function() SendChatMessage("Dispell on {moon} in 2", "Yell", nil, name) end)
            C_Timer.After(5.2, function() SendChatMessage("Dispell on {moon} in 1", "Yell", nil, name) end)
        end
    end
end  
 
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

[wille480]

Ello mon!
If it is in the order you write with the text then it will be correct!

I am unable to try it now because i am in school but i will come back with results as fast as i can!
I highly appriciate the help <3

[wille480]

UPDATE!

Hey again, okay so the code is in right order now! but the problem is it is like broken.
It just spits out yell all the time repeting itself to no end when you get taint of the sea, I have no idea how to counter this in the code.

Do you have to like set a timout function in the code to make it just do the code from start to finish once every like 10seconds if you get the debuff? because it just keeps spamming to no end.

Best regards

[pas06]

Please post your code you are referring to

[Tosaido]

Got it, i'm not familiar with this specific Debuff, does it get cast on you multiple times? I tested this code on a buff i was casting.

This update will case the chat messages to never overlap

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = -1
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DeispelMessage    = "Dispell on {moon} in "
 
local function UpdateTicker()
    if Ticker < 0 then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DeispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 1, UpdateTicker)
end
 
local function UNIT_AURA()
    if ( UnitDebuff("player", TaintOfTheSea) and Ticker < 0 ) then
        Ticker = 8
        UpdateTicker()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

Edit: It is important that you understand how this code works, just so you learn something and can start experimenting yourself.
If you have any questions about why i have done something, ask away.

[wille480]

Okay thanks for the code!

The taint of the sea debuff gets casted on you by the boss , then you can dispell it!
It can be cast on you multiple times during the encounter fight but you can only have 1 of that debuff on you at once.

So for example.

You get Taint of the sea (dispellable) , when that debuff is dispelled or expired it can be applied for example 30 seconds after by the boss when it is time for that phase.
Hope i clearified well enough, Will test out the code!

best regards

[wille480]

Hello again Tosaido!

You are the hero i needed
The new code you made works perfectly! Exactly what i wanted!

I am gonna see if i can add some if statements on my own like
if taint of the sea is disppeled - stop the chat messages!

Best regards!

[Tosaido]

BTW, the issues were having was caused because the unit event ["UNIT_AURA"] is fired every time any aura is applied/expires on the unit, and the if statement we setup would check if the unit had the TaintOfTheSea debuff and return true if it did have it, so if any other aura affected the unit and they still had TaintOfTheSea it would just restart the loop.

For instance, if the debuff was applied to you and the chat messages started and then a debuff or buff got applied or expired and you still had the debuff TaintOfTheSea, the messages would start to loop again.

What we needed was for the if statement to only return true if the TaintOfTheSea debuff was just applied rather than if we where already affected by it.

The code i just posted was just a stop gap, we need something a-little more reliable.

Try this

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = -1
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DeispelMessage    = "Dispell on {moon} in "
 
local function UpdateTicker()
    if Ticker < 0 then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DeispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 1, UpdateTicker)
end
 
local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
 
    if name and ( (expires - GetTime() == duration) and Ticker < 0 ) then
        Ticker = 8
        UpdateTicker()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

[wille480]

Oh oki ty!

I have one question about the code!

" if name and ( (expires - GetTime() == duration) and Ticker < 0 ) then "
This line in the code you recently sent i do not understand. What does this actually do? because i am trying to make a if statements that says , if taint of the sea have been dispelled , abort the chat message code , Basicly goto updateticker().

How would i be able to add that so if the debuff is dispelled it does not keep running the code it just breaks out of everything and moves up to updateticker() where it will just sit and wait of next taint of the sea debuff?

best regards!

[Seerah]

This

if name and ( (expires - GetTime() == duration) and Ticker < 0 ) then

is just a shorter way of writing

if name then
     if expires - GetTime() == duration then
          if Ticker < 0 then
               --do stuff
          end
     end
end

[Tosaido]

Hey.

Ya sorry, the way i coded that wasn't the easiest to understand for people new to lua.

try replacing the Unit_Aura function with this one (just so we don't have to have the same code pasted 20 times on this page)

local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
 
    if name then -- Debuff was found
 
        if (expires - GetTime() == duration) and Ticker < 0 then -- Debuff was just applied so start the loop
            Ticker = 8
            UpdateTicker()
        end
 
    else
        Ticker = -1 -- Debuff was not found so pause the loop
    end
end

Or you could also add a dispelled message

local DispelledMessage  = "{moon} has been Dispelled"
 
local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
 
    if name then -- Check to see if the debuff is present
        if (expires - GetTime() == duration) and Ticker < 0 then -- Check to see if the debuff was just applied
            Ticker = 8 -- Start the loop
            UpdateTicker()
        end
    else
        if Ticker >= 0 then -- Check to see if the debuff went missing while the ticker was still in progress (dispelled)
            SendChatMessage(DispelledMessage, "Yell", nil, name)
            Ticker = -1 -- pause the loop
        end
    end
end

Note: this code is very specific (dedicated to one thing), so it's not very usable outside this situation. It's not usually the way I approach things, I prefer more systematic methods. But it'll get the job done.

[wille480]

Hello again! : )

Okay so this code you posted did not work. I get taint of the sea debuff on me but nothing goes out. I think it have something to do with this line
" local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea) " , I remember you while i post this that i am still after the dispell function so that if the debuff dissapers (dispelled) it will just stop the chatmessages to go out, basicly it will break them from running!

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = -1
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DeispelMessage    = "Dispell on {moon} in "
 
local function UpdateTicker()
    if Ticker < 0 then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DeispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 1, UpdateTicker)
end
 
local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
 
    if name and ( (expires - GetTime() == duration) and Ticker < 0 ) then
        Ticker = 8
        UpdateTicker()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

best regards

[pas06]

So you wan't the addon to still write messages even tho the debuff doesen't exist anymore? I am struggling to get wat you want because of wording.

[wille480]

Hey!

Nah basicly you see how the code is working so far , if taint of the sea debuff is applied to the player itself it will run that code , first calling out " Move to moon" 3 times with 1.5seconds between each message, then it will do a countdown with the message "Dispell on moon in .." Ticker" ,

That is basicly what i wanted from the start and that code in words works with this code Tosaido helped me out with

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = -1
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DeispelMessage    = "Dispell on {moon} in "
 
local function UpdateTicker()
    if Ticker < 0 then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DeispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 1, UpdateTicker)
end
 
local function UNIT_AURA()
    if ( UnitDebuff("player", TaintOfTheSea) and Ticker < 0 ) then
        Ticker = 8
        UpdateTicker()
    end
end
 
local dummyFrame = CreateFrame("Frame")
dummyFrame:RegisterUnitEvent("UNIT_AURA", "player")
dummyFrame:SetScript("OnEvent", UNIT_AURA)

But what i want to add now as i just figured it out is that if the taint of the sea debuff is dispelled or disppered , whatever it may be , i want the code to return to UpdateTicker() function.

if taint of the sea debuff has been applied it will run the following code , but i want to add so if the debuff was dispelled , it will break out of the code and stop running the chat messages. Basicly return to funcion UpdateTicker().

[pas06]

local TaintOfTheSea     = GetSpellInfo(228054)
local Ticker            = -1
local MoveMessage       = "{moon} MOVE TO MOON {moon}"
local DispelMessage     = "Dispell on {moon} in "
local debuffexists      = false 
 
local function UpdateTicker()
    if Ticker < 0 or not debuffexists then return end
 
    SendChatMessage((Ticker > 5) and MoveMessage or DispelMessage .. Ticker, "Yell", nil, name)
    Ticker = Ticker - 1
 
    C_Timer.After((Ticker > 5) and 1.5 or 1, UpdateTicker)
end
 
local function UNIT_AURA()
    local name, _, _, _, _, duration, expires = UnitDebuff("player", TaintOfTheSea)
    
    if name then
        if not debuffexists then
            debuffexists = true --player just got the debuff
            Ticker = 8
            UpdateTicker()
        end
    else
        debuffexists = false -- doesn't exist
    end
end
 
local eventframe = CreateFrame("Frame")
eventframe:RegisterUnitEvent("UNIT_AURA", "player")
eventframe:SetScript("OnEvent", UNIT_AURA)

So this should do it if i am not wrong

[wille480]

Update!

Pas06 that worked excellent
The code breaks when it is dispelled (stops the running of the messages!)

Ty so much: )