Filter the bnet messages?

[suicidalkatt]

As many of you may be familiar with the addon 'OQ' (oQueue) it basically puts any users bnet message to 'OQ' which spams me constantly.

I'm wondering if there is a way to possibly prevent this bnet message from being displayed?

Looking over the bnet.lua, toast messages are stored in a local table and 'OnUpdate' the table is checked and the toast window is shown.

Only way I see this being done is to replace the blizzard function that adds the toast to the table.

Any thoughts??

[Phanx]

Probably:

local orig = BNToastFrame_AddToast
function BNToastFrame_AddToast(toastType, toastData)
     if toastType ~= 3 or toastData ~= "OQ" then
         return orig(toastType, toastData)
     end
end

On a side note, there's no need to attach Blizzard UI files to posts; you can just link to one of the several online mirrors of the code. Some even let you link directly to a specific line.

[suicidalkatt]

Originally Posted by Phanx Probably: local orig = BNToastFrame_AddToast function BNToastFrame_AddToast(toastType, toastData) if toastType ~= 3 or toastData ~= "OQ" then return orig(toastType, toastData) end end On a side note, there's no need to attach Blizzard UI files to posts; you can just link to one of the several online mirrors of the code. Some even let you link directly to a specific line.

More just for convenience. I'd rather be able to bring the file up in Notepad++ with a click or two.

local orig = BNToastFrame_AddToast
function BNToastFrame_AddToast(toastType, toastData)
     if toastData ~= "OQ" then
         return orig(toastType, toastData)
     end
end

Think those conditionals would make more sense. Pass any 'BN_TOAST_TYPE_BROADCAST' that's not "OQ".

I'll give it a try.

Edit: Removed the check on toastType.

Edit 2: After doing a bit of testing, toastData would never be 'OQ' as a string. It would pass the friend id to be used with 'BNGetFriendInfoByID'.

Edit 3: More testing has revealed that the exact string has changed to '(OQ) ' which does include that space.

local orig = BNToastFrame_AddToast
function BNToastFrame_AddToast(toastType, toastData)
    if toastType == 3 then
        local text = select(12,BNGetFriendInfoByID(toastData))
        if text and text ~= "(OQ) " then -- Exact string, perhaps using string.find would be more appropriate.
            orig(toastType, toastData)
        end
    else
        orig(toastType, toastData)
    end
end

[Phanx]

If you're going to spend CPU on calling select, why not just simplify the whole thing:

if toastType ~= 3 or select(12, BNGetFriendInfoByID(toastData)) ~= "OQ" then
	return orig(toastType, toastData)
end

[suicidalkatt]

Makes sense, final code:

local f = CreateFrame("frame")
f:RegisterEvent("PLAYER_ENTERING_WORLD")
f:SetScript("OnEvent", function()
    f:UnregisterEvent("PLAYER_ENTERING_WORLD")
    local orig = BNToastFrame_AddToast
    function BNToastFrame_AddToast(toastType, toastData)
        if toastType ~= 3 or select(12, BNGetFriendInfoByID(toastData)) ~= "(OQ) " then
            return orig(toastType, toastData)
        end
    end
end)

Alternatively if for some reason there is a deviation in the exact string this would fix the issue most likely:

if toastType ~= 3 or not strfind(strupper(select(12, BNGetFriendInfoByID(toastData))),"OQ") then

[suicidalkatt]

Well did some searching apparently there is something similar yet not as simplified:
http://wow.curseforge.com/addons/oqspamblocker/

Also another thread regarding this issue:
http://www.wowinterface.com/forums/s...ad.php?t=48283

[Phanx]

Originally Posted by suicidalkatt Makes sense, final code:

There's no reason to create an extra frame and wait for PEW to hook this function. There's nothing being initialized (eg. saved variables) and the overhead of creating a frame is greater than the overhead of hooking (waiting might make sense if you were creating a bunch of frames or manipulating a large dataset, to reduce the time the user spends staring at the loading screen) so you can just hook directly in the main chunk.

Stop overcomplicating things.

[10leej]

Blizzard is actually making some changes to bnet. Off of my brief skimming that would make oq use a hidden channel. Especially as the oq author is posting in it.

Blizz post

[suicidalkatt]

Originally Posted by 10leej Blizzard is actually making some changes to bnet. Off of my brief skimming that would make oq use a hidden channel. Especially as the oq author is posting in it. Blizz post

Glad that's being addressed, also that new api will add open a lot of doors for quite a lot of nice group finding mods for sure.

[pelf]

I had just been removing friends who used oQueue...