Doing a TradeSkill after SpellCast

tinix · 08-26-12, 06:19 AM

Hello everybody,

I am trying to make an addon which will automatically make craftable reagents (eg. inks) and then it will create the final product. The problem is I can not figure out how to make the addon wait until spellcast of reagents finishes. I have tried calling DoTradeSkill from UNIT_SPELLCAST_SUCCEEDED handler but it gives an error "attempt to call protected function which may require interaction" and i have also tried setting up a loop:

Lua Code:

while (not enable) do end

in which enable is to true by UNIT_SPELLCAST_SUCCEEDED handler but this locks up WoW. I would be grateful if anybody could help me with this.

Phanx · 08-26-12, 06:27 AM

If you want help with your code, SHOW YOUR CODE! We can't help you if you won't show us what you need help with.

tinix · 08-26-12, 06:35 AM

Lua Code:

local repeat_count, current, enable;
function FinishCreating(recipe_name)
    local recipe;
    recipe = GetFirstTradeSkill();
    local rec_n = GetTradeSkillInfo(recipe);
    while (rec_n ~= recipe_name) do
        recipe = recipe + 1;
        rec_n = GetTradeSkillInfo(recipe);
    end
    DoTradeSkill(recipe);
    recipe_name=nil;
end
 
function EventHandler(self, event, ...)
    if (event == "TRADE_SKILL_SHOW") then
        if(GetTradeSkillLine() ~= "Inscription" or IsTradeSkillLinked()) then
            return
        end
        btn:SetPoint("TOPLEFT",TradeSkillFrame,"TOPRIGHT",-100,-3);
        btn:Show();
    elseif (event == "TRADE_SKILL_CLOSE") then
        if(btn:IsVisible()) then
            btn:ClearAllPoints();
            btn:Hide();
        end
    elseif (event == "TRADE_SKILL_UPDATE") then
        if(IsTradeSkillLinked() and btn:IsVisible()) then
            btn:ClearAllPoints();
            btn:Hide();
        end
    elseif (event == "UNIT_SPELLCAST_SUCCEEDED") then
        local arg1 = ...;
        if(arg1 =="player") then
            if(current ~= nil) then
                if (current >= repeat_count) then 
                    enable = true;
                else
                    current = current + 1;
                end
            end
        end
    end
end 
 
function OnClick(self)
    current = 1;
    local recipe = GetTradeSkillSelectionIndex();
    local recipe_name, skill = GetTradeSkillInfo(recipe);
    if(recipe == 0 or skill== "header") then
        print("Header Selected");
        return
    end
    local cat = recipe -1;
    local category, c_tmp = GetTradeSkillInfo(cat);
    while (c_tmp ~= "header") do
        cat = cat - 1;
        category, c_tmp = GetTradeSkillInfo(cat);
    end
    local reag_count = GetTradeSkillNumReagents(recipe);
    local ink_name = nil;
    local ink_count;
    local player_ink;
    for i = 1, reag_count, 1 do
        local reagentName, reagentTexture, reagentCount, playerReagentCount = GetTradeSkillReagentInfo(recipe, i);
        if(string.find(reagentName,"Ink") == nil and playerReagentCount == 0) then
            print("Missing reagent: ".. reagentName);
            return
        elseif(string.find(reagentName,"Ink") ~= nil) then
            ink_name = reagentName;
            ink_count = reagentCount;
            player_ink = playerReagentCount;
            break
        end
    end
    if (ink_name == nil or player_ink >= ink_count) then
        DoTradeSkill(recipe);
        return
    end
    ExpandTradeSkillSubClass(0);
    local cat_list = { strsplit(",", BuildListString(GetTradeSkillSubClasses())) };
    for i, val in ipairs(cat_list) do
        if(val ~= " Parts") then
            CollapseTradeSkillSubClass(i);
        else
            break
        end
    end
    cat = GetFirstTradeSkill();
    local tr_name;
    tr_name, c_tmp = GetTradeSkillInfo(cat);
    while (tr_name ~= ink_name and c_tmp ~= "header") do
        cat = cat+1;
        tr_name, c_tmp = GetTradeSkillInfo(cat);
    end
    if(c_tmp == "header") then
        print("Ink not learned: " .. ink_name);
        return
    end
    local reagentName, w2, reagentCount, playerReagentCount = GetTradeSkillReagentInfo(cat, 1);
    if (playerReagentCount*(ink_count-player_ink) >= reagentCount*(ink_count-player_ink)) then
        repeat_count = ink_count-player_ink;
        DoTradeSkill(cat,repeat_count);
    else
        print("Insufficient reagent: " .. reagentName);
        return
    end
    CollapseTradeSkillSubClass(0);
    for i, val in ipairs(cat_list) do
        if(val == category) then
            ExpandTradeSkillSubClass(i);
            break
        end
    end
    enable = false;
    while(not enable) do end
    FinishCreating(recipe_name);
    current = nil;
end
 
btn:Hide();
btn:SetText("InkCraft");
local fStr = btn:GetFontString();
fStr:SetFont("Fonts\\FRIZQT__.TTF", 8);
btn:SetFontString(fStr);
btn:SetFrameStrata("HIGH");
btn:RegisterEvent("TRADE_SKILL_SHOW");
btn:RegisterEvent("TRADE_SKILL_CLOSE");
btn:RegisterEvent("TRADE_SKILL_UPDATE");
btn:RegisterEvent("UNIT_SPELLCAST_SUCCEEDED");
btn:SetScript("OnEvent", EventHandler);
btn:SetScript("OnClick", OnClick);
print("EasyCraft loaded!");

The problem is that I want to call FinishCreating after I finish doing Inks(after UNIT_SPELLCAST_SUCCEEDED fires for requested amount of inks). Code posted locks up client entierly and I cant think of any other solution of how to do it.

Phanx · 08-26-12, 06:54 AM

Code:

    enable = false;
    while(not enable) do end
    FinishCreating(recipe_name);
    current = nil;

This is your problem. You set enable to false, and then start a loop that will continue to run forever until enable is non-nil/false. The only way to stop such a loop would be to set enable to some other value from inside the loop. The loop won't run in the background while other things happen -- it will just block all other things from happening.

Rather than using the enable variable at all, you should probably just change this part of your event handler:

Code:

    elseif (event == "UNIT_SPELLCAST_SUCCEEDED") then
        local arg1 = ...;
        if(arg1 =="player") then
            if(current ~= nil) then
                if (current >= repeat_count) then 
                    enable = true;
                else
                    current = current + 1;
                end
            end
        end
    end

to just do what you want to do:

Code:

    elseif (event == "UNIT_SPELLCAST_SUCCEEDED") then
        local arg1 = ...;
        if(arg1 =="player") then
                if (current >= repeat_count) then
                    current = 0;
                    FinishCreating(recipe_name);
                else
                    current = current + 1;
                end
        end
    end

This will require storing the recipe_name variable in a higher scope, and resetting it to nil after you're done using it inside your FinishCreating function.

You should probably also:

(1) Set current to 0 instead of nil; this will require fewer checks.

(2) Only check or increment current if the spell that finished casting is one you care about. As written, your code will increment the counter every time the player casts ANY spell, which is not what you want.

tinix · 08-26-12, 07:10 AM

As i have said in first post, calling FinishCreating from

Lua Code:

elseif (event == "UNIT_SPELLCAST_SUCCEEDED") then
        local arg1 = ...;
        if(arg1 =="player") then
            if(current ~= nil) then
                if (current >= repeat_count) then 
                     current = nil;
                     FinishCreating(recipe_name);
                else
                    current = current + 1;
                end
            end
        end
    end

causes WoW to throw lua warning :"Warning: AddOn InkCraft attempted to call a protected function (DoTradeSkill()) which may require interaction.", the recipe_name in that version of code was declared at top of file. As for the current thingie I set it to nil when code stops running so the addon doesnt incerement when i dont want it to increment. I set it to one at start of OnClick (as you can see) and at the end I nil it
EDIT: On the second thought, I should check the spell because player can interrupt it...

p3lim · 08-26-12, 09:07 AM

The function DoTradeSkill seems to be protected, based on the error you get.
This basically means that it requires a hardware press to be used (OnClick script, keybound etc).

I have no idea what the conditions it might be happening under since I have only used this in an OnClick script myself.

SDPhantom · 08-26-12, 12:48 PM

I wrote this for personal use, but if you want to use it, feel free. It's a grid of buttons that allow you to quickly and easily mill herbs and make inks. It also hides itself for chars that don't have Inscription learned and clicking the title bar will expand and contract the button grid. The top row "Milling" buttons show how many pigments you have of each and how many times you can mill that level range of herbs from what you have along with a detailed tooltip of what herbs each pigment comes from. The two bottom rows, "Ink" buttons, show how many inks you have and how many you can create from pigments. I may eventually release it, but it still has some more work it needs done as it's not yet up to the quality I'd like in a released addon.

<< Download removed to conserve attachment space >>

**Seerah** · 08-26-12, 01:41 PM

If you want something for all professions, I like Panda.

But, yes, if you continue to create your own addon, you will need a hardware event for what you are trying to do.

tinix · 08-27-12, 01:25 AM

Thanks for your help guys, I really appreciate it. I think I will rework that thing into "smart" button that will create the inks and on second click it will create the product.