Quantcast Classic Beta 1.13.2 API changes - WoWInterface
Thread Tools Display Modes
05-18-19, 03:44 PM   #1
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
Classic Beta 1.13.2 API changes

The Classic API changes from 8.1.5* to 1.13.2 (30406) are available here. It also has widgets, events, CVars and enums.
I should probably mention Gethe's FrameXML mirror for completeness

* (The diff is from 8.1.5 instead of 8.1.0 since I only started dumping the api resources in 8.1.5 with the addon sorry)

Last edited by Ketho : 06-08-19 at 08:01 AM.
  Reply With Quote
05-18-19, 05:48 PM   #2
Tuller
A Warpwood Thunder Caller
 
Tuller's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2005
Posts: 91
Would you mind generating a luacheck file from this?
  Reply With Quote
05-19-19, 03:23 PM   #3
jaliborc
A Chromatic Dragonspawn
 
jaliborc's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2007
Posts: 195
Thanks! That's helpful.
Anyone knows of any program to get beta keys for mod devs?
  Reply With Quote
05-19-19, 05:30 PM   #4
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,328
Thanks Ketho,

It will help me identify what stuff I need to look at to get nUI and some of my addons to work in Classic.
__________________
  Reply With Quote
05-20-19, 12:31 AM   #5
SDPhantom
A Pyroguard Emberseer
 
SDPhantom's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2006
Posts: 1,821
Originally Posted by jaliborc View Post
Anyone knows of any program to get beta keys for mod devs?
Cairenn said on IRC to contact her directly. I'm guessing there's a reason she didn't make a public fanfare, maybe there are relatively limited slots?
__________________
ESOUI AddOns | WoWInterface AddOns
"All I want is a pretty girl, a decent meal, and the right to shoot lightning at fools."
-Anders (Dragon Age: Origins - Awakening)
  Reply With Quote
05-20-19, 03:27 AM   #6
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
Originally Posted by Tuller View Post
Would you mind generating a luacheck file from this?

This one has the API, Lua aliases, enums but doesn't include the framexml globals
I haven't generated a luacheck config file before, so I hope it works
  Reply With Quote
05-20-19, 09:47 AM   #7
jaliborc
A Chromatic Dragonspawn
 
jaliborc's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2007
Posts: 195
Originally Posted by SDPhantom View Post
Cairenn said on IRC to contact her directly. I'm guessing there's a reason she didn't make a public fanfare, maybe there are relatively limited slots?
I'll ask. Thanks for the tip.
  Reply With Quote
05-24-19, 12:21 PM   #8
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
Added Classic API pages

Last edited by Ketho : 05-24-19 at 12:53 PM.
  Reply With Quote
05-24-19, 12:30 PM   #9
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,124
Greatly appreciated Ketho, thank you.
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.
  Reply With Quote
05-24-19, 01:32 PM   #10
Ketho
A Molten Giant
 
Ketho's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 879
You're welcome. I didn't know how classic docs should be properly updated but I hope this works out
  Reply With Quote
05-25-19, 01:26 AM   #11
Nightness
An Aku'mai Servant
AddOn Author - Click to view addons
Join Date: Feb 2009
Posts: 30
Are secure templates passing into classic unaltered?

Are secure templates passing into classic unaltered?
  Reply With Quote
06-20-19, 11:03 AM   #12
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,328
Originally Posted by Nightness View Post
Are secure templates passing into classic unaltered?
I haven't noticed anything go wrong with nUI's Secure Templated frames so appears so.
__________________
  Reply With Quote
06-20-19, 01:38 PM   #13
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,124
What about "togglemenu" on a (non-Blizz. frames) target unit that is not the player?

I get an error about UnitIsOtherPlayersBattlePet which I'm pretty certain weren't a thing in vanilla .

Test Code:
Code:
local f = CreateFrame("Button", "FizzleTestUnitFrame", UIParent, "SecureUnitButtonTemplate")
f.unit = "target"
f:SetAttribute("unit", f.unit)
RegisterUnitWatch(f)
f:SetAttribute("toggleForVehicle", true)
f:RegisterForClicks("AnyUp")
f:SetAttribute("*type1", "target")
f:SetAttribute("*type2", "togglemenu")
f:SetAttribute("*type3", "assist")
f:SetPoint("TOP", 0, -5)
f:SetSize(100, 100)
f.Portrait = f:CreateTexture("$parentPortrait")
f.Portrait:SetAllPoints()
f:SetScript("OnEvent", function(self, event, ...)
	SetPortraitTexture(self.Portrait, self.unit)
end)
f:RegisterEvent("UNIT_PORTRAIT_UPDATE")
f:RegisterEvent("PLAYER_TARGET_CHANGED")
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.

Last edited by Fizzlemizz : 06-20-19 at 01:43 PM.
  Reply With Quote
06-20-19, 03:48 PM   #14
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,328
Oops, looks like they may have forgotten to remove that block of code.

But then again it is a beta so they probably haven't gone through all the files yet.

In SecureTemplates.lua
Code:
local InitializeSecureMenu = function(self)
	local unit = self.unit;
	if( not unit ) then return end

	local unitType = string.match(unit, "^([a-z]+)[0-9]+$") or unit;

	-- Mimic the default UI and prefer the relevant units menu when possible
	local menu;
	if( unitType == "party" ) then
		menu = "PARTY";
	elseif( unitType == "boss" ) then
		menu = "BOSS";
	elseif( unitType == "focus" ) then
        	menu = "FOCUS";
	elseif( unitType == "arenapet" or unitType == "arena" ) then
		menu = "ARENAENEMY";
	-- Then try and detect the unit type and show the most relevant menu we can find
	elseif( UnitIsUnit(unit, "player") ) then
		menu = "SELF";
	elseif( UnitIsUnit(unit, "vehicle") ) then
		menu = "VEHICLE";
	elseif( UnitIsUnit(unit, "pet") ) then
		menu = "PET";
       vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
	elseif( UnitIsOtherPlayersBattlePet(unit) ) then
		menu = "OTHERBATTLEPET";
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
	elseif( UnitIsOtherPlayersPet(unit) ) then
		menu = "OTHERPET";
	-- Last ditch checks
	elseif( UnitIsPlayer(unit) ) then
		if( UnitInRaid(unit) ) then
			menu = "RAID_PLAYER";
		elseif( UnitInParty(unit) ) then
			menu = "PARTY";
		else
			menu = "PLAYER";
		end
	elseif( UnitIsUnit(unit, "target") ) then
		menu = "TARGET";
	end

	if( menu ) then
		UnitPopup_ShowMenu(self, menu, unit);
	end
end
__________________
  Reply With Quote
06-20-19, 05:22 PM   #15
Fizzlemizz
I did that?
 
Fizzlemizz's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Dec 2011
Posts: 1,124
Thank you for confirming. It looks like it has been reported.
__________________
Fizzlemizz
Maintainer of Discord Unit Frames and Discord Art.
Author of FauxMazzle, FauxMazzleHUD and Move Pad Plus.
  Reply With Quote
07-04-19, 09:51 AM   #16
shervin
A Kobold Labourer
 
shervin's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2005
Posts: 1
luacheck file

What do you guys use the luacheck file for?
Is it possible to use the luacheck file in Visual Studio?
I use Visual Studio 2017 + BabeLua extension

Last edited by shervin : 07-06-19 at 05:42 AM.
  Reply With Quote

WoWInterface » Developer Discussions » Tutorials & Other Helpful Info. » Classic Beta 1.13.2 API changes

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off