Checking for a party or a raid

silentstone7 · 12-21-10, 07:42 AM

I'm working on my first addon, and I'm running into issues testing to see if the player is in a party or raid. Basically, I need to be able to call a function to test if a user is in a party, in a raid, or not in either.

I have a variable called partyShow, if it's set to true, the addon is only displayed in a raid and hidden in a party or alone. If it's false, it's always shown. I'm getting taint errors whenever this addon frame is hidden. Any ideas out there what might be wrong?

My current function is this:

function MBFlares_partyChecker() --hide/show in raid
if (MBFlaresDB.partyShow==true) then
if (GetNumRaidMembers() == 0) then -- NOT IN RAID
if (GetNumPartyMembers() == 0 ) then -- AND NOT IN A PARTY
MBFlares_mainFrame:Hide()
else -- IN A PARTY
MBFlares_mainFrame:Hide()
end
else -- IN A RAID
if IsRaidLeader() or IsRaidOfficer() then -- ABLE TO MARK
MBFlares_mainFrame:Show()
else --BUT NOT ABLE TO MARK
MBFlares_mainFrame:Hide()
end
end
else
MBFlares_mainFrame:Show()
end
end

Ketho · 12-21-10, 02:39 PM

Checking for a boolean true is unnecessary in most cases:

Code:

if MBFlaresDB.partyShow == true then
if MBFlaresDB.partyShow then

You should use the [ CODE ] tag or [ highlight=Lua ][ /highlight ] to retain the indenting:

Lua Code:

function MBFlares_partyChecker() -- hide/show in raid
    if MBFlaresDB.partyShow then 
        if GetNumRaidMembers() == 0 then -- NOT IN RAID
            if GetNumPartyMembers() == 0 then -- AND NOT IN A PARTY 
                MBFlares_mainFrame:Hide()
            else -- IN A PARTY  
                MBFlares_mainFrame:Hide()
            end
        else -- IN A RAID
            if IsRaidLeader() or IsRaidOfficer() then -- ABLE TO MARK
                MBFlares_mainFrame:Show()
            else -- BUT NOT ABLE TO MARK
                MBFlares_mainFrame:Hide()
            end
        end
    else
        MBFlares_mainFrame:Show()
    end
end

You could also just check against the Instance Type, since the player needs to be inside the raid/instance to mark the raid target mobs
(only "downside" is that this method doesn't show it outside the party/raid instance)

Lua Code:

function MBFlares_partyChecker() -- hide/show in raid
    if MBFlaresDB.partyShow then
        local _, instanceType = IsInInstance()
        if instanceType == "party" then -- IN A PARTY
            MBFlares_mainFrame:Show()
        elseif instanceType == "raid" and ( IsRaidLeader() or IsRaidOfficer() ) then -- IN A RAID AND ABLE TO MARK
            MBFlares_mainFrame:Show()
        else -- NOT ABLE TO MARK
            MBFlares_mainFrame:Hide()
        end
    end
end

silentstone7 · 12-21-10, 11:48 PM

Thank you! This is quite helpful! I'll make some changes and let you know how it goes.

Also, what exactly causes a "taint" error? I'm really not too sure.

Ketho · 12-22-10, 05:12 AM

I have never had experience with taint yet, but I can point you to some links:

Wowpedia: Taint
WowAce: How is taint represented?

Originally Posted by Nevcairiel

The plain and simple rule is, that everything created or modified from addon code will be tainted afterwards. Anything reading those tainted variables will also be tainted, and taint everything it modifies. (Thats the most common problem with taint spreading inside sensitive areas in the default UI.)

Originally Posted by Xinhuan

The main thing we need to know is there are 2 types of taint:

1. Execution Taint - Execution is tainted whenever it reads or executes data that is tainted.
2. Data Taint - Data is tainted when tainted execution writes data.

Afaik, you can :Hide() / :Show() your own addon's frame(s) without any problems
For the rest, I don't have any clue what in your addon could be tainting

Note: It's kinda hard to trace/debug the source of addon taint ...
Any addon could be wrongly "blamed" for tainting some protected function, unless you're running only that specific addon

Ailae · 12-22-10, 05:28 AM

There's limitations to what you can do with secure frames when in combat. You can't change a buttons' attribute (basically what it does when clicked) nor can you move or hide/show it. You can alter the alpha but the button is still there, intercepting mouse clicks.

If you're not running them already, it would probably be helpful to install !BugGrabber and BugSack to get more descriptive errors.

You can check if you're able to alter some of this stuff by testing for InCombatLockdown().

http://wowprogramming.com/docs/api/InCombatLockdown

silentstone7 · 12-22-10, 01:34 PM

Originally Posted by Ailae

There's limitations to what you can do with secure frames when in combat. You can't change a buttons' attribute (basically what it does when clicked) nor can you move or hide/show it. You can alter the alpha but the button is still there, intercepting mouse clicks.

If you're not running them already, it would probably be helpful to install !BugGrabber and BugSack to get more descriptive errors.

You can check if you're able to alter some of this stuff by testing for InCombatLockdown().

http://wowprogramming.com/docs/api/InCombatLockdown

That might be the issue then, since I have it hiding and showing when the party changes and when the players target change, both of which can happen in combat.