hp text disappear on max health

[Toran]

Hi -

I'm modifying Freeb's awesome oUF layout to my liking and would like to hide the *player only* hp text information on max hp (and have it appear when hp is lost). This is the chunk I was going for in Freeb's ftags.lua:

oUF.Tags['freeb:hp']  = function(u) 
	local min, max = UnitHealth(u), UnitHealthMax(u)

	if(unit == "player") then
		if(min < max) then
			return siValue(min).."."..math.floor(min/max*100+.5).."%"
		else
			return bar.value:SetText(" ")
		end
	else
	
        return siValue(min).."."..math.floor(min/max*100+.5).."%"		
	
        end

end

No errors, but it doesn't hide the hp info on max health. Any ideas? Thanks.

[v6o]

Take a closer look and you'll see he uses u instead of unit

[Toran]

Hmm. That didn't work. Replaced "unit" with "u" and spawned all sorts of errors.

[Rostok]

oUF.Tags['freeb:hp']  = function(u) 
    local min, max = UnitHealth(u), UnitHealthMax(u)

    if(u == "player") then
        if(min < max) then
            return siValue(min).."."..math.floor(min/max*100+.5).."%"
        else
            return " "
        end
    else
    
        return siValue(min).."."..math.floor(min/max*100+.5).."%"        
    
        end

end

like that

[Toran]

Thanks guys. Will give it a try.

[yj589794]

having checks for specific units within tags is not the best idea.

Create separate tags and assign them to the specific units in your style function.

e.g.

oUF.Tags['freeb:hp']  = function(u) 
    local min, max = UnitHealth(u), UnitHealthMax(u)

    return siValue(min).."."..math.floor(min/max*100+.5).."%"        

end
oUF.Tags['freeb:playerhp']  = function(u) 
    local min, max = UnitHealth(u), UnitHealthMax(u)

    if(min < max) then
        return siValue(min).."."..math.floor(min/max*100+.5).."%"
    else
        return " "
    end

end

and in your style function:

if self.unit == 'player' then
    self:Tag(myhealthtag, '[freeb:playerhp]')
else
    self:Tag(myhealthtag, '[freeb:hp]')
end

[p3lim]

You can remove the following, because it doesnt make any difference.

else
    return " "

oUF will just return nil if theres nothing returned, and thus hiding the text.

[Monolit]

Originally Posted by yj589794 having checks for specific units within tags is not the best idea.

ehh, may I ask why?

Originally Posted by p3lim oUF will just return nil if theres nothing returned, and thus hiding the text.

good to know, thanks

[haste]

Originally Posted by Monolit ehh, may I ask why?

Because it defeats the purpose of having general tags.

[Rostok]

Originally Posted by p3lim You can remove the following, because it doesnt make any difference. else return " " oUF will just return nil if theres nothing returned, and thus hiding the text.

Hum yes i missed that, thanks for pointing it out. But it was meant to display the error in the code above (bar.value blabla).

[Toran]

Good to go. Thank again. Amazing how much I have learned about tags just from this exercise.