Noob needing advice

[dragonclaw7000]

Ok. I have been coding away on my first addon for a while now and yesterday I ran into an iritating problem. After many hours of trail and error I have yet to find the error. Someone with a little more knowledge who would like to take a look at my code?

This is the part where the error is located:

function TrapTimer:EventHandler(actionframe, event, ...)
	if event == "PLAYER_ENTERING_WORLD" then
		TrapTimer:Initialize()
	end
	if event == "UNIT_SPELLCAST_SUCCEEDED" then
		ChatFrame1:AddMessage("YEz!")
		local arg1, arg2, arg3 = ...
		TrapTimer:UpdateCooldown(arg1, arg2, arg3)
	end
end

local frame = CreateFrame("Frame", "TrapTimerFrame", UIParent)

frame:RegisterEvent("PLAYER_ENTERING_WORLD")
frame:SetScript("OnEvent", TrapTimer:EventHandler(self, event, ...))

TrapTimer.frame = frame

[Slakah]

frame:SetScript("OnEvent", TrapTimer:EventHandler(self, event, ...))

Is wrong.

I'm guessing you intended to do:

frame:SetScript("OnEvent", function(self, ...) self:EventHandler(...) end)

but this would work exactly the same without creating another function

frame:SetScript("OnEvent", TrapTimer.EventHandler)

also you seem to be passing the same argument twice in TrapTimer:EventHandler() as actionframe and self are the same thing.

Basically

TrapTimer.EventHandler(self)
   blah
end

is the same as

TrapTimer:EventHandler()
   blah
end

[dragonclaw7000]

Thanks a lot Works like a charm. ThoughI would like some clarification how to transfer variables from one function to another. This do not give any errors but it won't work:

The idea is to transfer the values of the event arguments to the UpdateCooldown function.

function TrapTimer:UpdateCooldown(spell_caster, spell_name, spell_rank)
	if spell_caster == "player" then
		if spell_name == "Holy Light" then
			TrapTimer.bar2:SetValue(0)
		end
	end
end

function TrapTimer:EventHandler(...)
	if event == "PLAYER_ENTERING_WORLD" then
		TrapTimer:Initialize()
	end
	if event == "UNIT_SPELLCAST_SUCCEEDED" then
		ChatFrame1:AddMessage("YEz!")
		local arg1, arg2, arg3 = ...
		TrapTimer:UpdateCooldown(arg1, arg2, arg3)
	end
end

[slizen]

Remove the

local arg1, arg2, arg3 = ...

and it should work. The arg1,arg2 and arg3 will be set even without the above code.

[Slakah]

Originally Posted by dragonclaw7000 Thanks a lot Works like a charm. ThoughI would like some clarification how to transfer variables from one function to another. This do not give any errors but it won't work: The idea is to transfer the values of the event arguments to the UpdateCooldown function. function TrapTimer:UpdateCooldown(spell_caster, spell_name, spell_rank) if spell_caster == "player" then if spell_name == "Holy Light" then TrapTimer.bar2:SetValue(0) end end end function TrapTimer:EventHandler(...) if event == "PLAYER_ENTERING_WORLD" then TrapTimer:Initialize() end if event == "UNIT_SPELLCAST_SUCCEEDED" then ChatFrame1:AddMessage("YEz!") local arg1, arg2, arg3 = ... TrapTimer:UpdateCooldown(arg1, arg2, arg3) end end

in you TrapTimer:EventHandler() I would pass "event" by changing it too:

function TrapTimer:EventHandler(event, ...)

instead of doing

		local arg1, arg2, arg3 = ...
		TrapTimer:UpdateCooldown(arg1, arg2, arg3)

you could instead pass the vararg (...) to TrapTimer:UpdateCooldown().

so

TrapTimer:UpdateCooldown(...)

or you could create an upvalue of arg1, arg2 and arg3 and pass them to TrapTimer:UpdateCooldown()

TrapTimer:EventHandler(event, arg1, arg2, arg3)
   blah
   TrapTimer:UpdateCooldown(arg1, arg2, arg3)
end

as a final note the method notation automatically passes the variable "self" which is the same as the table holding the function.

[dragonclaw7000]

Thanks a lot for the quick replies. Works perfect

[p3lim]

Also keep in mind that global arguments are removed in 3.0

[dragonclaw7000]

So what difference will that bring to the code :?

[Duugu]

None ............

[p3lim]

Just that you have to use

local arg1, arg2, arg3 = ...

or include the arguments right off


also, you cannot use 'event' without having it set as an argument, same goes for self.

[dragonclaw7000]

Ok Good to know

[Slakah]

also, you cannot use 'event' without having it set as an argument, same goes for self.

unless you use the method notation.