Thread Tools Display Modes
01-18-14, 10:58 AM   #1
Minerv
A Black Drake
 
Minerv's Avatar
AddOn Compiler - Click to view compilations
Join Date: May 2009
Posts: 89
Help updating ClassUnitFrame

Hi! i've been away for a long time and started playing a week or smt ago and have forgotten some .lua coding and was just wondering if some good soul out there would like to help me get this addon working again.

(maybe even this too if you're feeling very generous :])
  Reply With Quote
01-18-14, 12:05 PM   #2
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Did you actually try the addon? I don't think Blizzard has changed anything related to the default unit frames in years, so it's very likely that such a simple addon still works. Just check "Load out of date addons" at the character screen. If you did that, and it really doesn't work, install BugSack and report back with any errors it shows.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote
01-18-14, 12:28 PM   #3
Minerv
A Black Drake
 
Minerv's Avatar
AddOn Compiler - Click to view compilations
Join Date: May 2009
Posts: 89
I tried, i got errors off of both the first time, but now only by stako's. Here's the error!


6x stakoPartyReturn-1.00\core.lua:5: attempt to call global "GetNumRaidMembers" (a nil value)
stakoPartyReturn-1.00\core.lua:5: in function "GetDisplayedAllyFrames"
FrameXML\RaidFrame.lua:133: in function "RaidOptionsFrame_UpdatePartyFrames"
<string>:"*:OnLoad":4: in function "setFunc"
<string>:"*:OnEvent":1: in function <string>:"*:OnEvent":1

Locals:
  Reply With Quote
01-18-14, 03:43 PM   #4
Choonstertwo
A Chromatic Dragonspawn
 
Choonstertwo's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2011
Posts: 194
I haven't looked through the code for any other errors, but to fix that one just replace all occurrences of GetNumRaidMembers with GetNumGroupMembers. If it uses GetNumPartyMembers as well, change it to GetNumGroupMembers too (there's a small chance that this could break it, but it's not likely).
  Reply With Quote
01-18-14, 09:52 PM   #5
Minerv
A Black Drake
 
Minerv's Avatar
AddOn Compiler - Click to view compilations
Join Date: May 2009
Posts: 89
Thank you! I'll check it out tomorrow!
  Reply With Quote
01-19-14, 03:09 AM   #6
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Originally Posted by Choonstertwo View Post
If it uses GetNumPartyMembers as well, change it to GetNumGroupMembers too (there's a small chance that this could break it, but it's not likely).
GetNumPartyMembers() usually needs to be replaced by GetNumGroupMembers() - 1 since "group members" includes the player, but "party members" does not, at least as far as the "partyN" unit tokens are concerned.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote
01-19-14, 04:14 AM   #7
Choonstertwo
A Chromatic Dragonspawn
 
Choonstertwo's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2011
Posts: 194
Originally Posted by Phanx View Post
GetNumPartyMembers() usually needs to be replaced by GetNumGroupMembers() - 1 since "group members" includes the player, but "party members" does not, at least as far as the "partyN" unit tokens are concerned.
Ah, I didn't think of that. I was thinking it may break because the AddOn was using it to get the number of people in the player's party while they're in a raid group; in which case it'd need to be replaced with GetNumSubgroupMembers() - 1 instead.
  Reply With Quote
01-20-14, 10:24 AM   #8
Minerv
A Black Drake
 
Minerv's Avatar
AddOn Compiler - Click to view compilations
Join Date: May 2009
Posts: 89
Originally Posted by Choonstertwo View Post
I haven't looked through the code for any other errors, but to fix that one just replace all occurrences of GetNumRaidMembers with GetNumGroupMembers.

Thank you, its working now without errors. Much appreciated!
  Reply With Quote

WoWInterface » AddOns, Compilations, Macros » AddOn Help/Support » Help updating ClassUnitFrame


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off