Buff Conditions

[Cladhaire]

Okay, we have the following buff conditions. What more would you guys like to see?

Buffs.conditions = {
	["All"] = function(u,c) return true end,
	["Warrior"] = function(u,c) return c == "WARRIOR" end,
	["Priest"] = function(u,c) return c == "PRIEST" end,
	["Druid"] = function(u,c) return c == "DRUID" end,
	["Paladin"] = function(u,c) return c == "PALADIN" end,
	["Shaman"] = function(u,c) return c == "SHAMAN" end,
	["Hunter"] = function(u,c) return c == "HUNTER" end,
	["Rogue"] = function(u,c) return c == "ROGUE" end,
	["Warlock"] = function(u,c) return c == "WARLOCK" end,
	["Mage"] = function(u,c) return c == "MAGE" end,
	["Mana"] = function(u,c) return c == "DRUID" or c == "PRIEST" or c == "PALADIN" or c == "SHAMAN" or c == "MAGE" or c == "WARLOCK" or c == "HUNTER" end,
	["Caster"] = function(u,c) return c == "MAGE" or c == "WARLOCK" or c == "SHAMAN" or c == "DRUID" end,
	["Melee"] = function(u,c) return c == "WARRIOR" or c == "ROGUE" end,
	["Healer"] = function(u,c) return c == "PRIEST" or c == "SHAMAN" or c == "DRUID" or c == "PALADIN" end,
	["NonTank"] = function(u,c) return c ~= "WARRIOR" end,
}

Someone has already suggested "MyGroup" so they can watch for missing totem buffs on their party. Anyone else have suggestions?

[Kesshi]

["Caster"] = function(u,c) return c == "MAGE" or c == "WARLOCK" or c == "SHAMAN" or c == "DRUID" end,

Why are Priests excluded from Caster?

[Nahamnessa]

Here is a thought....Is melee all those that melee or those that can melee without mana bars? Ret Paladins and DW Shaman (in fact, I don't see why all shaman won't be in melee for the BoW regen) will most likely be in melee range most, if not all the time.

Since your "alternative" trees will be common in raid scenarios. I'd suggest either Pure Melee and All Melee or including Shaman/Paladins within the melee group...though what to do about cats? Druids too?

This might be a scenario where it's too difficult to figure out what belongs in what group. Casters is almost obvious - except that whole cat form which can't be considered a caster.

Since this seems to be a static list - I don't suppose there is a way to dynamically check these? For instances. Casters (assuming you mean DPS) would include Druids in Moonkin form, but no other form.

I dunno...those terms now seem to general and broad to function properly.

[Cladhaire]

Thats why I'm asking. I need to know what classifications are useful. The reason they are included is they are a single test instead of four tests (in the example of healers). Each class was taken with its primary goal in mind, with the exception of Paladins, who as a tauren druid, I hate.

I'm 100% open to suggestions and completely revamping this list, or removing it entirely.

[Itania]

Priest must be considered as a caster I think, or druid need to be removed of the list as they have a healing role in raid too.

[Kesshi]

Originally Posted by Cladhaire Each class was taken with its primary goal in mind

With no disrespect intended, that is a pre TBC mindset which may not work out very well post TBC. With many of the new talents introduced each class can now have a different Primary role than pre 2.0.X/TBC.

Look at the NonTanks being anything that is not a Warrior. Come a few weeks, you're going to have Warriors, Druids, and Paladins all being viable tanks.

I believe you already know all of this, Cladhaire.

In my opinion, I think the following would be ideal:

All
The 8 Individual Classes
My Group
Has Mana
Has No Mana
Other: _______


After all, if one want to include all mana users except Hunters, one could easily check all the individual class boxes save the Hunter, Rogue, and Warrior boxes.

The "Other", if possible, would be a customizable box for a singular person. Perhaps for your focus target or main tank. As a Discipline Priest, I like to know if my focus target has PI on them or not. Or perhaps I only want to know if my MT has a Weakened Soul debuff, and I don't care about anyone else with that debuff.

Regardless of what you implement here, I will continue to use PRaid with a smile on my face. (^&

[Nahamnessa]

Yeah, the traditional grouping I don't think is going to work as well as it used to with the hybrid classes coming to fruit, so to speak.

I haven't had the time to check out the code as of yet, but how efficient/possible is it to perform "form" lookups when doing the buff/debuff queries? What I mean is Druid is in Moonkin/Druid/Cat/Bear/ToL form or Priest is in Shadowform. If it's relatively easy, then Mana User group could be all those with mana, except cats/bears.

Healer group could be Priests (not in shadowform, sorry Disc priests :/), Druids in Druid/ToL form, Paladins, Shaman.

I think if the pre-set groups thing is going to work, it's best to include all possibilities and let every user remove the ones they wish to remove because not every raiding group is going to have Ret pallies, moonkins, shadow priests, etc. That could also solve the problem of ignoring form totally and just be a general all inclusive thing?