A Rage Talon Dragon Guard
Join Date: Aug 2009
Posts: 325
|
Originally Posted by Xrystal
I take it you debugged it and it highlights that it is passing true for mana in hunters for a split second somewhere during that port before realising it is not really mana ?
|
I have no idea on how to "debug" a add-on. I probably should not be doing any of this stuff beings I have no high school diploma nor a college education and no training in programming or LUA coding. I'm a forklift operator for Coca-Cola that is a gamer.
Originally Posted by Phanx
I would agree, though I recall when I was helping him write this the first time around he really didn't want to do that for some reason. I also notice that the current code will incorrectly classify feral druids as casters much of the time, as feral druids still have mana until they shift into cat form. Also, it will throw an error for characters level 10 or higher who haven't yet selected a spec (eg. players who have unlearned their spec in preparation for learning a different spec).
I'd also suggest using values for "playerRole" that more closely match the values from role-related API functions, so "TANK" instead of "Tank", "HEALER" instead of "Healer", "DAMAGER" instead of "Melee", and just add an extra "CASTER" value for casters. This way you can cut out half your if/then checks.
I would just do something like this:
Code:
local playerRole
local isCaster = {
DRUID = { true }, -- Balance
MAGE = { true, true, true }, -- all specs
PRIEST = { nil, nil, true }, -- Shadow
SHAMAN = { true }, -- Elemental
WARLOCK = { true, true, true } -- all specs
}
function nData:UpdatePlayerRole()
local spec = GetSpecialization()
if not spec then
playerRole = nil
return
end
local specRole = GetSpecializationRole(spec)
if specRole == "DAMAGER" then
local _, class = UnitClass("player")
if isCaster[class][spec] then
playerRole = "CASTER"
return
end
end
playerRole = specRole
end
|
I thank you for the above code.
I had to remove the:
with this it would not show any text.
Also I had to change the below to show all the classes or a error popped up when it went to look for "CASTER"
Lua Code:
local isCaster = { -- All Classes are needed as to not cause a error when the table is called. -- SpecID - Spec - Role DEATHKNIGHT = { nil, -- 250 - Blood - (TANK) nil, -- 251 - Frost - (MELEE_DPS) nil -- 252 - Unholy - (MELEE_DPS) }, DRUID = { true, -- 102 - Balance - (CASTER_DPS) nil, -- 103 - Feral - (MELEE_DPS) nil, -- 104 Guardian - (TANK) nil -- 105 Restoration - (HEALER) }, HUNTER = { nil, -- 253 - Beast Mastery - (RANGED_DPS) nil, -- 254 - Marksmanship - (RANGED_DPS) nil -- 255 - Survival - (RANGED_DPS) }, MAGE = { true, -- 62 - Arcane - (CASTER_DPS) true, -- 63 - Fire - (CASTER_DPS) true -- 64 - Frost - (CASTER_DPS) }, MONK = { nil, -- 268 - Brewmaster - (TANK) nil, -- 269 - Windwalker - (MELEE_DPS) nil -- 270 - Mistweaver - (HEALER) }, PALADIN = { nil, -- 65 - Holy - (HEALER) nil, -- 66 - Protection - (TANK) nil -- 70 - Retribution - (MELEE_DPS) }, PRIEST = { nil, -- 256 - Discipline - (HEALER} nil, -- 257 - Holy - (HEALER) true -- 258 - Shadow - (CASTER_DPS) }, ROGUE = { nil, -- 259 - Assassination - (MELEE_DPS) nil, -- 260 - Combat - (MELEE_DPS) nil -- 261 - Subtlety - (MELEE_DPS) }, SHAMAN = { true, -- 262 - Elemental - (CASTER_DPS) nil, -- 263 - Enhancement - (MELEE_DPS) nil -- 264 - Restoration - (HEALER) }, WARLOCK = { true, -- 265 - Affliction - (CASTER_DPS) true, -- 266 - Demonology - (CASTER_DPS) true -- 267 - Destruction - (CASTER_DPS) }, WARRIOR = { nil, -- 71 - Arms - (MELEE_DPS) nil, -- 72 - Furry - (MELEE_DPS) nil -- 73 - Protection - (TANK) }, }
I know its a little over the top but as you stated before Phanx its a file not a macro so be specific.
Here is the new Statisctics.lua file:
Lua Code:
local nData = LibStub("AceAddon-3.0"):GetAddon("nData") ------------------------------------------------------------------------ -- Statistics Plugin Functions ------------------------------------------------------------------------ nData.pluginConstructors["stat1"] = function() db = nData.db.profile local plugin = CreateFrame('Frame', nil, Datapanel) plugin:RegisterEvent("PLAYER_ENTERING_WORLD") plugin:SetFrameStrata("BACKGROUND") plugin:SetFrameLevel(3) plugin:EnableMouse(true) local Text = plugin:CreateFontString(nil, "OVERLAY") Text:SetFont(db.font, db.fontSize,'THINOUTLINE') nData:PlacePlugin(db.stat1, Text) local playerClass, englishClass = UnitClass("player"); local function ShowTooltip(self) if InCombatLockdown() then return end local anchor, panel, xoff, yoff = nData:DataTextTooltipAnchor(Text) GameTooltip:SetOwner(panel, anchor, xoff, yoff) GameTooltip:ClearLines() GameTooltip:AddLine(hexa..PLAYER_NAME.."'s"..hexb.." Statistics") GameTooltip:AddLine' ' if playerRole == nil then GameTooltip:AddLine("Choose a Specialization to see Stats") else if playerRole == "TANK" then local Total_Dodge = GetDodgeChance() local Total_Parry = GetParryChance() local Total_Block = GetBlockChance() GameTooltip:AddLine(STAT_CATEGORY_DEFENSE) GameTooltip:AddDoubleLine(DODGE_CHANCE, format("%.2f%%", Total_Dodge),1,1,1) GameTooltip:AddDoubleLine(PARRY_CHANCE, format("%.2f%%", Total_Parry),1,1,1) GameTooltip:AddDoubleLine(BLOCK_CHANCE, format("%.2f%%", Total_Block),1,1,1) elseif playerRole == "HEALER" or playerRole == "CASTER" then local SC = GetSpellCritChance("2") local Total_Spell_Haste = UnitSpellHaste("player") local base, casting = GetManaRegen() local manaRegenString = "%d / %d" GameTooltip:AddLine(STAT_CATEGORY_SPELL) GameTooltip:AddDoubleLine(STAT_CRITICAL_STRIKE, format("%.2f%%", SC), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_HASTE, format("%.2f%%", Total_Spell_Haste), 1, 1, 1) GameTooltip:AddDoubleLine(MANA_REGEN, format(manaRegenString, base * 5, casting * 5), 1, 1, 1) elseif playerRole == "DAMAGER" then if englishClass == "HUNTER" then local Total_Range_Haste = GetRangedHaste("player") local Range_Armor_Pen = GetArmorPenetration(); local Range_Crit = GetRangedCritChance("25") local speed = UnitRangedDamage("player") local Total_Range_Speed = speed GameTooltip:AddLine(STAT_CATEGORY_RANGED) GameTooltip:AddDoubleLine("Armor Penetration", format("%.2f%%", Range_Armor_Pen), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_CRITICAL_STRIKE, format("%.2f%%", Range_Crit), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_HASTE, format("%.2f%%", Total_Range_Haste), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_ATTACK_SPEED, format("%.2f".." (sec)", Total_Range_Speed), 1, 1, 1) else local Melee_Crit = GetCritChance("player") local Melee_Armor_Pen = GetArmorPenetration(); local Total_Melee_Haste = GetMeleeHaste("player") local mainSpeed = UnitAttackSpeed("player"); local MH = mainSpeed GameTooltip:AddLine(STAT_CATEGORY_MELEE) GameTooltip:AddDoubleLine("Armor Penetration", format("%.2f%%", Melee_Armor_Pen), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_CRITICAL_STRIKE, format("%.2f%%", Melee_Crit), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_HASTE, format("%.2f%%", Total_Melee_Haste), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_ATTACK_SPEED, format("%.2f".." (sec)", MH), 1, 1, 1) end end GameTooltip:AddLine' ' GameTooltip:AddLine(STAT_CATEGORY_GENERAL) local masteryspell local Multi_Strike = GetMultistrike(); local Life_Steal = GetLifesteal(); --local Versatility = GetVersatility(); local Versatility_Damage_Bonus = GetCombatRatingBonus(CR_VERSATILITY_DAMAGE_DONE) + GetVersatilityBonus(CR_VERSATILITY_DAMAGE_DONE); local Avoidance = GetAvoidance(); local bonusArmor, isNegatedForSpec = UnitBonusArmor("player"); GameTooltip:AddDoubleLine(STAT_BONUS_ARMOR, format("%s", bonusArmor), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_MULTISTRIKE, format("%.2f%%", Multi_Strike), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_LIFESTEAL, format("%.2f%%", Life_Steal), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_VERSATILITY, format("%.2f%%", Versatility_Damage_Bonus), 1, 1, 1) --GameTooltip:AddDoubleLine(STAT_VERSATILITY, format("%d", Versatility), 1, 1, 1) GameTooltip:AddDoubleLine(STAT_AVOIDANCE, format("%.2f%%", Avoidance), 1, 1, 1) if GetCombatRating(CR_MASTERY) ~= 0 and GetSpecialization() then if englishClass == "DRUID" then if playerRole == "DAMAGER" and not playerRole == "CASTER" then masteryspell = select(2, GetSpecializationMasterySpells(GetSpecialization())) elseif playerRole == "TANK" then masteryspell = select(1, GetSpecializationMasterySpells(GetSpecialization())) else masteryspell = GetSpecializationMasterySpells(GetSpecialization()) end else masteryspell = GetSpecializationMasterySpells(GetSpecialization()) end local Mastery = GetMasteryEffect("player") local masteryName, _, _, _, _, _, _, _, _ = GetSpellInfo(masteryspell) if masteryName then GameTooltip:AddDoubleLine(masteryName, format("%.2f%%", Mastery), 1, 1, 1) end end end GameTooltip:Show() end local function UpdateTank(self) local armorString = hexa..ARMOR..hexb..": " local displayNumberString = string.join("", "%s", "%d|r"); local base, effectiveArmor, armor, posBuff, negBuff = UnitArmor("player"); local Melee_Reduction = effectiveArmor Text:SetFormattedText(displayNumberString, armorString, effectiveArmor) --Setup Tooltip self:SetAllPoints(Text) end local function UpdateCaster(self) local spellpwr = GetSpellBonusDamage("2"); local displayNumberString = string.join("", "%s", "%d|r"); Text:SetFormattedText(displayNumberString, hexa.."SP: "..hexb, spellpwr) --Setup Tooltip self:SetAllPoints(Text) end local function UpdateDamager(self) local displayNumberString = string.join("", "%s", "%d|r"); if englishClass == "HUNTER" then local base, posBuff, negBuff = UnitRangedAttackPower("player") local Range_AP = base + posBuff + negBuff pwr = Range_AP else local base, posBuff, negBuff = UnitAttackPower("player") local Melee_AP = base + posBuff + negBuff pwr = Melee_AP end Text:SetFormattedText(displayNumberString, hexa.."AP: "..hexb, pwr) --Setup Tooltip self:SetAllPoints(Text) end -- initial delay for update (let the ui load) local int = 5 local function Update(self, t) int = int - t if int > 0 then return end if playerRole == nil then Text:SetText(hexa.."No Stats"..hexb) else if playerRole == "TANK" then UpdateTank(self) elseif playerRole == "HEALER" or playerRole == "CASTER" then UpdateCaster(self) elseif playerRole == "DAMAGER" then UpdateDamager(self) end end int = 2 end plugin:SetScript("OnEnter", function() ShowTooltip(plugin) end) plugin:SetScript("OnLeave", function() GameTooltip:Hide() end) plugin:SetScript("OnUpdate", Update) Update(plugin, 10) return plugin -- important! end
Thank You for all the help with the nData project.
Coke
Last edited by cokedrivers : 11-03-14 at 11:40 AM.
|
Linear Mode
