LUA: Hide default frames OOC and show if target

[Valixx]

Hello guys.

I need some help with the following. Here's what I need it ( the code ) to do:

• Hide if out of combat ( this works so far )
• show if I have a target ( this isn't )

local f = CreateFrame('frame', nil, nil, 'SecureHandlerStateTemplate')
f:SetFrameRef('PlayerFrame', PlayerFrame)
f:SetFrameRef('TargetFrame', TargetFrame)
f:SetFrameRef('FocusFrame', FocusFrame)
f:SetFrameRef('ComboFrame', ComboFrame)
f:SetAttribute('_onstate-combat', [=[ -- Securely toggle visibility in combat
    if newstate == 'show' then
        self:GetFrameRef('PlayerFrame'):Show()
        if UnitExists('target') then
            self:GetFrameRef('TargetFrame'):Show()
            self:GetFrameRef('PlayerFrame'):Show()
        end
        if UnitExists('focus') then
            self:GetFrameRef('FocusFrame'):Show()
        end
    else
        self:GetFrameRef('PlayerFrame'):Hide()
        self:GetFrameRef('TargetFrame'):Hide()
        self:GetFrameRef('FocusFrame'):Hide()
        self:GetFrameRef('ComboFrame'):Hide()
    end
]=])
RegisterStateDriver(f, 'combat', '[combat] show; hide', '[target, exists] show')
 
local function HideFrame(self) -- Insecurely hide out of combat if shown
    if not InCombatLockdown() or not UnitExists("target") then self:Hide() end
end
PlayerFrame:HookScript('OnShow', HideFrame)
TargetFrame:HookScript('OnShow', HideFrame)
FocusFrame:HookScript('OnShow', HideFrame)
ComboFrame:HookScript('OnShow', HideFrame)
 
f:SetScript('OnEvent', function(self, event)
    if GetComboPoints('player', 'target') > 0 then -- Show ComboFrame upon entering combat if we have points
        ComboFrame:Show()
    end
end)
f:RegisterEvent('PLAYER_REGEN_DISABLED')

[semlar]

You have your target condition as a completely separate 4th argument for RegisterStateDriver, which only takes 3 arguments.

RegisterStateDriver(f, 'combat', '[combat] show; hide', '[target, exists] show')

You need to combine the macro conditions into one string that handles both situations.

RegisterStateDriver(f, 'combat', '[target,exists][combat] show; hide')

The other problem is that you're hooking all of their OnShow scripts to hide the frame 'if not InCombatLockdown() or not UnitExists("target")', which means it will always attempt to hide the frame if it's shown out of combat.

It should use "and" instead of "or" since you can't securely hide the frames in combat that way, however it should not be necessary to hide any of the frames this way if the state driver is working, so you might as well remove the hooks.

[Valixx]

Thanks for answering. I'll see what I can do later... need to go and cook something fine

Allright, just seen your edit. I'll try that then.

I'll report back later. Thank you.

[semlar]

You might also consider reparenting all of these frames to frame f and simply hiding and showing that rather than handling them separately, that way you won't have to worry about them being shown when they're not supposed to be.

If you choose to do that you'll want to make f a child of UIParent to keep the scales consistent.

[Valixx]

The unitframes are working fine now. If there's a target and in combat, they are showing. Extactly what I wanted.

local f = CreateFrame('frame', nil, nil, 'SecureHandlerStateTemplate')
f:SetFrameRef('PlayerFrame', PlayerFrame)
f:SetFrameRef('TargetFrame', TargetFrame)
f:SetFrameRef('FocusFrame', FocusFrame)
f:SetFrameRef('ComboFrame', ComboFrame)
f:SetAttribute('_onstate-combat', [=[ -- Securely toggle visibility in combat
    if newstate == 'show' then
        self:GetFrameRef('PlayerFrame'):Show()
        if UnitExists('target') then
            self:GetFrameRef('TargetFrame'):Show()
            self:GetFrameRef('PlayerFrame'):Show()
        end
        if UnitExists('focus') then
            self:GetFrameRef('FocusFrame'):Show()
        end
    else
        self:GetFrameRef('PlayerFrame'):Hide()
        self:GetFrameRef('TargetFrame'):Hide()
        self:GetFrameRef('FocusFrame'):Hide()
        self:GetFrameRef('ComboFrame'):Hide()
    end
]=])
RegisterStateDriver(f, 'combat', '[target,exists][combat] show; hide')
 
f:RegisterEvent('PLAYER_REGEN_DISABLED')

The second thing I wanted to try is to show the minimap only if in combat. This is what I got so far:

MinimapCluster:RegisterEvent("PLAYER_REGEN_ENABLED")
MinimapCluster:RegisterEvent("PLAYER_REGEN_DISABLED")
MinimapCluster:HookScript("OnEvent", function(self, event)
    if event == "PLAYER_REGEN_ENABLED" then
        self:Hide()
    else
        self:Show()
    end
end)

This is what happens after a /reload:

Out of combat -> Minimap is shown.
Entering combat -> Minimap is shown.
Leaving combat -> Minimap is hidden.

Any tips on how to hide it from the start ( login / reload )?

[semlar]

Originally Posted by Valixx Any tips on how to hide it from the start ( login / reload )?

Register event PLAYER_LOGIN and do something like self:SetShown(event == 'PLAYER_REGEN_DISABLED')

[Valixx]

I tried so many things, it just won't work... still trying..

I even added commands and stuff, everything's working fine but the hide on login... Tried with ADDON_LOADED, PLAYER_ENTERING_WORLD and PLAYER_LOGIN.

[semlar]

I don't know what you tried, but this works fine for me, at least as far as I understand what you're asking.

MinimapCluster:RegisterEvent("PLAYER_REGEN_ENABLED")
MinimapCluster:RegisterEvent("PLAYER_REGEN_DISABLED")
MinimapCluster:RegisterEvent("PLAYER_LOGIN")
MinimapCluster:HookScript("OnEvent", function(self, event)
    self:SetShown(event == "PLAYER_REGEN_DISABLED")
end)

[Valixx]

Got everything working now. I did the same thing to hide the BuffFrame and it works too.

Thanks for your help, I appreaciate it.