Thread Tools Display Modes
09-28-12, 08:22 AM   #1
Animor
A Flamescale Wyrmkin
AddOn Author - Click to view addons
Join Date: Mar 2011
Posts: 136
My addon started tainting FocusUnit()

Hello,

Recently people started complaining about my addon giving them taint lua errors, connected to FocusUnit().
I didn't change anything in my addon for months, so I don't know why this errors started just now.

Anyway, my addon doesn't use any focus related api. I've made some searches and found out that it can be related to my addon using a dropdown menu (I use it for the user to select a font from a list of fonts).

Is it indeed the dropdown menu that causes the lua error?
Is there an easy way to resolve this issue? because people stopped using my addon because of this error.

I attach an example of the error my addon does. Any help is appreciated!
Attached Thumbnails
Click image for larger version

Name:	hebchat_error.jpg
Views:	632
Size:	47.1 KB
ID:	7223  
  Reply With Quote
09-28-12, 08:49 AM   #2
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2005
Posts: 793
Oh boy! *getting popcorn*
__________________
Profile: Curse | Wowhead
  Reply With Quote
09-28-12, 09:02 AM   #3
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,740
Man...why is the dropdownmenu ****ed up like that?
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
  Reply With Quote
09-28-12, 09:08 AM   #4
Animor
A Flamescale Wyrmkin
AddOn Author - Click to view addons
Join Date: Mar 2011
Posts: 136
I understand that this may be a joke for some of you... But I've just came back from few months absence, and I'm trying to fix this addon.

So I would really appreciate some help here...
  Reply With Quote
09-28-12, 09:41 AM   #5
Vlad
A Molten Giant
 
Vlad's Avatar
AddOn Author - Click to view addons
Join Date: Dec 2005
Posts: 793
I will let someone else explain dropdown taint, I am afraid I may say something wrong. :P

*Edit*

I suspect the issue is taint with dropdown, and for the love of god I can't find some post summarizing why and how to deal with this issue, that's why I couldn't post a good reply.
__________________
Profile: Curse | Wowhead

Last edited by Vlad : 09-28-12 at 10:21 AM.
  Reply With Quote
09-28-12, 05:02 PM   #6
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Any addon touching any dropdown menu anywhere at any time will taint the entire dropdown menu system, breaking the focus menu commands and all other secure menu commands. The only solution is to write your own dropdown system from scratch (or find a library that does it) and not touch anything remotely related to the Blizzard dropdown menu system in any way at any time.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote

WoWInterface » Developer Discussions » Lua/XML Help » My addon started tainting FocusUnit()


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off