2.4 issues

[ceraph]

OK so got the test realm up this morning and got the following errors:

1) SmartBuff
[2008/02/10 08:30:10-1-x1]: SmartBuff-v2.2a\SmartBuff.lua:808: attempt to index field '?' (a nil value)
SmartBuff-v2.2a\SmartBuff.lua:759: in function `SMARTBUFF_SetUnits'
SmartBuff-v2.2a\SmartBuff.lua:2842: in function `SMARTBUFF_Options_Init'
SmartBuff-v2.2a\SmartBuff.lua:220: in function `SMARTBUFF_OnEvent'
SmartBuff-v2.2a\SmartBuff.lua:443: in function `SMARTBUFF_OnUpdate'
<string>:"*:OnUpdate":1: in function <[string "*:OnUpdate"]:1>


2) Mazzifier
[2008/02/10 08:31:31-1-x1]: Mazzifier-1.1\Mazzifier_Configs.lua:348: Couldn't find CVar named 'UnitNamePlayer'

[ceraph]

OK so did some testing
1) Deleted SmartBuff for now
2) Commented out that 1 line and get the following:

[2008/02/10 08:39:21-3-x1]: Mazzifier-1.1\Mazzifier_Configs.lua:3381: Couldn't find CVar named 'UnitNamePlayer'

And now also getting this error:
[2008/02/10 08:39:21-3-x621]: DiscordUnitFrames\DUF_Element.lua:524: attempt to index field '?' (a nil value)
<string>:"*:OnUpdate":1: in function <[string "*:OnUpdate"]:1>

[ceraph]

so there seems to be a problem with the CVar in general trying to do some research if anyone else has any ideas please post them up.

Same with the DUF issue DUF.

Also so you all know these issues at the moment are holding up the mazzification completion

[Mazzlefizz]

UnitNamePlayer is probably being used in other code, so you can't simply comment out the line that initializes it. You'll need to replace that line with something else that gets the player's name, probably a function call.

[Seerah]

A lot of mods are going to need to be rewritten come 2.4.

[Aygen]

Aye, 2.4 will be an interesting milestone for the Mazzle fan-base.

[donofthedead]

It's amazing how many addons rely on the combat log to work. With the changes to the combat log, I'm not sure 90% of the addons I employ will continue to function. Hopefully MazzleUI as a whole will function once the independent addons are updated.

Mazzle, since you're most familiar with the UI as a whole, what should we expect from your package manager come 2.4? I wouldn't be surprised if it worked once the addons you've packaged are updated, but is there anything you think of that the upcoming patch might irreparably break in your UI?

[Peneth]

Here are the BugGrabber catchs after just copying my WTF file from Live and my Addons from Live.

1. [2008/02/11 19:42:31-6-x1]: ...tographer\Cartographer_InstanceLoot\InstanceLoot.lua:4: Library "LibPeriodicTable-3.1" not found.:
LibRock-1.0-40347 (LibRock-1.0):1667: in function `Rock'
...tographer\Cartographer_InstanceLoot\InstanceLoot.lua:4: in main chunk:

2. [2008/02/11 19:42:43-6-x1]: FuBar_GarbageFu\GarbageFu.lua:6: Cannot find a library instance of LibPeriodicTable-3.1.
Ace2\AceLibrary\AceLibrary.lua:490: in function `AceLibrary'
FuBar_GarbageFu\GarbageFu.lua:6: in main chunk

---

3. [2008/02/11 19:42:43-6-x1]: FuBar_GarbageFu\GarbageFu.lua:6: Cannot find a library instance of LibPeriodicTable-3.1.
Ace2\AceLibrary\AceLibrary.lua:490: in function `AceLibrary'
FuBar_GarbageFu\GarbageFu.lua:6: in main chunk

---

4. [2008/02/11 19:44:20-6-x6]: FuBar_NameToggleFu\Core.lua:113: Couldn't find CVar named 'UnitNamePlayer'
FuBar_NameToggleFu\Core.lua:113: in function `OnTooltipUpdate'
FuBarPlugin-2.0-59583:369: in function `runChildren'
Tablet-2.0-60270 (TabletLib):2356: in function `children'
Tablet-2.0-60270 (TabletLib):2400: in function `Open'
Tablet-2.0-60270 (TabletLib):2534: in function <Interface\AddOns\TabletLib\Tablet-2.0\Tablet-2.0.lua:2528>
FuBarPlugin-2.0-59583:418: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:417>

---

5. [2008/02/11 19:45:18-6-x1]: Cartographer-r60284\Cartographer_Notes\Notes.lua:3899: Trying to iterate through notes in an unknown zone: "Isle of Quel'Danas"

---

6. [2008/02/11 19:48:35-6-x1]: Interface\FrameXML\SecureTemplates.lua:276: attempt to call global 'ClickSpellByName' (a nil value):
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>

---

SS of the copied UI after trying to Mazzify (Was unable to Mazzify before and After bring over my WTF files, SS is the one taken after):

Hope this is enough to help. Don't know how to code at all, and I'm rather addicted to MazzleUI. Worked amazing so far through out raiding BT and I look forward to using it in SWP. I'd be glad to help test things out.

[LBussy]

The CVar UnitNamePlayer was changed to UnitNameSelf. The following lines need to be changed:

[...\Interface\AddOns\DBM_API\API.lua]
Line 1228 :if (tonumber(GetCVar("UnitNamePlayer")) == 1) then
Line 1230 :SetCVar("UnitNamePlayer", 0);
Line 1324 :SetCVar("UnitNamePlayer", 0);
Line 1344 :SetCVar("UnitNamePlayer", 1);
[...\Interface\AddOns\DBM_GUI\GUI.lua]
Line 326 :if (tonumber(GetCVar("UnitNamePlayer")) == 1) then
Line 328 :SetCVar("UnitNamePlayer", 0);
Line 333 :SetCVar("UnitNamePlayer", 1);
Line 340 :SetCVar("UnitNamePlayer", 1);
[...\Interface\AddOns\DBM_GUI\GUI.xml]
Line 3567 :and tonumber(GetCVar("UnitNamePlayer")) == 1
Line 3571 :SetCVar("UnitNamePlayer", 0);
Line 3577 :SetCVar("UnitNamePlayer", 1);
[...\Interface\AddOns\FuBar_NameToggleFu\Core.lua]
Line 113 :"text2", GetCVar("UnitNamePlayer") == "1" and L["tipshown"] or L["tiphidden"],
Line 116 :"arg2", "UnitNamePlayer"
Line 214 :"arg2", "UnitNamePlayer",
Line 215 :"checked", GetCVar("UnitNamePlayer") == "1",
[...\AddOns\Mazzifier\Mazzifier.lua]
Line 387 :SetCVar("UnitNamePlayer", "0")
Line 388 :SetCVar("UnitNamePlayerGuild", "0")
Line 389 :SetCVar("UnitNamePlayerPVPTitle", "0")
Line 397 :SetCVar("UnitNamePlayer", "1")
Line 407 :SetCVar("UnitNamePlayer", "1")
[...\Interface\AddOns\Mazzifier\Mazzifier_Configs.lua]
Line 348 :SetCVar("UnitNamePlayer", "1")
Line 3381 :SetCVar("UnitNamePlayer",1)

This is by no means all of the changes needed, but it's the first thing I've found that needs fixed.

[Peneth]

This morning's clean install netted me the following errors when trying to mazzify. They only happened after I tried to Mazzify.

1. [2008/02/12 10:07:17-1-x2]: FuBar_NameToggleFu\Core.lua:88: Couldn't find CVar named 'UnitNamePlayer'
FuBar_NameToggleFu\Core.lua:88: in function `OnTooltipUpdate'
FuBarPlugin-2.0-52843:366: in function `runChildren'
Tablet-2.0-49630 (TabletLib):2355: in function `children'
Tablet-2.0-49630 (TabletLib):2399: in function `Open'
Tablet-2.0-49630 (TabletLib):2533: in function <Interface\AddOns\TabletLib\Tablet-2.0\Tablet-2.0.lua:2527>
FuBarPlugin-2.0-52843:415: in function <...\FuBarPlugin-2.0\FuBarPlugin-2.0\FuBarPlugin-2.0.lua:414>

2. [2008/02/12 10:07:52-1-x1]: Mazzifier-1.1\Mazzifier_Configs.lua:348: Couldn't find CVar named 'UnitNamePlayer'

---

[edit]
Are you supposed to be able to just change "UnitNamePlayer" to "UnitNameSelf"? If so, the second error I posted in this post is still there.

[LBussy]

Originally Posted by Peneth This morning's clean install netted me the following errors when trying to mazzify. They only happened after I tried to Mazzify.

Make all teh changes I have listed and you will get past that (with a whole new set of errors).

[Peneth]

Maybe it's me not seeing the forest for the trees but that last line in the Mazzifier you said to change.....I don't see that there. Actually I'm not finding most of the changes you say I need to make. Could you possibly put them in a file and upload 'em? I am sort of clueless as to what I'm doing.

[LBussy]

Originally Posted by Peneth Maybe it's me not seeing the forest for the trees but that last line in the Mazzifier you said to change.....I don't see that there. Actually I'm not finding most of the changes you say I need to make. Could you possibly put them in a file and upload 'em? I am sort of clueless as to what I'm doing.

Please don't take this the wrong way but if you are "clueless" you should probably wait. This is not the fix, it's a fix that can be added to the others people will find. Making these changes will only show new errors - it will not leave you with a working 2.4 installation.

[Peneth]

Originally Posted by LBussy Please don't take this the wrong way but if you are "clueless" you should probably wait. This is not the fix, it's a fix that can be added to the others people will find. Making these changes will only show new errors - it will not leave you with a working 2.4 installation.

I may be clueless but I am capable of finding a line and copy/pasting something . I'm not a coder but if you tell me what to change, where and to what, I can at least do that and see what happens given how much time I'm spending on the PTR and how much I'd like to see this project continue. May not be able to help donate or something but I can at least offer this much.

[Mazzlefizz]

Originally Posted by donofthedead Mazzle, since you're most familiar with the UI as a whole, what should we expect from your package manager come 2.4? I wouldn't be surprised if it worked once the addons you've packaged are updated, but is there anything you think of that the upcoming patch might irreparably break in your UI?

My add-ons don't do any combat log parsing that I recall. Lots of other add-ons do, though, and that will require massive updates to them. I would expect that might lead to other changes including ones that affect the format of their settings, which could break parts of the Mazzifier. And with many of these big patches, Blizzard changes the names or paths of the 3d models. That would mean someone would have to update the 3d model database as well.

Peneth, I think he was just saying that those changes aren't really going to fix anything for you. And, reporting what happens afterwards probably won't lead to helping fix anything. There's just too much that will be broken with many add-ons at this point. I don't think it was anything personal. He just didn't want you to waste your time.

[ceraph]

Originally Posted by LBussy The CVar UnitNamePlayer was changed to UnitNameSelf. The following lines need to be changed: [...\Interface\AddOns\DBM_API\API.lua] Line 1228 :if (tonumber(GetCVar("UnitNamePlayer")) == 1) then Line 1230 :SetCVar("UnitNamePlayer", 0); Line 1324 :SetCVar("UnitNamePlayer", 0); Line 1344 :SetCVar("UnitNamePlayer", 1); [...\Interface\AddOns\DBM_GUI\GUI.lua] Line 326 :if (tonumber(GetCVar("UnitNamePlayer")) == 1) then Line 328 :SetCVar("UnitNamePlayer", 0); Line 333 :SetCVar("UnitNamePlayer", 1); Line 340 :SetCVar("UnitNamePlayer", 1); [...\Interface\AddOns\DBM_GUI\GUI.xml] Line 3567 :and tonumber(GetCVar("UnitNamePlayer")) == 1 Line 3571 :SetCVar("UnitNamePlayer", 0); Line 3577 :SetCVar("UnitNamePlayer", 1); [...\Interface\AddOns\FuBar_NameToggleFu\Core.lua] Line 113 :"text2", GetCVar("UnitNamePlayer") == "1" and L["tipshown"] or L["tiphidden"], Line 116 :"arg2", "UnitNamePlayer" Line 214 :"arg2", "UnitNamePlayer", Line 215 :"checked", GetCVar("UnitNamePlayer") == "1", [...\AddOns\Mazzifier\Mazzifier.lua] Line 387 :SetCVar("UnitNamePlayer", "0") Line 388 :SetCVar("UnitNamePlayerGuild", "0") Line 389 :SetCVar("UnitNamePlayerPVPTitle", "0") Line 397 :SetCVar("UnitNamePlayer", "1") Line 407 :SetCVar("UnitNamePlayer", "1") [...\Interface\AddOns\Mazzifier\Mazzifier_Configs.lua] Line 348 :SetCVar("UnitNamePlayer", "1") Line 3381 :SetCVar("UnitNamePlayer",1) This is by no means all of the changes needed, but it's the first thing I've found that needs fixed.

LBussy, thanks figured they changed something like this. So just want to clarify that even the variables UnitNamePlayerGuild should be changed to UnitNameSelfGuild. Correct?

I plan on trying to work on some fixes later tonight once I get home.

[LBussy]

Originally Posted by ceraph LBussy, thanks figured they changed something like this. So just want to clarify that even the variables UnitNamePlayerGuild should be changed to UnitNameSelfGuild. Correct?

No, actually that stayed the same (sorry I was a little confusing on that). Just the UnitNamePlayer entries get changed to UnitNameSelf.

[ceraph]

Are we sure its UnitNameSelf?

[2008/02/16 13:14:08-4-x1]: Mazzifier-1.1\Mazzifier_Configs.lua:348: Couldn't find CVar named 'UnitNameSelf'\


Also if I comment it out to get to the next I continue to get a similar error to UnitNameSelf

And also get this:

[2008/02/16 13:30:13-5-x219]: DiscordUnitFrames\DUF_Element.lua:524: attempt to index field '?' (a nil value)
<string>:"*:OnUpdate":1: in function <[string "*:OnUpdate"]:1>



This image shows me copying my existing 2.3 settings and saved variables to the test realm with NO Mazzification done after.
So what I see is (as it pertains to Mazzle only not my other mods)
1) DUF is not working properly (Player and target not going to the right places)
2) Buffs in top right corner of screen
3) Private tab of the conversation on the left looks to be the combat log (do to the obvious changes in the combat log)
4) Autobar is all over the place
5) FubarNameTogglefu
6) Smartbuff
7) A casting bar is displaying over the target window

Mods that seem to be working correctly at first glance
1) Clique
2) Bongos
3) Fubar
4) TrinketMenu
5) SCT appears to be working
6) Quartz

The 2 errors you see that are in my bugsack are currently for Recount (not part of the Mazzle package) and FubarNametoggleFu

[Bens]

Hey Lbussy i've been following your tips and have changed all the code except for :

[...\Interface\AddOns\DBM_GUI\GUI.xml]
Line 3567 :and tonumber(GetCVar("UnitNamePlayer")) == 1
Line 3571 :SetCVar("UnitNamePlayer", 0);
Line 3577 :SetCVar("UnitNamePlayer", 1);

I cannot find this folder therefore I can't change those lines. Could they be somewhere else?

BTW thanks for making a start on fixing this UI i've been using it for over a year and the suppot is top notch.

[ceraph]

Bens thats in deadly boss mods

The other changes you made have they worked on the PTR because the function call that Lbussy posted seems to not be recognized after I made the change?