Text on top of each other in frame

[Trailertina]

Hey all, I'm trying to make a simple addon to myself because I'm too lazy to look through the chat in M+

The addon opens a frame with peoples loot and a button to easily whisper them and it works okay when two players get loot, BUT when a third or more players receives loot the text is printed on top of the two first players text/loot. I give the complete code for the addon here, but I would recon that the problem is somewhere in the 'UpdateLootWindow' function? I guess it's maybe yoffset that needs adjustment? But I cannot get anything to work. I also give you an image of the loot frame when a third or more player gets loot.

[IMG] https://prnt.sc/bh4sMlYgbGer

Code beneath:

https://github.com/Trailertina/MythicPlusLoot

[Fizzlemizz]

Every time UpdateLootWindow runs, it's creating a new set of widgets (Fontstrings and Buttons) on top of the old ones.

You should only create them once (and maybe add extras (once) if needed)
Very rough example:

LootAddonFrame.LootWindow = CreateFrame("Frame", "LootAddonFrame_LootWindow", UIParent, "UIPanelDialogTemplate")
LootAddonFrame.LootWindow.PlayerInfo = {} -- a table to store created FontString references

UpdateLootWindow()

local count = 0
for playerName, lootList in pairs(lootHistory) do
   -- ...
    local playerLabel
    count = count + 1
    local last = #LootAddonFrame.LootWindow.PlayerInfo -- How many have we created previously
    if last < count -- not enough widgets so create new FontString and Button
        playerLabel = LootAddonFrame.LootWindow:CreateFontString(nil, "OVERLAY", "GameFontNormal")
        local whisperButton = CreateFrame("Button", nil, LootAddonFrame.LootWindow, "UIPanelButtonTemplate")
        -- configure the fontstring and button scripts etc.
        if count = 1 then -- place them relative to the frame or previous string/buttons (instead of calculating y offset
                playerLabel:SetPoint("TOPLEFT", 10, -30)
        else
                local lastInList = LootAddonFrame.LootWindow.PlayerInfo[last]
                playerLabel:SetPoint("TOPLEFT", lastInList, "BOTTOMLEFT", 0, -3)
        end
        whisperButton:SetPoint("LEFT", playerLabel, "RIGHT", 5, 0)
        tinsert(LootAddonFrame.LootWindow.PlayerInfo, playerLabel) -- add the label to the reacking table
    else
        playerLabel = LootAddonFrame.LootWindow.PlayerInfo[last] -- a fonstring exists so re-use those first
    end
    -- update the FontString text and whatever else.
    playerLabel:SetText(coloredPlayerName .. " looted:")
    -- ...
end