Thread Tools Display Modes
10-19-14, 01:24 PM   #1
Imithat
A Fallenroot Satyr
 
Imithat's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 27
Question FluidFrames bug

Hey folks,

Ok, i tried MoveAnything (updated to 6.0.2) and its very nice. But MoveAnything find not all Frames. This makes me sick! So i need FluidFrames. But this was bugged. No chance to that was updated by the owner. Got this error:

Lua Code:
  1. 38x FluidFrames\FrameReparent.lua:75: Attempt to access forbidden object from code tainted by an AddOn
  2. [C]: in function `GetNumPoints'
  3. FluidFrames\FrameReparent.lua:75: in function `GetAnchoredTo'
  4. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  5. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  6. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  7. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  8. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  9. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  10. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  11. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  12. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  13. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  14. ...
  15. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  16. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  17. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  18. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  19. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  20. FluidFrames\FrameReparent.lua:55: in function `GetPositionallyDependantOn'
  21. FluidFrames\FrameHide.lua:67: in function `HideAssociatedFrames'
  22. FluidFrames\FrameHide.lua:37: in function `LockHiddenFrame'
  23. FluidFrames\FluidFrames-2.4g.lua:164: in function `InitMovedFrames'
  24. FluidFrames\FluidFrames-2.4g.lua:202: in function <FluidFrames\FluidFrames.lua:173>
  25.  
  26. Locals:
  27. frameSet = <table> {
  28. (null) = true
  29. }
  30. first = ServicesLogoutPopup {
  31. 0 = <userdata>
  32. Background = <unnamed> {
  33. }
  34. }

I cant hide frames. This function doesnt work at this time

Can anybody help me?

(You find FluidFrames here)

Last edited by Imithat : 10-19-14 at 01:26 PM.
  Reply With Quote
10-19-14, 07:46 PM   #2
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
This should be an easy fix, but I'm lazy... can you post the contents of FluidFrames\FrameReparent.lua around line 75 where the error is occuring? Either attach the whole file or just post the ~10 lines above and below in a [code] tag.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote
10-20-14, 01:39 PM   #3
Imithat
A Fallenroot Satyr
 
Imithat's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 27
Sure
thanks phanx

Line 73 to 88
Lua Code:
  1. --[[-- From a list of frames/regions add the ones that are anchored once only to one of the frames in the frameSet to the frameSet. -- ]]--
  2. function FluidFrames.GetAnchoredTo(frameSet, first, ...)
  3.     if first and not frameSet[first] and first:GetNumPoints() == 1 then
  4.         -- TODO: check if it's anchored to a child of the frame
  5.         local relativeFrame = select(2, first:GetPoint(1))
  6.         if frameSet[relativeFrame] then
  7.             frameSet[first] = true
  8.             if select("#", ...) > 0 then
  9.                 FluidFrames.GetAnchoredTo(frameSet, ...)
  10.             end
  11.         end
  12.     end
  13.     if select("#", ...) > 0 then
  14.         FluidFrames.GetAnchoredTo(frameSet, ...)
  15.     end
  16. end

Or on Git:
https://github.com/Imithat/FluidFram...meReparent.lua
  Reply With Quote
10-20-14, 03:04 PM   #4
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
This should probably fix it:

Code:
if first and not first:IsProtected() and not frameSet[first] and first:GetNumPoints() == 1 then
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote
10-20-14, 03:29 PM   #5
Imithat
A Fallenroot Satyr
 
Imithat's Avatar
AddOn Author - Click to view addons
Join Date: May 2008
Posts: 27
get following

Lua Code:
  1. 1x FluidFrames\FrameReparent.lua:75: Attempt to access forbidden object from code tainted by an AddOn
  2. [C]: in function `IsProtected'
  3. FluidFrames\FrameReparent.lua:75: in function `GetAnchoredTo'
  4. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  5. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  6. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  7. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  8. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  9. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  10. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  11. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  12. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  13. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  14. ...
  15. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  16. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  17. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  18. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  19. FluidFrames\FrameReparent.lua:86: in function `GetAnchoredTo'
  20. FluidFrames\FrameReparent.lua:55: in function `GetPositionallyDependantOn'
  21. FluidFrames\FrameHide.lua:67: in function `HideAssociatedFrames'
  22. FluidFrames\FrameHide.lua:37: in function `LockHiddenFrame'
  23. FluidFrames\FluidFrames-2.4g.lua:164: in function `InitMovedFrames'
  24. FluidFrames\FluidFrames-2.4g.lua:202: in function <FluidFrames\FluidFrames.lua:173>
  25.  
  26. Locals:
  27. frameSet = <table> {
  28. (null) = true
  29. }
  30. first = ServicesLogoutPopup {
  31. 0 = <userdata>
  32. Background = <unnamed> {
  33. }
  34. }
  Reply With Quote
10-20-14, 05:48 PM   #6
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Alright, you probably need to move the :IsProtected() check further up the food chain. Find where the .GetAnchoredTo function is called, and trace it back to the first place it tries to do anything with a frame, and stop it from doing that if the frame is protected. You can't really break anything by adding more :IsProtected() checks in more places.

Or, just use MoveAnything... I can't imagine there can be that many frames in the default UI it can't handle, and any addon that provides a GUI should also provide some function for moving it.
__________________
Retired author of too many addons.
Message me if you're interested in taking over one of my addons.
Don’t message me about addon bugs or programming questions.
  Reply With Quote

WoWInterface » AddOns, Compilations, Macros » AddOn Help/Support » FluidFrames bug


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off