Tags and Events

[kip]

hey,

I'm trying to make my first oUF Layout. I'm using P3Lim's Layout as basis, but I'm having some problems to understand the tag system.

Following P3lim's example, I created a custom tag to show the combo-points.
The code looks like this:

oUF.TagEvents['[customcpoints]'] = 'UNIT_TARGET UNIT_COMBO_POINTS'
oUF.Tags['[customcpoints]'] = function(unit)
   -- if (unit ~= 'player') then return end
   local cp = GetComboPoints('player', 'target')
   local sw = {
      [1] = '|cFFFFFFFF%s',
      [2] = '|cFFFFFFFF%s',
      [3] = '|cFFebee14%s',
      [4] = '|cFFf4aa0b%s',
      [5] = '|cFFf40b0b%s',
   }
   if (cp > 0) then return format(sw[cp], cp)
   else return end  
end

...

   if (unit == 'target') then
   
		local comp = self:CreateFontString(nil, 'OVERLAY')
		comp:SetFont(font, fsize, 'OUTLINE')
		comp:SetPoint('LEFT', self, 'RIGHT', 10, 0)
		self:Tag(comp, '[customcpoints]')
   
   end

But this doesn't really work. If I just attack my target it shows nothing. If I clear my target during combat and retarget the mob it shows "something" (most of the time a false value ... e.g. if I should have 1 CP it display 2 or 3 or something like that).
Can somebody tell me what I'm doing wrong?

thanks!

P.S.: I saw that p3lim uses another way to display the combopoints, but this is kind of an experiment to understand and get used to the tag-system.

[p3lim]

Those false values might be that you have talents or glyphs that might give you more than 1 combopoint per special attack.

Dont create the table inside the function, it uses more memory that way.
Also, end your colors by using '|r'

local sw = {
	[1] = '|cFFFFFFFF%s|r',
	[2] = '|cFFFFFFFF%s|r',
	[3] = '|cFFebee14%s|r',
	[4] = '|cFFf4aa0b%s|r',
	[5] = '|cFFf40b0b%s|r',
}

oUF.TagEvents['[customcp]'] = 'UNIT_TARGET UNIT_COMBO_POINTS'
oUF.Tags['[customcp]'] = function(unit)
	if(unit == 'player' or unit == 'vehicle') then -- you want this to work with both you and your vehicle
		local cp = GetComboPoints(unit, 'target')
		return cp > 0 and format(sw[cp], cp)
	end
end

This should work

[kip]

Thank you, you put me on the right track! I used the tag inside the "target" definition, that can't work

So, in addition to your improvements, I changed it from

   if (unit == 'target') then
   
		local comp = self:CreateFontString(nil, 'OVERLAY')
		comp:SetFont(font, fsize, 'OUTLINE')
		comp:SetPoint('LEFT', self, 'RIGHT', 10, 0)
		self:Tag(comp, '[customcpoints]')
   
   end

to

   if (unit == 'player') then
   
		local comp = self:CreateFontString(nil, 'OVERLAY')
		comp:SetFont(font, fsize, 'OUTLINE')
		comp:SetPoint('LEFT', self, 'RIGHT', 10, 0)
		self:Tag(comp, '[customcpoints]')
   
   end

that. Now it works great!

But I have a another, very simillar problem. I've created a custom tag to display the creature type. Here's the code:

local creatures = {
   Humanoid = 'Hu',
   Dragonkin = 'Dragon',
   Elemental = 'Ele',
   Undead = 'Ud',
   Critter = 'Crit',
   Mechanical = 'Mech',
   ["Not specified"] = 'N/A',
   ["Non-combat Pet"] = 'Pet',
   ["Gas Cloud"] = 'Gas',
}
oUF.TagEvents['[customcreature]'] = 'UNIT_NAME_UPDATE UNIT_REACTION UNIT_FACTION UNIT_CLASSIFICATION_CHANGED'
oUF.Tags['[customcreature]'] = function(unit)
   local ct = UnitCreatureType(unit)
   return (creatures[ct] or ct)
end

...

   if (unit ~= 'targettarget') then
   
      local ctype = self.Health:CreateFontString('nil', 'OVERLAY')
      ctype:SetFont(font, fsize-2, 'OUTLINE')
      ctype:SetPoint('RIGHT', self, 0, 30)
      self:Tag(ctype, '[customcreature]')
   
   end

It works well, but it doesn't update if the creature type changed. I'm making this layout mainly for my druid. If I switch into cat and reload UI, it say's "Beast". But when I switch from cat to caster (without reloading the UI), it still says "Beast" [Of cause if I'm in caster stance and reload UI it says "Hu", but it then doesn't change to "Beast" if I switch into cat]. Any idea why the tag isn't updated?

(This bug doesn't bother me too much, but since I make this layout to learn something about lua and oUF, I would be really happy to know what causes this behavior)

[p3lim]

You havent specified the whole list of possible creature types.

Anyways, add this event: 'UPDATE_SHAPESHIFT_FORM'

[kip]

Originally Posted by p3lim You havent specified the whole list of possible creature types.

Yeah I know, that's on purpose. I only specified the types I want to truncate. All others are passed through.

Originally Posted by p3lim Anyways, add this event: 'UPDATE_SHAPESHIFT_FORM'

Didn't help :<