oUF_TotemBar Question

[Ferous]

Yes, it is me again with a crazy question! I was wondering how I could implement this function into the oUF_TotemBar.lua. I have no idea what else I should add... maybe someone can give me an idea on how to do this? :O Im trying to make it to where you right click and it destroys the totem, here is my code and its ugly and im not sure what else i have to add

OnClick = function(self,TotemBar)
			
			if button == "RightButton" then
			
			DestroyTotem(1);
			DestroyTotem(2);
			DestroyTotem(3);
			DestroyTotem(4);
			
			end
			
		end

Adding this to the oUF TotemBar and im trying, but its like i have to add something else to make it to where its not clicking through? THanks for any help and sorry for me being so bothersome with questions!

[Ferous]

I realized... would I need xml for this? Sorry for my noobness, but i realized it would make it a widget?

[Rostok]

Is your statusbar frame clickable ?
Maybe a :EnableMouse(true) would do the trick.

[haste]

As of 1.12 XML is only* needed for templates. What you most likely need to do is:

button:RegisterForClicks("LeftButtonUp", "RightButtonUp")

The frame is most likely a Button already, so no need to enable mouse on it.

* We were lacking quite a few widget function back then tho', and it still happens once in a while. A lot rarer now however; Last thing I can remember was the cooldown spiral icon in 2.4.

[Ferous]

Now I'm in a rut. I have something similar to this, i keep re-editing it with different things (experimenting if you will) and Im not exactly positive if there is anything else I may need to add to it or where exactly I can put it.. would I put it in my oUF Layout after my oUF TotemBar style or would I put it in the oUF totembar.lua itself? Sorry if Im asking too much questions but if maybe you guys can help resolve this possibly everyone will benefit from it and be able to right click their totems off from the totembar :P Sorry again for my noobness and Im still learning and thank you for putting up with me thus far! lol

Without further or do, here is the code i have so far:

OnClick = function(self,button)

			button:RegisterForClicks("LeftButtonUp", "RightButtonUp")
			
			if button == "RightButton" then
			
			DestroyTotem(1);
			DestroyTotem(2);
			DestroyTotem(3);
			DestroyTotem(4);
			
			end
			
		end

[Phanx]

You have to register the button for clicks before it can receive click events, so with your code, your OnClick handler never gets called. Also, you need to actually set the OnClick handler to your OnClick function.

button:RegisterForClicks("LeftButtonUp", "RightButtonUp")

button:SetScript("OnClick", function(self, mouseButton)
	if mouseButton == "RightButton" then
		DestroyTotem(1)
		DestroyTotem(2)
		DestroyTotem(3)
		DestroyTotem(4)
	end
end)

However, you might want to selectively destroy only the totem whose button was actually clicked on, though without seeing your actual code I couldn't tell you how to do that, since I don't know how your buttons are set up.

[nin]

this might be a little off, but for example sTotemtimers has that function.. might be a diff code for ouf_totembar don't know how the code looks and can't check from here unfortunately

here's the function in sTotemtimers, hope it's of any help :P

local function TotemOnClick(self, ...) 
         local buton = ...; 
         if ( buton == "RightButton" ) then 
                 DestroyTotem(self.slot); 
         end

[Phanx]

Originally Posted by nin local function TotemOnClick(self, ...) local buton = ...;

Eww...

local function TotemOnClick(self, buton)

^ Much better.

That said, that function is almost exactly what's already been posted, and doesn't really help when we don't know how the OPs buttons are constructed.

[haste]

To Phanx:

Midkemia /home/haste
123 ~ % echo 'function a(self, ...) end function b(self, button)' end | luac -l -p -      

main <stdin:0,0> (5 instructions, 20 bytes at 0x932fb30)
0+ params, 2 slots, 0 upvalues, 0 locals, 2 constants, 2 functions
	1	[1]	CLOSURE  	0 0	; 0x932fc58
	2	[1]	SETGLOBAL	0 -1	; a
	3	[1]	CLOSURE  	0 1	; 0x932fee8
	4	[1]	SETGLOBAL	0 -2	; b
	5	[1]	RETURN   	0 1

function <stdin:1,1> (1 instruction, 4 bytes at 0x932fc58)
1+ param, 2 slots, 0 upvalues, 2 locals, 0 constants, 0 functions
	1	[1]	RETURN   	0 1

function <stdin:1,1> (1 instruction, 4 bytes at 0x932fee8)
2 params, 2 slots, 0 upvalues, 2 locals, 0 constants, 0 functions
	1	[1]	RETURN   	0 1

In other words: doing local button = ...; is perfectly fine, and enforcing coding styles upon others is just... meh*.

* Unless you are planning on contributing to a project, then adopting the coding style of the project is recommended.

[Soeters]

I added this option in the latest version which has just been updated.
Just add this in your layout to enable it

self.TotemBar.Destroy = true

[Ferous]

Originally Posted by Soeters I added this option in the latest version which has just been updated. Just add this in your layout to enable it self.TotemBar.Destroy = true

You are awesome Thanks :O THis ends my conundrum!

[Phanx]

Originally Posted by haste In other words: doing local button = ...; is perfectly fine

It's slower, according to various tests using for loops and os.clock. Why use the code that's slower and harder to read?

[haste]

Originally Posted by Phanx It's slower, according to various tests using for loops and os.clock. Why use the code that's slower and harder to read?

It's quite obvious that any static implementation will beat a dynamic one quite heavily outside a JIT compiler. In any regard, it's the OnClick handler of a button. Optimizing it is just a waste of time, and the lost readability is discussable into oblivion.

[Phanx]

Eh.. using varargs in a function where you are guaranteed to have exactly one argument 100% of the time is just mind boggling to me. It's not even primarily a code readability issue or a performance issue; I see it and I just can't imagine why on earth anyone would even think to write it that way. *shrug*