UI Changes coming in 3.3.3

[Xrystal]

Thats what it has always done Scott. Works fine in 3.3.2 .. but now it seems to think that nUI isn't loaded until PlayerEnteringWorld triggers and not Variables Loaded.

I can get the standard frame working find with nUI but the docking system just refuses to work ..

[spiel2001]

Did you see the edit? That method guarantees it is loaded *if* it exists. You can do that step in the ADDON_LOADED phase.

[Xrystal]

Yeah I tried that as well. Doesn't even print text in ADDON_LOADED block for nUI.

nUI is clearly loading though but the tests I am doing are treating as if it isn't. I even temporarily turned nUI on as a LoadOnDemand addon in case that was stopping it but nope.

It's working in the sense that the non infopanel mode of the scrolling watch frame seemingly works as usual ( not that I tested it all out again yet ). It's just the infopanel doesn't seem to get created and I didn't touch that part of the code so it should work the same as it did in 3.3.2.

I'll be spending some more time on it during the week though so hopefully I will get it sorted out.

[spiel2001]

Just out of curiosity, what happens if you make your addon fully dependent on nUI? Does it still load incorrectly? If so, then the problem's in your logic somewhere because that mode guarantees the first mod is loaded before your mod is.

[Xrystal]

Okay without any code changes from 3.3.2 on the 3.3.3 test center the infopanel code loads fine apart from the odd watchframe_update error below and uses the width set up in non infopanel mode and ignoring the resizing I set up that worked fine in 3.3.2. *puzzled*

[2010/03/21 18:25:28-56-x1]: Interface\FrameXML\WatchFrame.lua:365: attempt to perform arithmetic on a nil value:
<in C code>: in function `WatchFrame_Update'
Interface\FrameXML\WatchFrame.lua:274: in function <Interface\FrameXML\WatchFrame.lua:230>:
<in C code>: in function `SetMapToCurrentZone'
...d_BattlefieldMinimap\Blizzard_BattlefieldMinimap.lua:58: in function <...d_BattlefieldMinimap\Blizzard_BattlefieldMinimap.lua:57>:
<in C code>: in function `Show'
...ault\InfoPanels\nUI_InfoPanel_BattlefieldMinimap.lua:294: in function `setEnabled':
...ault\InfoPanels\nUI_InfoPanel_BattlefieldMinimap.lua:207: in function `initPanel':
nUI-5.06.10 (Plus)\Integration\nUI_InfoPanel.lua:793: in function `applyScale'
nUI-5.06.10 (Plus)\Integration\nUI_InfoPanel.lua:908: in function `applyOptions'
nUI-5.06.10 (Plus)\Integration\nUI_InfoPanel.lua:937: in function `applySkin'
nUI-5.06.10 (Plus)\Main\nUI.lua:249: in function <Interface\AddOns\nUI\Main\nUI.lua:137>

Okay, put back the 3.3.3 version I worked on the last 2 weeks or so and it definitely doesn't like to work in the infopanel so I am clearly making it pop out of the infopanel somewhere. So, looks like I will have to track down what changes I somehow missed putting in nUI checked blocks.

[Xrystal]

Ah, strange, but managed to get it working but only if I hard code the nUI is Loaded and InfoPanel flags. Sounds like its the values not being loaded problem nUI is getting. Testing for it returns false at Variables Loaded stage and that is where the setup needs to be done.

Eg: This doesn't work

addonData["nUI"].Loaded = IsAddOnLoaded("nUI");
if ( addonData["nUI"].Loaded and addonData["nUI"].InfoPanel ) then
print("We are using the infopanel");
end

But this does

addonData["nUI"].Loaded = true;
addonData["nUI"].InfoPanel = true;
if ( addonData["nUI"].Loaded and addonData["nUI"].InfoPanel ) then
print("We are using the infopanel");
end

But if I put all creation code in PlayerEnteringWorld the whole watchframe messes up. *sigh* .. looks like another all dayer so will look at this during the week when I have more time rofl.

[spiel2001]

Here's a really simple test you can do at the "variables" loaded phase....

if nUI then
print( "using the info panel" );
end

that should do it. When nUI is loaded, it created a "nUI" global variable and that really is all you need to test for.

[Xrystal]

ah I will have to try that way and see if that works more consistently.

[Xrystal]

Aha, found the cause.

I'll have to double check why I did it specifically but I moved my Loading of saved variables to PlayerEnteringWorld instead of VariablesLoaded. Which meant that the non infopanel version worked fine as it is built up in PlayerEnteringWorld but the InfoPanel version is built in VariablesLoaded which of course has only the defaults to go by which means no infopanel so it ignores the whole block rofl.

So, added a VariablesLoaded flag and I reload the variables if they haven't already been loaded since the last save or create to ensure the latest data is being used when needed.

Well, so far so good. The filters work in the infopanel. It glitches out though when you first do the switch although I was pretty sure that was what I fixed before.

Edit: .. and cool .. with a few minor tests added it works in 3.3.2 as well. Will need to run a full test in all 4 scenarios to be on the safe side though so something for next week to do.

[Xrystal]

Ah, what timing. Looks like 3.3.3 will go live shortly so I only had to finish off my testing on the test server. There are a few minor irritants, some due to the options=nil bug that occurs fairly often on the test server. But all in all it does pretty much what the default does but with extra bells and whistles.

[spiel2001]

I presume by shortly you don't mean today... yes?

I need to get into the test realm and see what's up with those initialization errors.

[todd0168]

Originally Posted by spiel2001 I presume by shortly you don't mean today... yes? I need to get into the test realm and see what's up with those initialization errors.

Sorry bud, but, yes, shortly means today.

[spiel2001]

/sigh

So... that's gonna mean a raft of new support e-mails tonight.

I really did not expect that to go live so fast.

~grumble~

[Marthisdil]

Originally Posted by spiel2001 /sigh So... that's gonna mean a raft of new support e-mails tonight. I really did not expect that to go live so fast. ~grumble~

Been what, bout 3 weeks on the PTR, no? Seems to be about the usual schedule for the minor fix patches. 3.3.5 I would imagine would be a touch longer as it's adding new content. Not sure tho as it's only 1 mob!

[Xrystal]

And to add to that my brother told me that there are outstanding bugs on the version that weren't fixed before they reported going live. So yikes.