PLAYER_EQUIPMENT_CHANGED unequip / re-equip

[Walkerbo]

Hi all

I need to check a newly equipped items quality, if it is grey save the current equipment set including the new item, if the item is not grey I want to unequip all and then use the current equipment set.
To do this I track the PLAYER_EQUIPMENT_CHANGED event.
Here is my chunk;

elseif event == "PLAYER_EQUIPMENT_CHANGED" then
            local equipmentSlot = ...
            IronManSelectionFrame:UnregisterEvent("PLAYER_EQUIPMENT_CHANGED") -- unregister so we don't spam the test
            local isItemGrey, itemQuality = true, 99
            itemQuality = GetInventoryItemQuality("player", equipmentSlot)
            if itemQuality ~= 0 then -- if item is not grey
                isItemGrey = false
                removeAllEquipedItems()
            end
            if isItemGrey then
                for k, v in pairs(C_EquipmentSet.GetEquipmentSetIDs()) do
                    C_EquipmentSet.DeleteEquipmentSet(v) -- delete all equipment sets
                end
                C_EquipmentSet.CreateEquipmentSet("TESTING", 1035053) -- create new equipment set
            end
            C_EquipmentSet.UseEquipmentSet(0) -- use current equipment set
            print("PLAYER_EQUIPMENT_CHANGED Event Fired", equipmentSlot, isItemGrey, itemQuality) -- debug --
            IronManSelectionFrame:RegisterEvent("PLAYER_EQUIPMENT_CHANGED") -- re-register after test function

I unregister the PLAYER_EQUIPMENT_CHANGED at the start of the function so it doesn’t spam as the unequip re-equip will fire for each item.
He is my result:


Even though I unregister it still spams yet I cannot understand why, so I am looking for some help in understanding why it won't work, and why the equipment set doesn't update.

[Fizzlemizz]

The system returns the event when the thing happens. You've unregisterd and re-registered the event in a single process and requested x things to happen in between.

It's still processing equipment changes after you re-registered the event.

[Xrystal]

One of the ways I recall handling this type of recursive callback process in regular programming is to have a variable set when you start processing and then test for that for future calls.

So, something like the following may help, if you can't think of anything wowapi wise.

-- Addon wide variable ( at top of file ) 
local isProcessing = false

You might also need to reset this on a reload

And then in your event code

elseif event == "PLAYER_EQUIPMENT_CHANGED" then
     -- return out immediately if in the middle of an update
     if isProcessing then return end
 
     -- new update, so set processing flag
     isProcessing = true
 
    --------------------------------------------
    -- Rest of your code after this point 
   ---------------------------------------------
   
   -- finished processing so reset processing flag
   isProcessing = false
 
end

[Fizzlemizz]

Possibly use a table with the slots to process and remove them when the corresponding event comes in. Once empty, resume normal processing... something, something a cat...

[Walkerbo]

Thanks for the replies.

@Fizzlemizz, I was not sure what you meant here, I hived off the guts of my chunk into its own function that was called when the event fired without success.

@Xrystal, I like what you pointed out here, it triggered a previous issue I had in another addon, however it did not work here.

After playing a bit more I realised that I had overthought the issue, instead of removing all items I simply had to use the saved equipment set.

Here is my new chunk;

elseif event == "PLAYER_EQUIPMENT_CHANGED" then
            local equipmentSlot = ...
            IronManSelectionFrame:UnregisterEvent("PLAYER_EQUIPMENT_CHANGED") -- unregister so we don't spam the test
            local itemQuality = GetInventoryItemQuality("player", equipmentSlot)
            if itemQuality ~= 7 then -- if item is not grey
                C_EquipmentSet.UseEquipmentSet(0)
            else
                for k, v in pairs(C_EquipmentSet.GetEquipmentSetIDs()) do
                    C_EquipmentSet.DeleteEquipmentSet(v) -- delete all equipment sets
                end
                C_EquipmentSet.CreateEquipmentSet("TESTING", 1035053)
            end
            print("PLAYER_EQUIPMENT_CHANGED Event Fired", equipmentSlot, itemQuality) -- debug --
            IronManSelectionFrame:RegisterEvent("PLAYER_EQUIPMENT_CHANGED") -- re-register after test function

So the moral of this story is to follow the old KISS maxim.

Thanks for all the help.