oUF - ClassIcons

[jeAz_]

Let me apologize that I'm writing multiple threads within a short term

So, here's my new questions.

I was trying to create "ClassIcon Bar" with "ClassIcon" element.

However, there was few problems with this.

Have a look at the code first:

A.CreateClassIcons = function(f, unit)
    local _, Class = UnitClass(unit);
    local MaxPower;
    local ClassIcons = {};
    local ClassIconName = {
        Monk = "ChiOrb",
        Paladin = "HolyPower",
        Priest = "ShadowOrb",
        Warlock = "SoulShard",
    };
    local ClassIconColor = {
        Monk = {
            r = 0.52,
            g = 0.90,
            b = 0.50,
        },
 
        Paladin = {
            r = 1.00,
            g = 0.70,
            b = 0.85,
        },
 
        Priest = {
            r = 1.00,
            g = 1.00,
            b = 1.00,
        },
        Warlock = {
            r = 0.65,
            g = 0.40,
            b = 1.00,
        },
    };
 
    if (Class == "MONK") then
        MaxPower = UnitPowerMax(unit, SPELL_POWER_CHI);
    end
 
    local lowerClass = A.FirstToUpper(Class);
 
    for i = 1, 6 do
        local ClassIcon = CreateFrame("Frame", ("YUI_" .. ClassIconName[lowerClass] .. i), f);
    
        ClassIcon:SetBackdrop({
            bgFile = BACKDROP,
            tile = true,
            tileSize = 16,
        });
        ClassIcon:SetBackdropColor(0.1, 0.1, 0.1, 1);
        ClassIcon:SetWidth((G[unit]["width"] - (MaxPower - 1)) / MaxPower);
        ClassIcon:SetHeight(16);
 
        if i == 1 then
            ClassIcon:SetPoint("TOPLEFT", f, "BOTTOMLEFT", 0, -2);
        else
            ClassIcon:SetPoint("LEFT", ClassIcons[i - 1], "RIGHT", 1, 0);
        end
 
        local texture = ClassIcon:CreateTexture(nil, "OVERLAY");
        texture:SetTexture(COMBO_POINT);
        texture:SetVertexColor(ClassIconColor[lowerClass]["r"], ClassIconColor[lowerClass]["g"], ClassIconColor[lowerClass]["b"], 1);
        texture:SetWidth(ClassIcon:GetWidth() - 4);
        texture:SetHeight(ClassIcon:GetHeight() - 4);
        texture:SetPoint("CENTER");
 
        ClassIcon.texture = texture;
        ClassIcons[i] = ClassIcon;
    end
 
    f.ClassIcons = ClassIcons;
end

The first issue with this code is that when I enter the game, "UnitPowerMax(unit, SPELL_POWER_CHI)" returns 0 and only returns the proper value when I reload the game.

The next issue is that since I'm using my own textures for Chi, I have to update the size and position of icon if I select "Ascension (Monk Talent: 3/2)" which increases max number of chi by 1. However, it seems not working as I expected ...

Lastly, instead of utilizing default "ClassIcons" element, I was trying to create my own element module for each classes, Monk, Warlock, Priest and Paladin. So, I've attempted to interpret the original "ClassIcons" module, but as a newbie, it was pretty complex to understand what each function performs.

Could anyone please help me with interpreting this module

[zork]

I did my own classbars for oUF_Diablo. They can be found under modules.
https://github.com/zorker/rothui/tre...Diablo/modules

Example for Harmony:
https://github.com/zorker/rothui/blo...UF_Harmony.lua

On top of that make sure to check out the wow api changes for legion regarding that topic:
http://www.wowinterface.com/forums/s...ad.php?t=53140

Taking a look at rClassBars may help out aswell.
http://www.wowinterface.com/download...ClassBars.html

[jeAz_]

Originally Posted by zork I did my own classbars for oUF_Diablo. They can be found under modules. https://github.com/zorker/rothui/tre...Diablo/modules Example for Harmony: https://github.com/zorker/rothui/blo...UF_Harmony.lua On top of that make sure to check out the wow api changes for legion regarding that topic: http://www.wowinterface.com/forums/s...ad.php?t=53140 Taking a look at rClassBars may help out aswell. http://www.wowinterface.com/download...ClassBars.html

Hi zork,

Thank you for those nice references, and let me ask step by step.


About Default "classicon.lua":

1. On default oUF's default "classicon.lua" there is "PreUpdate" and "PostUpdate" functions. I understand when they are triggered, but ain't sure of what they actually process. Could you please explain me, if you know about them?


About your "oUF_Harmony.lua":

2. On your "oUF_Harmony.lua", it contains the following codes:

local w = 64*(max+2)
bar:SetWidth(w)
for i = 1, bar.maxOrbs do
  local orb = self.Harmony[i]
  if i > max then
     if orb:IsShown() then orb:Hide() end
  else
    if not orb:IsShown() then orb:Show() end
  end
end
for i = 1, max do
  local orb = self.Harmony[i]
  local full = num/max
  if(i <= num) then
    if full == 1 then
      orb.fill:SetVertexColor(1,0,0)
      orb.glow:SetVertexColor(1,0,0)
    else
      orb.fill:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
      orb.glow:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
    end
    orb.fill:Show()
    orb.glow:Show()
    orb.highlight:Show()
  else
    orb.fill:Hide()
    orb.glow:Hide()
    orb.highlight:Hide()
  end
end

If I'm going set the appearance of "Chi Orbs" outside of this module, do I still have to have

local w = 64*(max+2)
bar:SetWidth(w)

and

second "for" loop?

3. Where does "bar.maxOrbs" come from?

4. How does "ForceUpdate" and "Path" functions work?

5. On "ForceUpdate" function and "Enable" function, there is "element.__owner". Does "__" mean something special in Lua when you are indexing an element from table?




Please excuse me if I'm asking too many questions.

[zork]

1. Pre and Postupdate are hook functions. They let you manipulate values in case you need to do that to make the function process data correctly. Example you can change the color PostUpdate.
2. My chi bar has textures that are left and right of the orbs. Orbs number is dynamic depending on talents and what not. Thus I need to make sure that if the number of orbs changes the final bar still looks good. See 3.
3. My max orb value is hardcoded upon bar creation. That number could have been 10 or 100, but you know. The less frames you create the better.
https://github.com/zorker/rothui/blo.../bars.lua#L204
4. When the visibility changes a force update is needed to trigger the power update. You are right that I may have not needed the Path function but it gives you the ability to define a an Override function for a specific element. Like...you spawn 2 chi orb bars for example and want one to behave differently on update. That is where override is needed.
5. Nothing special. Just a prefix haste was using for the root element. (each bar is anchored to a root frame aka owner)

[jeAz_]

Originally Posted by zork 1. Pre and Postupdate are hook functions. They let you manipulate values in case you need to do that to make the function process data correctly. Example you can change the color PostUpdate. 2. My chi bar has textures that are left and right of the orbs. Orbs number is dynamic depending on talents and what not. Thus I need to make sure that if the number of orbs changes the final bar still looks good. See 3. 3. My max orb value is hardcoded upon bar creation. That number could have been 10 or 100, but you know. The less frames you create the better. https://github.com/zorker/rothui/blo.../bars.lua#L204 4. When the visibility changes a force update is needed to trigger the power update. You are right that I may have not needed the Path function but it gives you the ability to define a an Override function for a specific element. Like...you spawn 2 chi orb bars for example and want one to behave differently on update. That is where override is needed. 5. Nothing special. Just a prefix haste was using for the root element. (each bar is anchored to a root frame aka owner)

2. So, the purpose of following lines of code in "oUF_Harmony.lua":

local w = 64*(max+2)
bar:SetWidth(w)

and

for i = 1, max do
  local orb = self.Harmony[i]
  local full = num/max
  if(i <= num) then
    if full == 1 then
      orb.fill:SetVertexColor(1,0,0)
      orb.glow:SetVertexColor(1,0,0)
    else
      orb.fill:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
      orb.glow:SetVertexColor(bar.color.r,bar.color.g,bar.color.b)
    end
    orb.fill:Show()
    orb.glow:Show()
    orb.highlight:Show()
  else
    orb.fill:Hide()
    orb.glow:Hide()
    orb.highlight:Hide()
  end
end

is to re-size the bar's width when there is a update on talent or spec which affects the max number of chi.

Am I getting it right?


6. Also, I still don't get why I can't get a "UnitPowerMax("player", SPELL_POWER_CHI)" doesn't work on Player Login...

I have read through about Legion's API Change that you wrote, but since that is being applied from Legion, I don't think this issue is related to that yet.

7.(???) Did you make those textures by yourself?

They look so cool !!

[zork]

2. Yes
6. I had some issues with ouf element registration aswell. That is why I am doing nasty things like this
https://github.com/zorker/rothui/blo...armony.lua#L90
Not sure why the event is not firing properly for the element.
7. Yes, I made the textures myself in the process of creating Roth UI. Some of them are based on Blizzard art, some of them are made from scratch.