[Request] Mass Promote

[Caetan0]

Someone tell me if there is a way to promote au several members in accordance with the reputation he has with the guild?

Honorable = Rank 2
Respected = Rank 3

and so on.

I have a code that promotes according to the activity, do not know if it will help in any way.

/run for i=1,GetNumGuildMembers() do local name=GetGuildRosterInfo(i); if GetGuildRosterContribution(i) >= 3796304 and name ~= "Espartaco" then SetGuildMemberRank(i,5)end end

[Vlad]

There is no API to check the reputation standing with other players.

[Caetan0]

There is a way to check the score of the activity related to reputation?

[Taffu]

Not for other players. GetGuildFactionInfo does not allow indexing of roster information, it only returns 'your' information. So while you can get other players contribution in relation to the Guild, you cannot actually retrieve their faction tier (That I know of...)

[Caetan0]

I understand,
But is there any association between the "Guild Activity" and "Guild Reputation."

For example, if the player reaches 5k guild activity he upa reputation or something?

Or every 5 points of an activity point of reputation.

[Caetan0]

I got exactly what I was looking for, just need to make some adjustments.

How do I get this code does not encourage members who are at rank 2, rank 3 and rank 4?

/run for i=1,GetNumGuildMembers()do local _,_,a,b=GetGuildRosterInfo(i)if select(2,GetGuildRosterContribution(i))>=300000 and select(2,GetGuildRosterContribution(i))<= 320000 then SetGuildMemberRank(i,9)end end

[Caetan0]

I was looking yesterday morning and found all that will help me, so need to do a small fix in the code as it is not promoting anyone.

function PromoteFromGuild(aKk)
    if aKk and not CanGuildRemove() then
        return
    end
    for i = 1, GetNumGuildMembers() do
        local _, _, a, b = GetGuildRosterInfo(i)
        if rank >= 4 then
            local totalXP = GetGuildRosterContribution(i)
            if totalXP >= 1000000 then
                if aKk then
                    SetGuildMemberRank(i,5)
                end
            end
        end
    end
end
local frame = CreateFrame("Frame")
frame:RegisterEvent("GUILD_ROSTER_UPDATE")
frame:SetScript("OnEvent", function(self, event, ...)
   PromoteFromGuild(true)
end)

what is wrong?

[Phanx]

An easy way to figure out where your logic is failing would be to add some debug prints so you can follow what's going on:

function PromoteFromGuild(aKk)
    print("PromoteFromGuild", aKk)
    if aKk and not CanGuildRemove() then
        print("quit")
        return
    end
    for i = 1, GetNumGuildMembers() do
        local name, _, a, b = GetGuildRosterInfo(i)
        print(i, name, "rank", a, "level", b)
        if a >= 4 then
            local totalXP = GetGuildRosterContribution(i)
            print("totalXP:", totalXP)
            if totalXP >= 1000000 then
                if aKk then
                    print("SetGuildMemberRank", i, rank)
                    SetGuildMemberRank(i,5)
                end
            end
        end
    end
end

Depending on which messages do or do not appear, you can tell when something's happening that shouldn't be, or vice versa.

[Caetan0]

I used the code that gave me this error and returns.

Message: Interface\AddOns\Espartanos\Kick\Promover.lua:10: attempt to compare number with nil
Time: 01/20/12 13:33:32
Count: 2
Stack: Interface\AddOns\Espartanos\Kick\Promover.lua:10: in function `PromoteFromGuild'
Interface\AddOns\Espartanos\Kick\Promover.lua:25: in function <Interface\AddOns\Espartanos\Kick\Promover.lua:24>

Locals: aKk = true
(for index) = 1
(for limit) = 569
(for step) = 1
i = 1
name = "Shäke"
_ = "Soldado"
a = 9
b = 13
(*temporary) = nil
(*temporary) = 1
(*temporary) = "Shäke"
(*temporary) = "rank"
(*temporary) = 9
(*temporary) = "level"
(*temporary) = 13
(*temporary) = "attempt to compare number with nil"

[Phanx]

Typo, sorry. Change this:

if rank >= 4 then

to this:

if a >= 4 then

[Caetan0]

The addon is working perfectly, but he continues to promote members who are third in rank, rank 2 and rank 1.

Is there any way this addon does not promote members who are already at rank 5, rank 3, rank 2 and rank 1?

[Phanx]

Unless you made some additional change to the code I posted, it should not attempt to change the rank of players whose rank number is lower than 4 (so, it should not try to promote ranks 1, 2, or 3).

If you only want it to promote people whose current rank is below rank 5 (higher rank number, so rank 6+), simply change that part of the logic. Also, using descriptive variable names will help you see what to change in the future.

function PromoteFromGuild(reallyPromote)
    print("PromoteFromGuild", reallyPromote)
    if reallyPromote and not CanGuldPromote() then
        print("quit")
        return
    end
    for i = 1, GetNumGuildMembers() do
        local name, _, rank, level = GetGuildRosterInfo(i)
        print(i, name, "rank:", rank, "level:", level)
        --
        -- CHANGE THE NEXT LINE TO CHANGE WHICH RANKS ARE AFFECTED:
        if rank >= 5 then
            local totalXP = GetGuildRosterContribution(i)
            print("totalXP:", totalXP)
            if totalXP >= 1000000 then
                if reallyPromote then
                    print("SetGuildMemberRank", i, rank)
                    SetGuildMemberRank(i, 5)
                else
                    print("Would promote", name)
                end
            end
        end
    end
end

You should also be able to see exactly what it's trying to do by looking at the messages it prints in your chat frame when the function is run. If you want any more advice on why it's not doing what you want, you will need to post the messages it's printing, in the order it's printing them, and point out which lines you think are wrong.

[Caetan0]

I used the code you posted, but he keeps changing the rank of the members who are in category 5, 4, 3, 2 ​​and 1.

It seems that he is ignoring the command (if rank> = 5 then) or this command is not working.

[Phanx]

Originally Posted by Phanx If you want any more advice on why it's not doing what you want, you will need to post the messages it's printing, in the order it's printing them, and point out which lines you think are wrong.

^^^^^^^^^^