Quantcast
Am I understanding the 5.4.8 changes to CVars correctly? - WoWInterface
Thread Tools Display Modes
05-21-14, 03:14 AM   #1
karmamuscle
A Cobalt Mageweaver
 
karmamuscle's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2008
Posts: 205
Am I understanding the 5.4.8 changes to CVars correctly?

The listed changes are here http://eu.battle.net/wow/en/forum/topic/10494573844#1

Will this make auto toggling nameplates based on combat impossible?
Cause doing it manually is just a bloody waste of a keybind imo.
__________________
55 89 144 233 377 610 987 1597 2584 4181 6765
  Reply With Quote
05-21-14, 03:28 AM   #2
10leej
A Molten Giant
 
10leej's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2011
Posts: 579
http://us.battle.net/wow/en/forum/to...9697?page=3#46

Looks like no, you can still show nameplates on combat entry with SetUIVisibility(true)
__________________
Tweets Facebook YouTube Website
  Reply With Quote
05-21-14, 04:34 AM   #3
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,257
I'm assuming (EU so haven't tested) that the change means you can't change nameplate visibility in combat.
You could still do it on combat status changes.
Events for entering combat (used to?) fire right before combat lockdown goes in effect.
So in theory you should be able to respond to changes in combat status, just not make any changes after combat has started.
  Reply With Quote
05-21-14, 11:28 AM   #4
ravagernl
Proceritate Corporis
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 1,176
According to posters on the US forums, the client thinks you are in combat after all the event handlers registered to PLAYER_REGEN_DISABLED are handled.

http://us.battle.net/wow/en/forum/to...9697?page=1#10

This is still doable. Right now on the PTR (build 18224):
Code:
local f=CreateFrame("Frame")
f:SetScript("OnEvent",function(self,event)
 SetCVar("nameplateShowEnemies",event=="PLAYER_REGEN_DISABLED" and 1 or 0)
end)
f:RegisterEvent("PLAYER_REGEN_ENABLED")
f:RegisterEvent("PLAYER_REGEN_DISABLED")
will hide nameplates out of combat and show nameplates in combat.
OFFTOPIC: Am I right if this gnome is actually a very famous AddOn author here :P?

Last edited by ravagernl : 05-21-14 at 11:38 AM.
  Reply With Quote
05-21-14, 12:38 PM   #5
semlar
A Pyroguard Emberseer
 
semlar's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2007
Posts: 1,059
Originally Posted by ravagernl View Post
OFFTOPIC: Am I right if this gnome is actually a very famous AddOn author here :P?
I think (but I'm not positive) that Ro has an account on here named Gello.
  Reply With Quote
05-21-14, 07:24 PM   #6
Phanx
Cat.
 
Phanx's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2006
Posts: 5,617
Originally Posted by Dridzt View Post
I'm assuming (EU so haven't tested) that the change means you can't change nameplate visibility in combat.
You could still do it on combat status changes.
Events for entering combat (used to?) fire right before combat lockdown goes in effect.
So in theory you should be able to respond to changes in combat status, just not make any changes after combat has started.
Yep, this is how it's always worked. You can freely make changes when PLAYER_REGEN_DISABLED fires, including changes that are not allowed in combat like hiding secure frames, equipping items, and now modifying these particular cvars.

This change should not affect "auto toggle nameplates for combat" addons at all.
__________________
Author/maintainer of Grid, PhanxChat, oUF_Phanx, and many more.
Troubleshoot an addonTurn any code into an addonMore addon resources
Need help with your code? Post all of your actual code! Attach or paste your files.
Please don’t PM me about addon bugs or code questions. Post a comment or forum thread instead!
  Reply With Quote
05-22-14, 09:56 AM   #7
ravagernl
Proceritate Corporis
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 1,176
Originally Posted by semlar View Post
I think (but I'm not positive) that Ro has an account on here named Gello.
I was thinking the same thing but I didn't want to make the link because of possible privacy issues some authors have
  Reply With Quote
05-22-14, 02:12 PM   #8
10leej
A Molten Giant
 
10leej's Avatar
AddOn Author - Click to view addons
Join Date: Feb 2011
Posts: 579
Originally Posted by ravagernl View Post
I was thinking the same thing but I didn't want to make the link because of possible privacy issues some authors have
Gello is Ro, he confirmed that with me back when I used Adapt with BobUI plus it's not that hard to figure out who he ius cause just about every other addon he makes he posts on the official forums.

Well except PlusNothing which I maintain for him.
__________________
Tweets Facebook YouTube Website

Last edited by 10leej : 05-22-14 at 02:14 PM.
  Reply With Quote

WoWInterface » General Discussion » General WoW Chat » Am I understanding the 5.4.8 changes to CVars correctly?

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off