Right-Click Unit Menu in raids bugged?

maltese · 10-23-10, 05:25 PM

Just curious if something has changed with wow 4.0.1 to make the rightclick unit menu not work properly in raids using oUF?

I've gone through almost every single layout posted and they all pretty much read:

Code:

	local unit = self.unit:sub(1, -2)
	local cunit = self.unit:gsub("^%l", string.upper)

	if(cunit == "Vehicle") then
		cunit = "Pet"
	end

	if(unit == "party") then
		ToggleDropDownMenu(1, nil, _G["PartyMemberFrame"..self.id.."DropDown"], "cursor", 0, 0)
	elseif(_G[cunit.."FrameDropDown"]) then
		ToggleDropDownMenu(1, nil, _G[cunit.."FrameDropDown"], "cursor", 0, 0)
	elseif unit == "raid" then
		FriendsDropDown.unit = self.unit
		FriendsDropDown.id = self.id
		FriendsDropDown.initialize = RaidFrameDropDown_Initialize
		ToggleDropDownMenu(1,nil,FriendsDropDown,"cursor")	
	end

That code works perfectly fine solo and in parties but the second you join a raid you lose pretty much all functionality of the right click menu. You can't set raid icons or roles from it anymore...etc.

Any ideas on getting the full raid menu to work?

Phanx · 10-23-10, 06:43 PM

Try using CompactUnitFrameDropDown_Initialize instead of RaidFrameDropDown_Initialize? I don't think the old-style raid frames are still used, so Blizzard probably just didn't bother adding any of the new stuff (role checks, etc.) to them.

maltese · 10-23-10, 07:49 PM

Just tried CompactUnitFrameDropDown_Initialize and right click produces no menus at all.

If it helps tracking down the issue, if I change

Code:

if(unit == "party") then
		ToggleDropDownMenu(1, nil, _G["PartyMemberFrame"..self.id.."DropDown"], "cursor", 0, 0)

to

Code:

if(unit == "party") or (unit == "raid") then
		ToggleDropDownMenu(1, nil, _G["PartyMemberFrame"..self.id.."DropDown"], "cursor", 0, 0)

and commenting out the elseif unit == "raid" section

Produces the correct menu on raid frames, but only works on the first person in the first group. Every other raid member gives a "You have no target" error on right click and on the menu where the players name would be, shows Unknown.

Phanx · 10-23-10, 08:02 PM

Try this:

Code:

	local unit = self.unit:sub(1, -2)
	if unit == "party" then
		ToggleDropDownMenu(1, nil, _G["PartyMemberFrame"..self.id.."DropDown"], "cursor", 0, 0)
	elseif unit == "raid" then
		local menu, id, name
		if UnitIsUnit(unit, "player") then
			menu = "SELF"
		elseif UnitIsUnit(unit, "vehicle") then
			menu = "VEHICLE"
		elseif UnitIsUnit(unit, "pet") then
			menu = "PET"
		elseif UnitIsPlayer(unit) then
			id = UnitInRaid(unit)
			if id then
				menu = "RAID_PLAYER"
				name = GetRaidRosterInfo(id)
			elseif UnitInParty(unit) then
				menu = "PARTY"
			else
				menu = "PLAYER"
			end
		else
			menu = "TARGET"
			name = RAID_TARGET_ICON
		end
		if menu then
			UnitPopup_ShowMenu(self, menu, self.unit, name, id)
		end
	else
		local cunit = self.unit:gsub("^%l", string.upper)
		if cunit == "Vehicle" then
			cunit = "Pet"
		end
		if _G[cunit.."FrameDropDown"] then
			ToggleDropDownMenu(1, nil, _G[cunit.."FrameDropDown"], "cursor", 0, 0)
		end
	end

Basically copied the contents of CompactUnitFrameDropDown_Initialize, cleaned up Blizzard's legions of unnecessary parentheses and semicolons, and removed the parent.unit check that was most likely causing calling the original function to fail.

maltese · 10-23-10, 08:33 PM

Works... sortof. The good news is that Player, Target, Focus and Party right click all still work with that code.

Raid frames sadly still do not.

Code:

Message: Interface\FrameXML\UnitPopup.lua:502: bad argument #1 to 'ipairs' (table expected, got nil)
Time: 10/23/10 22:30:42
Count: 2
Stack: [C]: in function `ipairs'
Interface\FrameXML\UnitPopup.lua:502: in function `UnitPopup_HideButtons'
Interface\FrameXML\UnitPopup.lua:219: in function `UnitPopup_ShowMenu'
Interface\AddOns\oUF_Drk\lib.lua:79: in function `handler'
Interface\FrameXML\SecureTemplates.lua:540: in function <Interface\FrameXML\SecureTemplates.lua:488>

Locals: (*temporary) = nil
(*temporary) = "table expected, got nil"
 = <function> defined =[C]:-1

Thanks for helping with this btw

Phanx · 10-23-10, 08:40 PM

Try changing:

Code:

UnitPopup_ShowMenu(self, menu, unit, name, id)

To:

Code:

UnitPopup_ShowMenu(self, menu, self.unit, name, id)

maltese · 10-23-10, 08:43 PM

changed and got the same exact error. Line 79 in lib.lua is the line that you just had me change for reference

Phanx · 10-23-10, 09:59 PM

Hmm, I found another problem. I'm at work, so I can't actually test anything. Try this:

Code:

	local unit = self.unit
	local unitType = unit:sub(1, -2)
	if unitType == "party" then
		ToggleDropDownMenu(1, nil, _G["PartyMemberFrame" .. self.id .. "DropDown"], "cursor", 0, 0)
	elseif unitType == "raid" then
		local which, name, id
		if UnitIsUnit(unit, "player") then
			which = "SELF"
		elseif UnitIsUnit(unit, "vehicle") then
			which = "VEHICLE"
		elseif UnitIsUnit(unit, "pet") then
			which = "PET"
		elseif UnitIsPlayer(unit) then
			id = UnitInRaid(unit)
			if id then
				which = "RAID_PLAYER"
				name = GetRaidRosterInfo(id)
			elseif UnitInParty(unit) then
				which = "PARTY"
			else
				which = "PLAYER"
			end
		else
			which = "TARGET"
			name = RAID_TARGET_ICON
		end
		if menu then
			UnitPopup_ShowMenu(self, which, unit, name, id)
		end
	else
		local cunit = unit:gsub("^%l", string.upper)
		if cunit == "Vehicle" then
			cunit = "Pet"
		end
		local dropdown = _G[cunit .. "FrameDropDown"]
		if dropdown then
			ToggleDropDownMenu(1, nil, dropdown, "cursor", 0, 0)
		end
	end

maltese · 10-24-10, 04:56 AM

Changed to that and it produces no menu or errors in a raid. I was in a hurry and no guildmates were online at the time so I just joined a battleground. Not sure if that would make a difference but I'll check again when I'm off work myself.

maltese · 10-25-10, 08:08 PM

confirmed, there is no menu in BG's or in a raid on right click.

maltese · 11-04-10, 01:23 PM

I hate to bump posts, but I'm curious if anyone has figured out the right click raid frames issue.

Phanx · 11-05-10, 07:45 AM

In the main chunk:

Code:

local dropdown = CreateFrame("Frame", "MyAddOnUnitDropDownMenu", UIParent, "UIDropDownMenuTemplate")

UIDropDownMenu_Initialize(dropdown, function(self)
	local unit = self:GetParent().unit
	if not unit then return end

	local menu, name, id
	if UnitIsUnit(unit, "player") then
		menu = "SELF"
	elseif UnitIsUnit(unit, "vehicle") then
		menu = "VEHICLE"
	elseif UnitIsUnit(unit, "pet") then
		menu = "PET"
	elseif UnitIsPlayer(unit) then
		id = UnitInRaid(unit)
		if id then
			menu = "RAID_PLAYER"
			name = GetRaidRosterInfo(id)
		elseif UnitInParty(unit) then
			menu = "PARTY"
		else
			menu = "PLAYER"
		end
	else
		menu = "TARGET"
		name = RAID_TARGET_ICON
	end
	if menu then
		UnitPopup_ShowMenu(self, menu, unit, name, id)
	end
end, "MENU")

local menu = function(self)
	dropdown:SetParent(self)
	ToggleDropDownMenu(1, nil, dropdown, "cursor", 0, 0)
end

And in the function where your frame is created/configured (your layout's spawn function if you're using oUF):

Code:

	frame.menu = menu
	frame:SetAttribute("*type2", "menu")

maltese · 11-05-10, 08:36 AM

This is definitely producing the menu I need, the only issue is when I right click on raid frames the menu pops up and almost instantly disappears. That issue does not affect any other frame (target, ToT, self, etc)

I inserted the first section of code like you said and then had to modify the second set slightly to get it to work, is this where the problem is? Its strange because the menu is popping up, but milliseconds later disappears.

Code:

-- The Shared Style Function
local GlobalStyle = function(self, unit, isSingle)

	self.menu = menu
	self:SetAttribute("*type2", "menu")
	self:RegisterForClicks('AnyDown')
	
	-- Call Unit Specific Styles
	if(UnitSpecific[unit]) then
		return UnitSpecific[unit](self)
	end
end

-- The Shared Style Function for Party and Raid
local GroupGlobalStyle = function(self, unit)

	self.menu = menu
	self:SetAttribute("*type2", "menu")
	self:RegisterForClicks('AnyDown')
	
	-- Call Unit Specific Styles
	if(UnitSpecific[unit]) then
		return UnitSpecific[unit](self)
	end
end

yj589794 · 11-05-10, 09:42 AM

Any frames created by header in oUF will reset many times per second. This is due to a bug in Blizzards handling of the headers.
This is the same bug that causes portraits to constantly flicker and reset on header units, and other weird stuff to occur (e.g. clicks can be lost).

This issue is fixed on the Beta and will, eventually, be fixed on the live servers.

Zúl · 11-06-10, 06:04 AM

Originally Posted by yj589794

Any frames created by header in oUF will reset many times per second. This is due to a bug in Blizzards handling of the headers.
This is the same bug that causes portraits to constantly flicker and reset on header units, and other weird stuff to occur (e.g. clicks can be lost).

This issue is fixed on the Beta and will, eventually, be fixed on the live servers.

Is there anything one can do, to fix this for live servers? Because i want to develop my addon but i dont have beta access. And it sucks not being able to use OnShow and OnHide.

haste · 11-06-10, 07:35 AM

Originally Posted by Zúl

Is there anything one can do, to fix this for live servers? Because i want to develop my addon but i dont have beta access. And it sucks not being able to use OnShow and OnHide.

You can test it on PTR, the changes are applied there. Another solution is to not use the visibility system on live (third argument to :SpawnHeader).

Zúl · 11-06-10, 09:33 AM

Originally Posted by haste

You can test it on PTR

Cool just downloading the PTR client

zork · 11-19-10, 06:32 PM

Has anyone a working raid menu that allows setting of roles?

Phanx · 11-19-10, 07:03 PM

Does the code from my last post not work to set roles? I'm not actually using it, but when I tested it, the "Set Role" submenu definitely showed up.

zork · 11-19-10, 08:42 PM

Thx phanx. Works perfect.