Dropdown Checkbox won't uncheck

[Geebles]

I'm trying toggle a drop-down menu checkbox, but isn't working. I've managed to get it to go from no check to being checked, but then it won't uncheck again visually.


the menu item...

menu2 = {};
menu2.text = "Movable";
menu2.func = function () MenuMoveClick(this); end
menu2.checked = vMovable;

the function...

function MenuMoveClick(obj)
	if(vMovable==1) then
		vMovable=0;
	else
		vMovable=1;
	end
end

Any idea why it won't un-check again?

[Torhal]

Is vMovable an upvalue, or is it re-defined every time your menu function is being called? If the latter, that would be causing the issue.

You can also simplify your MenuMoveClick() function as so:

local function MenuMoveClick()
        vMovable = not vMovable
end

...and then, in your menu function:

menu2.func = MenuMoveClick

This calls MenuMoveClick without defining a closure. I see no reason to be passing obj as an argument, since you are never checking the state of obj when toggling the vMovable value.

Also, for efficiency's sake, you should be re-using an upvalued table for every menu level. At the moment, you're making a new table for every menu every time your function is called - this will incur unnecessary garbage collection.

[Geebles]

I'm not sure what an 'upvalue' is

I tried those suggestions, but either messed it up or because I didn't post the whole code, it didn't work.
It did help me get it working though. I think the problem was not setting the variable vMovable at the beginning of the page (outside of the functions) so it wasn't being maintained.

[Torhal]

That's an upvalue.