Unstable Memory Usage

[laukond]

What causes unstable memory usage?
If I /run collectgarbage() the memory halved!

PS: here it is if you care to look, but I warn you it's very long and cluttery.
http://pastebin.com/ygj4zqcj

Have a good day.

Edit: I have split the AddOn into multiple AddOns to locate the sinners . Here are two links to the unstable AddOns:
* http://pastebin.com/wKVjaK0g
* http://pastebin.com/3KmAtVXE

[Waky]

Just looking quickly, I'd say that this part of your code is generating a lot of garbage every time you call it:

if (KeybindsHide == 1) then
for i=1,12 do _G["ActionButton"..i.."HotKey"]:SetAlpha(0)end;for i=1,12 do
_G["MultiBarBottomRightButton"..i.."HotKey"]:SetAlpha(0)end;for i=1,12 do
_G["MultiBarBottomLeftButton"..i.."HotKey"]:SetAlpha(0)end; for i=1,12 do
_G["MultiBarRightButton"..i.."HotKey"]:SetAlpha(0)end; for i=1,12 do
_G["MultiBarLeftButton"..i.."HotKey"]:SetAlpha(0)end; for i=1,12 do
_G["BonusActionButton"..i.."HotKey"]:SetAlpha(0)end;
end
 
if (MacroTextHide == 1) then
for i=1,12 do _G["ActionButton"..i.."Name"]:SetAlpha(0)end;for i=1,12 do
_G["MultiBarBottomRightButton"..i.."Name"]:SetAlpha(0)end;for i=1,12 do
_G["MultiBarBottomLeftButton"..i.."Name"]:SetAlpha(0)end; for i=1,12 do
_G["MultiBarRightButton"..i.."Name"]:SetAlpha(0)end; for i=1,12 do
_G["MultiBarLeftButton"..i.."Name"]:SetAlpha(0)end; for i=1,12 do
_G["BonusActionButton"..i.."Name"]:SetAlpha(0)end;
end

Every time this is called it finds 144 frames then throws away their name. You might want to just do it once and store all of the frames in a table, then iterate over that table every time.

Looking a little farther down, it seems this is how you call most of your _G frames. Like I said before, I'd save them once then use the saved value so you don't generate garbage every time you call the function.

[laukond]

Thank you very much for the quick reply :-)
Could you just link an example of you you would do it? Just the frame of it so I know what you mean, afterall I am new to Lua.

[Waky]

This is just an example for one of the buttons:

local actionButtonHotkey= {}
-- Just creating a blank table for just ActionButtonHotKey's

for i=1,12 do
   actionButtonHotkey[i] = _G[format("ActionButton%dHotKey",i)];
end
-- Iterate over 1 through 12 and store all of these frames into the blank table we created earlier

The above should only be ran once, as to fill up the table

The following would be what you do to for your :SetAlpha(0) function:

for k,v in pairs(actionButtonHotkey) do
   v:SetAlpha(0);
end

This way it would just go over the table every time and just reuse the previously saved frame

[laukond]

Playing with a thought here, but I'm not sure which word to use by the "elseif" (line 11), the hotkey hiding works, but the macro part doesn't.

local macrohide = 1
local hotkeyhide = 1
 
local actionButtonHotkey = {}
-- Just creating a blank table for just ActionButtonHotKeys
 
if (hotkeyhide == 1) then
    for i=1,12 do
    actionButtonHotkey[i] = _G[format("ActionButton%dHotKey",i)]; 
    end
        elseif (macrohide == 1) then
        for i=1,12 do
        actionButtonHotkey[i] = _G[format("ActionButton%dName",i)];
    end
end
 
-- Iterate over 1 through 12 and store all of these frames into the blank table we created earlier
 
for k,v in pairs(actionButtonHotkey) do
   v:SetAlpha(0);
end

Bonus question off-topic: Which program do you use for writing such code?

[Waky]

The elseif syntax will make it so the second part of the code will only run if the previous if condition wasn't met.

So say you have
x = 5;
y = 10;

then you have such code:

if (x==5) then
   print("x was 5");
elseif (y==10) then
   print("y was 10");
end

Even though the second if "(y==10)" was true the code was never reached since the first if statement was met when x equaled 5. The code would then print "x was 5" and then stop in that condition.

From what I understand you're trying to do 2 if statements like such:

if (hotkeyhide == 1) then
    for i=1,12 do
         actionButtonHotkey[i] = _G[format("ActionButton%dHotKey",i)]; 
    end
end
if (macrohide == 1) then
    for i=1,12 do
        actionButtonHotkey[i] = _G[format("ActionButton%dName",i)];
    end
end

[Saiket]

Usually the biggest contributor to increasing memory is temporary table creation. There are three places in your code that create tables each time they run:

1. Line 697:

   local TabZone = {
                   ["pvp"] = true,
                   ["arena"] = true,
           }

2. Line 724:

   local TabZone = {
                   ["pvp"] = true,
                   ["arena"] = true,
           }

3. Line 1221:

   table.insert(AddOnData,{GetAddOnInfo(i),mem});

Since the first two tables never change and are identical, you could create one copy of the table before defining tabChanger:ZONE_CHANGED_NEW_AREA and MinimapHide:ZONE_CHANGED_NEW_AREA. That way they'll use the one copy each time they're called as opposed to creating new copies of it every time you change zones.

The third table is probably what causes lots of garbage memory though, since it creates a new table for each addon every time it runs. There are a number of ways to fix it, but I suggest reading this Wowpedia article on avoiding garbage tables.

[laukond]

Originally Posted by Waky This is just an example for one of the buttons

How would I apply this to all the bars?

[laukond]

Edit: I have split the AddOn into multiple AddOns to locate the sinners . Here are two links to the unstable AddOns:
* http://pastebin.com/wKVjaK0g
* http://pastebin.com/3KmAtVXE

[laukond]

Originally Posted by Saiket There are a number of ways to fix it.

Thank you for your reply . I read the but I did not understand most of it, since I am quite new to Lua .
Would you mind coding me a solution to it?

[Saiket]

Originally Posted by laukond Thank you for your reply . I read the but I did not understand most of it, since I am quite new to Lua . Would you mind coding me a solution to it?

You're storing a two-dimensional array of addon data with one table per addon, each with two elements in it. You could store the same data using only two recycled tables instead, each with one element per addon. The sort function would have to change slightly, but you'll only ever create two tables this way:

local AddOnMemory, Order={}, {};
local function SortByMemory(addon1,addon2)
    return AddOnMemory[addon1]<AddOnMemory[addon2]
end

And then in MainMenuBarPerformanceBarFrame_OnEnter:

--[[    Custom Code ]]
--  Replace memory code with our own
    UpdateAddOnMemoryUsage();
    table.wipe(AddOnMemory);
    table.wipe(Order);
    local total=0;
 
    for i=1,GetNumAddOns() do
        AddOnMemory[i]=GetAddOnMemoryUsage(i);
        Order[i]=i;
        total=total+AddOnMemory[i];
    end
    table.sort(Order,SortByMemory);
 
    if total>0 then
        GameTooltip:AddLine(" ");
        if total>1000 then
            AddNewbieTip(GameTooltip,TOTAL_MEM_MB_ABBR:format(total/1000),1,1,1,NEWBIE_TOOLTIP_MEMORY);
        else
            AddNewbieTip(GameTooltip,TOTAL_MEM_KB_ABBR:format(total),1,1,1,NEWBIE_TOOLTIP_MEMORY);
        end
 
        for i,addon in ipairs(Order) do
            local mem,name=AddOnMemory[addon],GetAddOnInfo(addon)
            if mem>0 then
                if mem>1000 then
                    GameTooltip:AddLine(ADDON_MEM_MB_ABBR:format(mem/1000,name),1,1,1);
                else
                    GameTooltip:AddLine(ADDON_MEM_KB_ABBR:format(mem,name),1,1,1);
                end
            end
            if i>=MaxListSize then break; end
        end
    end