Real time update

Hubb777 · 04-06-24, 09:25 AM

Hi all. Currently, the data on questIDs = {70893, 71995} is updated only after an “interface reboot” or if I re-enter the game as a character. How to make the data updated immediately without having to enter “/reload”. ?

Lua Code:

local addonName, addon = ...
local frame = CreateFrame("Frame", "QuestCompletionFrame", UIParent)
frame:SetSize(100, 100)
frame:SetPoint("CENTER")
frame:EnableMouse(true)
frame:SetMovable(true)
frame:RegisterForDrag("LeftButton")
frame:SetScript("OnDragStart", frame.StartMoving)
frame:SetScript("OnDragStop", frame.StopMovingOrSizing)
 
local text = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
text:SetPoint("CENTER")
 
local localization = {
    ["enUS"] = {
        ["quest70893"] = "|cFFDEB887Community Feast:|r",
        ["quest71995"] = "|cFFDEB887Trial of the Elements:|r",
        ["yes"] = "|cFF1EFF00Complete|r",
        ["no"] = "|cFFDC143CIncomplete|r"
    }
}
 
local function UpdateQuestCompletion()
    local completedQuests = {}
    local questIDs = {70893, 71995}
 
    for _, questID in ipairs(questIDs) do
        local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)
        completedQuests[questID] = isCompleted
    end
 
    local locale = GetLocale()
    local locStrings = localization[locale] or localization["enUS"]
 
    local questStatus = locStrings["quest70893"] .. " "
    if completedQuests[70893] then
        questStatus = questStatus .. locStrings["yes"]
    else
        questStatus = questStatus .. locStrings["no"]
    end
 
    questStatus = questStatus .. "\n" .. locStrings["quest71995"] .. " "
    if completedQuests[71995] then
        questStatus = questStatus .. locStrings["yes"]
    else
        questStatus = questStatus .. locStrings["no"]
    end
 
    text:SetText(questStatus)
end
 
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        UpdateQuestCompletion()
    end
end)
 
frame:RegisterEvent("PLAYER_LOGIN")
 
SLASH_ZAM1 = "/zam"
SlashCmdList["ZAM"] = function(msg)
    if strupper(strtrim(msg)) == "MT" then -- toggle the shown state of the button if the type /hubb btn
        QuestCompletionFrame:SetShown(not QuestCompletionFrame:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    QuestCompletionFrame:Show()
end

Xrystal · 04-06-24, 10:29 AM

You could use the update function for the frame - you've used that in the past for other projects if memory serves.

I personally identify an event that would trigger for it and use that, and only fall back to the OnUpdate frame function if there are no alternatives.

I notice you aren't using the QUEST_COMPLETE (https://warcraft.wiki.gg/wiki/QUEST_COMPLETE) which triggers when the player presses the complete button.

There is also QUEST_TURNED_IN ( https://warcraft.wiki.gg/wiki/QUEST_TURNED_IN ) which might prove useful as well as QUEST_FINISHED (https://warcraft.wiki.gg/wiki/QUEST_FINISHED).

Give those a go and see if they do what you need. If all else fails, you can do your updates via the OnUpdate routine as mentioned. Assuming you have a frame that handles all this stuff for you.

Tim · 04-06-24, 07:01 PM

Originally Posted by Hubb777

Hi all. Currently, the data on questIDs = {70893, 71995} is updated only after an “interface reboot” or if I re-enter the game as a character. How to make the data updated immediately without having to enter “/reload”. ?

The reason for that is, that's how you have it setup.

I would take a look at the events for Quest Log stuff.

https://warcraft.wiki.gg/wiki/Events#C_QuestLog

Hubb777 · 04-07-24, 04:32 AM

I did this, but still the update is not in real time

Lua Code:

local addonName, addon = ...
local frame = CreateFrame("Frame", "QuestCompletionFrame", UIParent)
frame:SetSize(100, 100)
frame:SetPoint("CENTER")
frame:EnableMouse(true)
frame:SetMovable(true)
frame:RegisterForDrag("LeftButton")
frame:SetScript("OnDragStart", frame.StartMoving)
frame:SetScript("OnDragStop", frame.StopMovingOrSizing)
 
local text = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
text:SetPoint("CENTER")
 
local localization = {
    ["enUS"] = {
        ["quest70893"] = "|cFFDEB887Community Feast:|r",
        ["quest71995"] = "|cFFDEB887Trial of the Elements:|r",
        ["yes"] = "|cFF1EFF00Complete|r",
        ["no"] = "|cFFDC143CIncomplete|r"
    }
}
 
local function UpdateQuestCompletion()
    local completedQuests = {}
    local questIDs = {70893, 71995}
 
    for _, questID in ipairs(questIDs) do
        local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)
        completedQuests[questID] = isCompleted
    end
 
    local locale = GetLocale()
    local locStrings = localization[locale] or localization["enUS"]
 
    local questStatus = locStrings["quest70893"] .. " "
    if completedQuests[70893] then
        questStatus = questStatus .. locStrings["yes"]
    else
        questStatus = questStatus .. locStrings["no"]
    end
 
    questStatus = questStatus .. "\n" .. locStrings["quest71995"] .. " "
    if completedQuests[71995] then
        questStatus = questStatus .. locStrings["yes"]
    else
        questStatus = questStatus .. locStrings["no"]
    end
 
    text:SetText(questStatus)
end
 
local function OnEvent(self, event, ...)
    if event == "PLAYER_LOGIN" or (event == "QUEST_TURNED_IN" and (... == 70893 or ... == 71995)) then
        UpdateQuestCompletion()
    end
end
 
local function OnUpdate(self, elapsed)
    -- Perform any update logic here
end
 
frame:SetScript("OnEvent", OnEvent)
frame:SetScript("OnUpdate", OnUpdate) -- Add the OnUpdate script
frame:RegisterEvent("PLAYER_LOGIN")
frame:RegisterEvent("QUEST_TURNED_IN")
 
SLASH_ZAM1 = "/zam"
SlashCmdList["ZAM"] = function(msg)
    if strupper(strtrim(msg)) == "MT" then -- toggle the shown state of the button if the type /hubb btn
        QuestCompletionFrame:SetShown(not QuestCompletionFrame:IsShown()) -- show the button
        return
    end
    updateData()
    updateList()
    QuestCompletionFrame:Show()
end

Xrystal · 04-07-24, 06:51 AM

Did you check to make sure that the event triggered when you clicked on the complete button for the quest ?

It is also possible that the IsQuestFlaggedCompleted function doesn't know about the just completed quest yet. If that is the case, the only thing you can do is use the OnUpdate function and put a timed check in there to periodically check if it is marked as complete yet.

Let me check with one of my test toons and see if a simple test works as I expect it to.

Okay.. I just tested with this small piece of code.

Lua Code:

local addonName, addonNS = ...
 
Quests_Completed = Quests_Completed or {}
 
local function QuestTurnedIn(...)    
    local questID, xpReward, moneyReward = ...    
    local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)   -- Returns true    
    print("Quest: ", questID,"XP: ", xpReward,"Money: ", moneyReward,"Completed: ",isCompleted)    
    Quests_Completed[questID].Completed = isCompleted
end
 
local function QuestAccepted(...)
    local questID = ...
    local questLogIndex = C_QuestLog.GetLogIndexForQuestID(questID)
    local info = { C_QuestLog.GetInfo(questLogIndex) }
    print("Accepted Quest: ", questID, info["title"])    
    Quests_Completed[questID] = info                
end
 
local frame = CreateFrame("Frame")
frame:RegisterEvent("QUEST_TURNED_IN")
frame:RegisterEvent("QUEST_ACCEPTED")
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "QUEST_TURNED_IN" then
        -- Triggers when pressing Complete Button
        QuestTurnedIn(...)
    elseif event == "QUEST_ACCEPTED" then
        -- Triggers before Pressing Accept Button
        QuestAccepted(...)
    end
end)

It worked as expected with the addon recognising that a quest had been turned in as it was turned in and marked it as completed immediately. The only slight error on my part was trying to display info.title instead of info["title"] on the screen.

It might be that the quests you are looking into in particular are working differently. Try separating the event tests and see whether the QUEST_TURNED_IN functionality kicks in correctly.

The saved variables show that on QUEST_ACCEPTED all of the information was available and on QUEST_TURNED_IN it knew it had been completed. In this example, the first alliance human quest was completed with the second accepted but not completed.

Lua Code:

Quests_Completed = {
    [28757] = {
        {
            ["difficultyLevel"] = 1,
            ["useMinimalHeader"] = false,
            ["isHeader"] = false,
            ["questLogIndex"] = 2,
            ["level"] = 1,
            ["isOnMap"] = false,
            ["isTask"] = false,
            ["isHidden"] = false,
            ["overridesSortOrder"] = false,
            ["isInternalOnly"] = false,
            ["isCollapsed"] = true,
            ["startEvent"] = false,
            ["questID"] = 28757,
            ["suggestedGroup"] = 0,
            ["isBounty"] = false,
            ["readyForTranslation"] = true,
            ["isLegendarySort"] = false,
            ["title"] = "Beating Them Back!",
            ["isAutoComplete"] = false,
            ["isStory"] = false,
            ["hasLocalPOI"] = false,
            ["isScaling"] = true,
            ["frequency"] = 0,
        }, -- [1]
        ["Completed"] = true,
    },
    [28769] = {
        {
            ["difficultyLevel"] = 2,
            ["useMinimalHeader"] = false,
            ["isHeader"] = false,
            ["questLogIndex"] = 2,
            ["level"] = 2,
            ["isOnMap"] = false,
            ["isTask"] = false,
            ["isHidden"] = false,
            ["overridesSortOrder"] = false,
            ["isInternalOnly"] = false,
            ["isCollapsed"] = true,
            ["startEvent"] = false,
            ["questID"] = 28769,
            ["suggestedGroup"] = 0,
            ["isBounty"] = false,
            ["readyForTranslation"] = true,
            ["isLegendarySort"] = false,
            ["title"] = "Lions for Lambs",
            ["isAutoComplete"] = false,
            ["isStory"] = false,
            ["hasLocalPOI"] = false,
            ["isScaling"] = true,
            ["frequency"] = 0,
        }, -- [1]
    },
}

Xrystal · 04-07-24, 07:42 AM

Also, you could forego on the localization of the quest name as you could use the following :

C_QuestLog.GetTitleForQuestID(questID)

https://warcraft.wiki.gg/wiki/API_C_...itleForQuestID - Includes Example Code

Or a combination of :
C_QuestLog.RequestLoadQuestByID(questID) and monitoring QUEST_DATA_LOAD_RESULT event for quest data access if it wasn't available before.

https://warcraft.wiki.gg/wiki/API_C_...tLoadQuestByID
https://warcraft.wiki.gg/wiki/QUEST_DATA_LOAD_RESULT

Or like I did, use the QUEST_ACCEPTED part to access the quest info at the point it becomes available to you. It all depends on how your addon is supposed to work.

I would suspect that the name of the quest would be automatically localized - similar to spell names and professions etc.

Hubb777 · 04-08-24, 04:07 AM

I tried combining my code with yours. But it still doesn't work.

Lua Code:

local addonName, addon = ...
local frame = CreateFrame("Frame", "QuestCompletionFrame", UIParent)
frame:SetSize(100, 100)
frame:SetPoint("CENTER")
frame:EnableMouse(true)
frame:SetMovable(true)
frame:RegisterForDrag("LeftButton")
frame:SetScript("OnDragStart", frame.StartMoving)
frame:SetScript("OnDragStop", frame.StopMovingOrSizing)
 
local text = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
text:SetPoint("CENTER")
 
local Quests_Completed = Quests_Completed or {}
 
local function QuestTurnedIn(...)
    local questID, xpReward, moneyReward = ...
    local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)   -- Returns true
    print("Quest: ", questID,"XP: ", xpReward,"Money: ", moneyReward,"Completed: ",isCompleted)
    Quests_Completed[questID].Completed = isCompleted
end
 
local function QuestAccepted(...)
    local questID = ...
    local questLogIndex = C_QuestLog.GetLogIndexForQuestID(questID)
    local info = { C_QuestLog.GetInfo(questLogIndex) }
    print("Accepted Quest: ", questID, info["title"])
    Quests_Completed[questID] = info
end
 
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        local completedQuests = {}
        local questIDs = {70893, 71995}
 
        for _, questID in ipairs(questIDs) do
            local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)
            completedQuests[questID] = isCompleted
        end
 
        local localization = {
            ["enUS"] = {
                ["quest70893"] = "|cFFDEB887Community Feast:|r",
                ["quest71995"] = "|cFFDEB887Trial of the Elements:|r",
                ["yes"] = "|cFF1EFF00Complete|r",
                ["no"] = "|cFFDC143CIncomplete|r"
            }
        }
 
        local locale = GetLocale()
        local locStrings = localization[locale] or localization["enUS"]
 
        local questStatus = locStrings["quest70893"] .. " "
        if completedQuests[70893] then
            questStatus = questStatus .. locStrings["yes"]
        else
            questStatus = questStatus .. locStrings["no"]
        end
 
        questStatus = questStatus .. "\n" .. locStrings["quest71995"] .. " "
        if completedQuests[71995] then
            questStatus = questStatus .. locStrings["yes"]
        else
            questStatus = questStatus .. locStrings["no"]
        end
 
        text:SetText(questStatus)
    elseif event == "QUEST_TURNED_IN" then
        -- Triggers when pressing Complete Button
        QuestTurnedIn(...)
    elseif event == "QUEST_ACCEPTED" then
        -- Triggers before Pressing Accept Button
        QuestAccepted(...)
    end
end)
 
frame:RegisterEvent("PLAYER_LOGIN")
frame:RegisterEvent("QUEST_TURNED_IN")
frame:RegisterEvent("QUEST_ACCEPTED")

Xrystal · 04-08-24, 05:12 AM

What does it do ?
What did you expect it to do ?

It doesn't work doesn't explain what is happening in your case.

Looking at your code you are still only setting the information on PLAYER_LOGIN. This means it will only show the status ( outside of the printed statements from my code portions) when you first login or reload the UI.

Your updating of the display code needs to be updated on completion too.

Give this code a whirl. It's not perfect but hopefully it will work closer to what you wanted it to do.

Lua Code:

local addonName, addon = ...
 
-- Create Frame
local frame = CreateFrame("Frame", "QuestCompletionFrame", UIParent)
frame:SetSize(100, 100)
frame:SetPoint("CENTER")
frame:EnableMouse(true)
frame:SetMovable(true)
frame:RegisterForDrag("LeftButton")
frame:SetScript("OnDragStart", frame.StartMoving)
frame:SetScript("OnDragStop", frame.StopMovingOrSizing)
 
local text = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
text:SetPoint("CENTER")
 
-- Initialise Data used in addon
local completedQuests = {}
local questInfo = {}
local questIDs = {70893, 71995}
 
-- Setup Localization
local localization = {
    ["enUS"] = {
        ["quest70893"] = "|cFFDEB887Community Feast:|r",
        ["quest71995"] = "|cFFDEB887Trial of the Elements:|r",
        ["yes"] = "|cFF1EFF00Complete|r",
        ["no"] = "|cFFDC143CIncomplete|r"
    }
}
local locale = GetLocale()
local locStrings = localization[locale] or localization["enUS"]
 
local function UpdateDisplay(questID, questStatus)
 
    -- Append newline if questStatus contains information
    if questStatus != "" then
        questStatus .. "\n"
    end
    
    -- Convert questID to a string and create a localization key for it
    questStatus = locStrings["quest" .. tostring(questID)] .. " "
    
    -- Add whether it is completed or not
    if completedQuests[questID] then
        questStatus = questStatus .. locStrings["yes"]
    else
        questStatus = questStatus .. locStrings["no"]
    end
 
    -- Update Text Box
    text:SetText(questStatus)
 
    -- Return the current questStatus contents
    return questStatus
 
end
 
-- Handle what to do when you first log in
local function PlayerLogin(...)
    for _, questID in ipairs(questIDs) do
        local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)
        completedQuests[questID] = isCompleted
    end
    
    -- Statu with an empty questStatus and update it
    local questStatus = ""
    questStatus = UpdateDisplay(70893, questStatus)
    questStatus = UpdateDisplay(71995, questStatus)
 
end
 
 
-- Handle what to do when you turn in a quest
local function QuestTurnedIn(...)
    local questID, xpReward, moneyReward = ...
    
    -- Don't bother continuing if we are not watching this quest
    if questID != 70893 then return end
    if questID != 71995 then return end
    
    local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)   -- Returns true
    completedQuests[questID] = isCompleted
    
    -- Debug Text
    print("Quest: ", questID,"XP: ", xpReward,"Money: ", moneyReward,"Completed: ",isCompleted)
    
    -- Get Current Text Display and Update it
    local questStatus = text:GetText()
    questStatus = UpdateDisplay(questID, questStatus)
 
end
 
-- Handle what to do when you accept a quest
local function QuestAccepted(...)
    local questID = ...
    local questLogIndex = C_QuestLog.GetLogIndexForQuestID(questID)
    local info = { C_QuestLog.GetInfo(questLogIndex) }
    
    -- Add Quest Info to table 
    questInfo[questID] = info
    
    -- Debug Text
    print("Accepted Quest: ", questID, info["title"])
end
 
-- Handle events being listened to 
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        PlayerLogin(...)
    elseif event == "QUEST_TURNED_IN" then
        -- Triggers when pressing Complete Button
        QuestTurnedIn(...)
    elseif event == "QUEST_ACCEPTED" then
        -- Triggers before Pressing Accept Button
        QuestAccepted(...)
    end
end)
 
frame:RegisterEvent("PLAYER_LOGIN")
frame:RegisterEvent("QUEST_TURNED_IN")
frame:RegisterEvent("QUEST_ACCEPTED")

Hubb777 · 04-08-24, 06:53 AM

Many thanks for the help. I still managed to do it using your code again + OnUpdate

Lua Code:

local addonName, addon = ...
local frame = CreateFrame("Frame", "QuestCompletionFrame", UIParent)
frame:SetSize(100, 100)
frame:SetPoint("CENTER")
frame:EnableMouse(true)
frame:SetMovable(true)
frame:RegisterForDrag("LeftButton")
frame:SetScript("OnDragStart", frame.StartMoving)
frame:SetScript("OnDragStop", frame.StopMovingOrSizing)
 
local text = frame:CreateFontString(nil, "OVERLAY", "GameFontNormal")
text:SetPoint("CENTER")
 
local Quests_Completed = Quests_Completed or {}
 
local function QuestTurnedIn(...)
    local questID, xpReward, moneyReward = ...
    local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)   -- Returns true
    print("Quest: ", questID,"XP: ", xpReward,"Money: ", moneyReward,"Completed: ",isCompleted)
    Quests_Completed[questID].Completed = isCompleted
end
 
local function QuestAccepted(...)
    local questID = ...
    local questLogIndex = C_QuestLog.GetLogIndexForQuestID(questID)
    local info = { C_QuestLog.GetInfo(questLogIndex) }
    print("Accepted Quest: ", questID, info["title"])
    Quests_Completed[questID] = info
end
 
frame:SetScript("OnEvent", function(self, event, ...)
    if event == "PLAYER_LOGIN" then
        self.elapsed = 0 -- Initialize elapsed time
        self:RegisterEvent("QUEST_TURNED_IN")
        self:RegisterEvent("QUEST_ACCEPTED")
    end
end)
 
frame:SetScript("OnUpdate", function(self, elapsed)
    self.elapsed = self.elapsed + elapsed
    if self.elapsed >= 1 then -- Check every 1 second
        local completedQuests = {}
        local questIDs = {70893, 71995}
 
        for _, questID in ipairs(questIDs) do
            local isCompleted = C_QuestLog.IsQuestFlaggedCompleted(questID)
            completedQuests[questID] = isCompleted
        end
 
        local localization = {
            ["enUS"] = {
                ["quest70893"] = "|cFFDEB887Community Feast:|r",
                ["quest71995"] = "|cFFDEB887Trial of the Elements:|r",
                ["yes"] = "|cFF1EFF00Complete|r",
                ["no"] = "|cFFDC143CIncomplete|r"
            }
        }
 
        local locale = GetLocale()
        local locStrings = localization[locale] or localization["enUS"]
 
        local questStatus = locStrings["quest70893"] .. " "
        if completedQuests[70893] then
            questStatus = questStatus .. locStrings["yes"]
        else
            questStatus = questStatus .. locStrings["no"]
        end
 
        questStatus = questStatus .. "\n" .. locStrings["quest71995"] .. " "
        if completedQuests[71995] then
            questStatus = questStatus .. locStrings["yes"]
        else
            questStatus = questStatus .. locStrings["no"]
        end
 
        text:SetText(questStatus)
        
        self.elapsed = 0 -- Reset elapsed time
    end
end)
 
frame:RegisterEvent("PLAYER_LOGIN")