Get spellid of a macro

itrulia · 03-26-13, 06:23 AM

Hi people,

I'm working on an addOn that highlights paladin abilities if you have 3 holy power. My problem is I do not know how to get the spellid of a macro.

What do I have:

if unit == "player" and UnitClass(unit) == "Paladin" then
for _, btn in pairs({"ActionButton", "MultiBarLeftButton", "MultiBarRightButton", "MultiBarBottomLeftButton", "MultiBarBottomRightButton"}) do
for i = 1, 12 do
local button = _G[btn..i];

local actionType, id, subType = GetActionInfo(button.action);

for _, spellId in pairs(spells["holyPower"]) do
if actionType == "spell" then
local spellId2 = id;

if (spellId == spellId2) and UnitPower(unit , SPELL_POWER_HOLY_POWER) >= 3 then
ActionButton_ShowOverlayGlow(button)
else
ActionButton_HideOverlayGlow(button)
end
elseif actionType == "macro" then
-- print(id);
end;
end;
end
end
end;

works with spells as intended but not with macros

Xrystal · 03-26-13, 07:27 AM

nUI uses the function ActionButton_CalculateAction(button) to return the actionID which is then used in the GetSpellInfo function. You might want to see if that helps you. It allows us to see cooldowns and timers on the spells the macros use that way.

ravagernl · 03-26-13, 01:23 PM

You can use GetMacroSpell and a lookup table. GetMacroSpell will give you the localized name but you can use a lookup table to find the spell id:

lua Code:

local gsi = GetSpellInfo
local spell2id = {}
spell2id[gsi(85256)] = 85256 -- TV
spell2id[gsi(53385)] = 53385 -- DS
spell2id[gsi(84963)] = 84963 -- Inq
spell2id[gsi(85222)] = 85222 -- LoD
spell2id[gsi(85673)] = 85673 -- WoG
-- did I list them all?
 
-- a reverse table.
local id2spell = {}
for name, id in next, spell2id do
    id2spell[id] = name
end
 
local function isHolyPowerAction(actionId)
    local actionType, id = GetActionInfo(actionId)
    if actionType == 'spell' then
        return id
    elseif actionType == 'macro' then
        local name = GetMacroSpell(id)
        return name and spell2id[name], name
    end
end
 
-- assuming action 1 has a macro with a spell.
local id, name = action2spell(1)

Note: may come with syntax errors because I am tired of work and I cba to check ingame

Put the lookup tables outside of your event code and just use isHolyPowerAction instead of looping through a table.

semlar · 03-26-13, 01:26 PM

This is basically how I do it in my Crack Cooldown addon.

Lua Code:

if unit == "player" and UnitClass(unit) == "Paladin" then
 local hasPower = UnitPower(unit , SPELL_POWER_HOLY_POWER) >= 3
 for _, btn in pairs({"ActionButton", "MultiBarLeftButton", "MultiBarRightButton", "MultiBarBottomLeftButton", "MultiBarBottomRightButton"}) do
  for i = 1, 12 do
   local button = _G[btn..i]
   local actionType, id, subType, _ = GetActionInfo(button.action)
   if actionType == 'macro' then
    _, _, id = GetMacroSpell(id)
   elseif actionType == "spell" or (actionType == 'macro' and id) then
    for _, spellId in pairs(spells["holyPower"]) do
     --local spellId2 = id
     if spellId == id and hasPower then
      ActionButton_ShowOverlayGlow(button)
     else
      ActionButton_HideOverlayGlow(button)
     end
    end
   end
  end
 end
end

I moved your for loop around so you wouldn't have to keep looking up the spell id for the button for every spell in your list.

However, calling ActionButton_HideOverlayGlow on every button that doesn't match your criteria is going to wipe out every other overlay glow, so you might want to keep track of which ones you set in a table or something.

Unless you're only calling it on buttons that won't have glows apart from yours, in which case it doesn't really matter.

ravagernl · 03-26-13, 01:39 PM

Originally Posted by semlar

This is what I use in my Crack Cooldown addon.

Lua Code:

elseif actionType == "macro" then
  local _, _, spellId2 = GetMacroSpell(id)
end

Awesome, wowprogramming/wowpedia/wowwiki all listed two arguments, seems the spell id was added recently then?

semlar · 03-26-13, 01:51 PM

It's not recent, I have no idea how long it's returned the spell ID but I started writing that addon probably more than 2 years ago.

It's here on curse if you want to see it, although the code is not great it does what it's supposed to. Mostly.

Xrystal · 03-26-13, 04:11 PM

Ah yeah, looks like the 3rd return value came into play around Wow 4.3 . Totally forgot about GetMacroSpell function.

Phanx · 03-26-13, 10:01 PM

I updated the GetMacroSpell API page on Wowpedia.

itrulia · 04-02-13, 01:06 AM

Originally Posted by Phanx

I updated the GetMacroSpell API page on Wowpedia.

Ty, I figured it out 10 min after I wrote that post (found the function on warcraftprogramming, wowpedia is my first source --> is not listen in the wowapi)