Need help testing FreeShout.

[Haleth]

http://www.wowinterface.com/download...FreeShout.html

I released this earlier today and it works perfectly for me, but for one of my friends, the reminder won't go away in combat even when he has the shout buffed. Our talents and all are the same and I'm utterly clueless as to what could be causing this.

I'd appreciate some testers to see if it works properly, and if not, perhaps help me debug it.

[Nobgul]

Seems to be working fine for me. Only tried it on the low lvl mobs outside of org. But that should not matter. As for your friend, have him disable all his addons except this one and see what happens.

[ravagernl]

Are you sure it is not working or is it just greater blessing of might(the improved one overwrites battle shout, iirc)?

By the way, your OnEvent is slightly inefficient in that it also triggers updates for every unit in your raid, and targets etc when their aura's change.

if event == "UNIT_AURA" and ... ~= "player" then return end

[Haleth]

Thanks for the replies. I did ask him to disable all other addons, but it changed nothing.

mrruben5, if the battle shout mode is on the addon also checks for (greater) blessing of might, so it can't be that - he didn't have that buff on him, either.

Thank you for the efficiency remark. I've added UNIT_ENTERING_VEHICLE and UNIT_EXITING_VEHICLE too, because otherwise they'll also fire for other raid units.

if (event == "UNIT_AURA" or event == "UNIT_ENTERING_VEHICLE" or event == "UNIT_EXITED_VEHICLE") and ... ~= "player" then return end

[Sideshow]

you are using spell id's - it could be another id

it is of course the most elegant way, but checking simply on buff names instead, will never ever be wrong... string "Battle Shout" is always the same, no matter what level, rank or talents ...

[yj589794]

Originally Posted by Sideshow you are using spell id's - it could be another id it is of course the most elegant way, but checking simply on buff names instead, will never ever be wrong... string "Battle Shout" is always the same, no matter what level, rank or talents ...

Even on non-English game clients? I'd be surprised if the strings were not localised.

[yj589794]

Originally Posted by Haleth http://www.wowinterface.com/download...FreeShout.html I released this earlier today and it works perfectly for me, but for one of my friends, the reminder won't go away in combat even when he has the shout buffed. Our talents and all are the same and I'm utterly clueless as to what could be causing this. I'd appreciate some testers to see if it works properly, and if not, perhaps help me debug it.

You are only checking for the highest rank of the aura. Might be worth checking the lower ranks and giving a warning that a higher rank is available.

Also, get your friend to check the rank of shout they are using. (learning a new spell rank in dual-spec is known to cause spell rank issues when switching to the other spec)


-------

Your commanding shout check is searching for the lowest rank of the aura, I suspect you meant to check for the highest rank

[Ailae]

It's using the localized name for each buff. GetSpellInfo(id) returns the localized name as its first return.

[Haleth]

As far as I know GetSpellInfo will work on any rank and shouldn't affect the functionality, right? I've tried it on both a level 80 and a level 2 warrior, it doesn't make a difference.

I checked with my friend and his spell ranks are the same, so I really don't know what can be causing this.