Hide consolidated buffs.

Haleth · 07-12-10, 04:01 AM

Hello.

I'm trying to hide the player's buffs (I use oUF player buffs) if they are consolidated by the game. I use a custom script for the consolidate buffs, but currently it doesn't affect oUF's buffs so it's pretty useless right now.

This is my PostUpdateIcon:

Code:

	PostUpdateIcon = function(icons, unit, icon, index, offset, filter, isDebuff)
		local texture = icon.icon
		local name, _, _, _, dtype, duration, expirationTime, unitCaster, shouldConsolidate = UnitAura(unit, index, icon.filter)
		if(unit~="target") then icon:Show() end
		if(UnitIsFriend("player", unit) or playerUnits[icon.owner] or debuffFilter[name] or not icon.debuff or UnitIsPlayer(unit)) then
			icon:Show()
		else
			icon:Hide()
		end
	end

Don't mind the unused stuff in there. I've been trying to add shouldConsolidate in a lot of different ways, but it just doesn't seem to work. Can anyone help me out here? Thanks.

P.S. Sorry for the many topics. I'm learning.

Rostok · 07-12-10, 05:53 AM

shouldConsolidate is 1 or nil so a check if shouldConsolidate exist should do the trick.

if shouldConsolidate then
blabla
else
blabla
end.

Haleth · 07-12-10, 05:56 AM

Well I tried that, it didn't work.

Haleth · 07-13-10, 06:22 AM

Anyone have an idea? This can't be that hard.

Waverian · 07-13-10, 07:10 AM

You should likely be using a CustomFilter rather than PostUpdateIcon. Check oUF\elements\auras for the arguments.

Dawn · 07-13-10, 07:57 AM

I would try use a custom filter, too. However, chances are that this is not going to work, atm. Due to some little issues with oUF's filter code.

Haleth · 07-13-10, 08:46 AM

Well, that's not working me. Thanks for the suggestions, but I think I better wait till those issues are fixed.

Saiket · 07-13-10, 07:20 PM

Here's a visual diff of my changes to the aura element. It seems to work with my layout's aura filter, and fixes the bug where all auras after the first hidden one get hidden as well.

http://wowi.pastey.net/138563-aay9:138562-40p2

I haven't exactly thoroughly tested this, but it seems fine after half a night of raiding. Should hold us over until Haste gets back to update oUF.

haste · 07-15-10, 05:46 AM

Originally Posted by Saiket

Here's a visual diff of my changes to the aura element. It seems to work with my layout's aura filter, and fixes the bug where all auras after the first hidden one get hidden as well.

http://wowi.pastey.net/138563-aay9:138562-40p2

I haven't exactly thoroughly tested this, but it seems fine after half a night of raiding. Should hold us over until Haste gets back to update oUF.

You can fork oUF over at github and push patches. I can actually merge them from my phone.

Saiket · 07-15-10, 05:26 PM

Originally Posted by haste

You can fork oUF over at github and push patches. I can actually merge them from my phone.

Done. Hopefully it all worked; that's My First Fork™.