spellId, COMBAT_LOG_EVENT_UNFILTERED

[Xiaowei]

My add-on enlightens the user when certain events occur. It has difficulties matching the spellId for -- Immune as it triggers even when spellId is one of the three excluded.

There is no doubt if spellId indeed returns an ID, since UIErrorsFrame:AddMessage has no difficulties returning the spell name through GetSpellInfo.

What have I done wrong here? I am lost completely.

On a completely unrelated note, I would also like to implement some sort of safety limit that will ensure that events cannot trigger many times at the same time as this could occur in rare circumstances. Any tips on how to achieve this?

local Enlightener = CreateFrame('FRAME')
Enlightener:RegisterEvent('COMBAT_LOG_EVENT_UNFILTERED')
Enlightener:SetScript('OnEvent', function(self, event, ...)
 
  local event = select(2, ...)
  local sourceGUID = select(4, ...)
  local destGUID = select(8, ...)
  local spellId = select(12, ...)
  local extraSpellId = select(15, ...) -- 'missType' for '_MISSED'
 
  if sourceGUID == UnitGUID('player') or sourceGUID == UnitGUID('pet') then
    -- Interrupted
    if event == 'SPELL_INTERRUPT' then
      UIErrorsFrame:AddMessage('Interrupted: '..GetSpellInfo(extraSpellId), 1, 1, 0)
 
    -- Dispelled
    elseif event == 'SPELL_DISPEL' then
      UIErrorsFrame:AddMessage('Dispelled: '..GetSpellInfo(extraSpellId), 1, 1, 0)
 
    -- Stolen
    elseif event == 'SPELL_STOLEN' then
      UIErrorsFrame:AddMessage('Stolen: '..GetSpellInfo(extraSpellId), 1, 1, 0)
 
    -- Experimental: Grounded
    elseif event == 'SPELL_DAMAGE'
    and spellId == 204336 then -- Shaman: Grounding Totem
      UIErrorsFrame:AddMessage('Grounded: '..GetSpellInfo(spellId), 1, 1, 0)
      PlaySoundFile('Interface\\AddOns\\Enlightener\\Alert.ogg', 'Master')
 
    -- Evaded
    elseif event == 'SPELL_MISSED' and extraSpellId == 'EVADE' then
      UIErrorsFrame:AddMessage('Evaded: '..GetSpellInfo(spellId), 1, 1, 0)
      PlaySoundFile('Interface\\AddOns\\Enlightener\\Alert.ogg', 'Master')
 
    -- Immune
    elseif event == 'SPELL_MISSED' and extraSpellId == 'IMMUNE'
    and spellId ~= 43265 -- Death Knight: Death and Decay
    and spellId ~= 26573 -- Paladin: Consecration
    and spellId ~= 6343 then -- Warrior: Thunder Clap
      UIErrorsFrame:AddMessage('Immune: '..GetSpellInfo(spellId), 1, 1, 0)
      PlaySoundFile('Interface\\AddOns\\Enlightener\\Alert.ogg', 'Master')
 
    -- Experimental: Shattered
    elseif event == 'SPELL_MISSED' and extraSpellId == 'IMMUNE'
    and spellId == 65941 then -- Warrior: Shattering Throw
      UIErrorsFrame:AddMessage('Shattered', 1, 1, 0)
 
    -- Experimental: Reflected
    elseif event == 'SPELL_MISSED' and extraSpellId == 'REFLECT' and destGUID == UnitGUID('player') then
      UIErrorsFrame:AddMessage('Reflected: '..GetSpellInfo(spellId), 1, 1, 0)
    end
  end
end)

[SDPhantom]

There can be many versions of the same spell in the game database. You need to insert some debug code printing out what SpellIDs are getting past your checks. Once you find the IDs getting through and block them, you can remove the debug code.

[Xiaowei]

Thanks for your input. I did not know about that. I have added some code to test and verify.

Do you have any tips in terms of limiting the amount of events that can occur at once?

[myrroddin]

Originally Posted by Xiaowei Do you have any tips in terms of limiting the amount of events that can occur at once?

You can use AceBucket-3.0 https://www.wowace.com/projects/ace3...ace-bucket-3-0

[Eternal_Lynx]

For throttling, there's a lib-free approach: store that timestamp (eg. GetTime()) whenever a message is sent/sound effect is played, then calculate elapsed time from last recorded timestamp, if it's shorter than your desired interval, return.

[SDPhantom]

An addon like this isn't really suited for caching events for later processing. As the alerts only trigger from the player doing stuff, the amount of actual actions it takes versus the event firing is slim. As an alert addon, you need your info immediately, not seconds later. Your code is far from optimized, but it a decent start for what needs done.

One thing I would do is implement an internal message cooldown so it doesn't spam the user when using an AoE that misses, evades, etc. There are a lot of these and the list is changing all the time. The optimizations I would do first is cache the player and pet GUIDs so you're not calling UnitEvent() constantly. Combine the local assignment and move away from using select(). Look into nesting similar conditions together in your if blocks so the CPU isn't stuck comparing stuff you already checked over and over previously. Get rid of GetSpellInfo(), the spell name in either use is provided in the args, use them instead.