Trying to skin Blizzard default buff/debuff frames

[Layback_]

Hi all,

I am currently trying to re-skin Blizzard default buff/debuff frames, but it shows kind of weird result.

Sometimes the newly created (template) frame covers the buff/debuff icons while sometimes it doesn't.

I'm guessing that it's happening because of my :SetTemplate function, but ain't sure where the actual problems are occurring since it happens so randomly

Here I have attached .zip file, so you can have a look.

Thank you!

EDIT: temporarily fixed it by setting icon's draw layer to "OVERLAY".

[kurapica.igas]

It's better to use hooksecurefunc, there are two parts :

Hook the BuffButton_OnLoad, so you'll apply your skin to every aura button, you also need to hook each button's SetTexture method, so when blz set texture to those buttons, you can do the cut job :

hooksecurefunc("BuffButton_OnLoad", function(self)
    -- the self is aura button
    hooksecurefunc(self, "SetTexture", function(self, path)
	if path then
                -- Cut the icon
		self:SetTexCoord(0.06, 0.94, 0.06, 0.94)
	end
    end)

    -- do other skin job
end)

[Layback_]

Hi kurapica.iga,

Thank you for your advice

What about the borders for debuffs?

As you know some debuffs have a different border colors based on their types (like red or blue).

Would this be considered on BuffButton_OnLoad or SetTexture functions?

[Aftermathhqt]

Originally Posted by Layback_ Hi kurapica.iga, Thank you for your advice What about the borders for debuffs? As you know some debuffs have a different border colors based on their types (like red or blue). Would this be considered on BuffButton_OnLoad or SetTexture functions?

I would do this

function SkinDebuff()
    local button, icon;
    for i = LayAura.debuffs + 1, DEBUFF_ACTUAL_DISPLAY do
        button = _G["DebuffButton" .. i];
        icon = _G["DebuffButton" .. i .. "Icon"];
        
        local Border = _G[button .. "Border"]
        if (Border) then
            Border:SetTexture(nil)
            Border:Hide()
        
            local R, G, B = Border:GetVertexColor()
            button:SetColorHere
        end
 
        CutOffEdges(icon);
        SetTemplate(button);
    end
 
    LayAura.debuffs = DEBUFF_ACTUAL_DISPLAY;
end

[Layback_]

Originally Posted by Game92 I would do this function SkinDebuff()     local button, icon;     for i = LayAura.debuffs + 1, DEBUFF_ACTUAL_DISPLAY do         button = _G["DebuffButton" .. i];         icon = _G["DebuffButton" .. i .. "Icon"];                 local Border = _G[button .. "Border"]         if (Border) then             Border:SetTexture(nil)             Border:Hide()                     local R, G, B = Border:GetVertexColor()             button:SetColorHere         end           CutOffEdges(icon);         SetTemplate(button);     end       LayAura.debuffs = DEBUFF_ACTUAL_DISPLAY; end

Yeap, that's how I've done it at the moment, but was not added into attachment

[kurapica.igas]

Originally Posted by Layback_ Hi kurapica.iga, Thank you for your advice What about the borders for debuffs? As you know some debuffs have a different border colors based on their types (like red or blue). Would this be considered on BuffButton_OnLoad or SetTexture functions?

Well, I make some problem, write it again :

local original_SetVertexColor   -- Keep a copy so it won't trigger the hook again
 
hooksecurefunc("BuffButton_OnLoad", function(self)
    -- the self is aura button
 
    -- For cut icon
    local icon = _G[self:GetName() .. "Icon"]  -- miss this
    hooksecurefunc(icon, "SetTexture", function(self, path)
        if path then
            -- Cut the icon
            self:SetTexCoord(0.06, 0.94, 0.06, 0.94)
        end
    end)
 
    -- For the debuff border color
    local debuffSlot = _G[self:GetName().."Border"]
    if not original_SetVertexColor then original_SetVertexColor = debuffSlot.SetVertexColor end
 
    hooksecurefunc(debuffSlot, "SetVertexColor", function(self, r, g, b)
        -- You can only use original_SetVertexColor  to change border color
        -- debuffSlot:SetVertexColor(1, 0, 0)  wrong, it'll cause Infinite loop
        original_SetVertexColor(debuffSlot, 1, 0, 0)   -- that's okay
    end)
 
    -- do other skin job
end)

Don't try to replace the methods directly, it'll cause taint error.

[Layback_]

Originally Posted by kurapica.igas Well, I make some problem, write it again : ... Don't try to replace the methods directly, it'll cause taint error.

Sweet!

Thanks for the workaround