Help with non working unit check

[Sauerkraut]

I don't really know how to explain this, but I am trying to fix an addon that allows either all units or a specified list of units. The all units part is working fine however when specific units are selected nothing is output to the game. There is no error it just does nothing.

From the addon

local function UnitisAllowed(unit)
	for key, val in pairs(addon.CONFIG.units) do
		if UnitIsUnit(unit, val) then return true end
	end
	return false
end

if eventType == "SPELL_AURA_APPLIED" and addon.BUFF_SPELLS[spellname] and isEnemy(destFlags) and (addon.CONFIG.allunits or UnitisAllowed(destName)) then

from the config

addon.CONFIG = {
	allunits = false, 
	units = {
		"target",
		"focus",
	},
}

Am I using the correct syntax for the check? I'm just not sure why it is failing.

[Lombra]

What immediately strikes me is that you're using destName in the UnitIsUnit check. I don't think that'll work unless dest is a group member.

You could try doing UnitisAllowed(destGUID)) instead, and then doing something like this instead:

local function UnitisAllowed(guid)
	for key, val in pairs(addon.CONFIG.units) do
		if UnitGUID(val) == guid then return true end
	end
	return false
end

[Sauerkraut]

Thanks, I had actually already changed UnitisAllowed(destGUID) after reading through some of the wowprogramming.com documents. I'll try it out and see if it works. Thank you again.

[Sauerkraut]

Sadly I still haven't been able to get this working. If anyone has any ideas they would be greatly appreciated.

[Xinhuan]

UnitIsUnit only works on UnitIDs. Like UnitIsUnit("target", "focustarget"). Using guids will not work and using player names will only work if they are in your party or raid.

You should just compare their GUIDs directly instead (string compare).

[Sauerkraut]

I'm sorry if these are dumb questions, I'm really trying. I'm not overly familiar with lua or any other programming language for that matter and I think I may be in over my head here.

Following (I hope) your advise I've gone to

local function UnitisAllowed(unit)
	if not addon.CONFIG.allunits then
		if UnitID == "target" or UnitID == "focus" or UnitID == "mouseover" then return true end
	end
	else
	return false
end

if eventType == "SPELL_AURA_APPLIED" and addon.BUFF_SPELLS[spellname] and isEnemy(destFlags) and (addon.CONFIG.allunits or UnitisAllowed(destID)) then

???