FontString for value and percent?

[10leej]

How would I go about this? Never dealt with FontStrings before (my UI uses whoa unitframes, which I have no idea as to what I'm looking at when i look there)

I know a basic fontsring can be done doing this

frame = f:CreateFontString(nil,"ARTWORK","GameFontHighlight")
frame:SetPoint("BOTTOM",frame,0,0)
frame:SetText("health text")

wouldn't mind having something like this, course that example is using the script I have above

[Phanx]

I'm not really sure what you're looking for. The code you posted should work, though you probably want to give it a more useful name so you can access it later:

f.HealthText = f:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
f.HealthText:SetPoint("BOTTOM")

Then whenever you want to make it show some other text, just set its text:

f.HealthText:SetText("15%")

If your text involves any string.format or concatenation, use :SetFormattedText instead of :SetText to move the formatting C-side:

local currentHealth, maxHealth = UnitHealth("player"), UnitHealthMax("player")
f.HealthText:SetFormattedText("%d/%d", currentHealth, maxHealth)

[10leej]

I'm making health text for a HUD addon I'm working on I got the bars updating I just gotta work on the text that I've honestly never dealth with before.

Then if I want the numbers to run and update with health changes I can just do this?

f.HealthText = f:CreateFontString(nil, "ARTWORK", "GameFontHighlight")
f.HealthText:SetPoint("BOTTOM",f.hp,0,0)
local currentHealth, maxHealth = UnitHealth("player"), UnitHealthMax("player")
local function update(self)
  local unit = self.unit
  f.PowerText:SetFormattedText("%d/%d", currentPower, maxPower)
f:SetScript("OnEvent",update)
f:RegisterUnitEvent("UNIT_HEALTH",f.unit)
 
update(f) --initial update

[myrroddin]

Are you assigning currentHealth/maxHealth or currentPower/maxPower? Your code retrieves the former and (fails to display) the latter.

Also, whether you use "frame" or "f" please, for the love of the Light, make that a local variable.

[semlar]

Also UnitHealth and UnitHealthMax need to be inside of the update function or their values will never change.

[Resike]

Originally Posted by myrroddin Are you assigning currentHealth/maxHealth or currentPower/maxPower? Your code retrieves the former and (fails to display) the latter. Also, whether you use "frame" or "f" please, for the love of the Light, make that a local variable.

Some men, just want to watch the taints burn.

[10leej]

Originally Posted by Resike Some men, just want to watch the taints burn.

But, I like tainting everything !

MWAHAHAHAHAHAHAHAHAHAHHAHAHAHA

[Fizzlemizz]

If i-taint worth tainting i-taint worth doing

[10leej]

Anyways I got it working now for the value text, how do I get it to show percentage as well? (I honestly can't find information on it so I'm sorry to bother you guys)

I imagine it's simply just make another frame for the text but rather than using "%d/%d" just use something else (not sure what though)

local currentHealthPercent, maxHealthPercent = UnitHealth("player"), UnitHealthMax("player")
f.HealthPercentText:SetFormattedText("%d/%d", currentHealthPercent, maxHealthPercent)
--Updates the status bar to new health
local function update(self)
  local unit = self.unit
  --update health percentage text
  local currentHealthPercent, maxHealthPercent = UnitHealth("player"), UnitHealthMax("player")
  f.HealthPercentText:SetFormattedText("%d/%d", currentHealthPercent, maxHealthPercent) 
  --update health value text
  local currentHealth, maxHealth = UnitHealth("player"), UnitHealthMax("player")
  f.HealthText:SetFormattedText("%d/%d", currentHealth, maxHealth) 
end
f:SetScript("OnEvent",update)
f:RegisterUnitEvent("UNIT_HEALTH",f.unit)
f:RegisterUnitEvent("UNIT_POWER",f.unit)

[Seerah]

Why are your variables named currentHealthPercent and maxHealthPercent. They're just your current and max health. Don't create misleading variable names.

To do the percent, you just calculate it. (ie, divide and x100)

[10leej]

Originally Posted by Seerah Why are your variables named currentHealthPercent and maxHealthPercent. They're just your current and max health. Don't create misleading variable names. To do the percent, you just calculate it. (ie, divide and x100)

I guessed on it, but if I didn;t have to rename them for the second fontstring then i didn't

But, I did finally get the text working, thanks for the help everyone!

[Phanx]

f:SetScript("OnEvent", function(self, event, unit)
	if event == "UNIT_HEALTH" then
		local currentHealth, maxHealth = UnitHealth(unit), UnitHealthMax(unit)
		local percentHealth = currentHealth / maxHealth * 100
		self.HealthText:SetFormattedText("%d/%d (%d%%)", currentHealth, maxHealth, percentHealth)
	elseif event == "UNIT_POWER" then
		local currentPower, maxPower = UnitPower(unit), UnitPowerMax(unit)
		local percentPower = currentPower / maxPower * 100
		self.PowerText:SetFormattedText("%d/%d (%d%%)", currentPower, maxPower, percentPower)
	end
end)
f:RegisterUnitEvent("UNIT_HEALTH", f.unit)
f:RegisterUnitEvent("UNIT_POWER", f.unit)

You should only update the portions relevant to the event that fired, and you shouldn't need to manually update on load unless your code is loading very late. If you notice wrong values on login, just add this at the end:

f:GetScript("OnEvent")(f, "UNIT_HEALTH", f.unit)
f:GetScript("OnEvent")(f, "UNIT_POWER", f.unit)

[10leej]

Seems you code doesn't update the statusbars for 5.3 but the fontstrings do. Not sure why yet as I'm not getting any errors need to do some more testing with it

[Phanx]

Well, there is nothing in that code that does anything to any statusbar, so that seems correct.

[10leej]

Originally Posted by Phanx Well, there is nothing in that code that does anything to any statusbar, so that seems correct.

Well it's monday I'm drunk so guess i missed that part....

[Aanson]

I don't know what others would think about this, but if I was setting up a HUD, I would personally do:

1. Only the health bar and power/mana bar get their values from the UnitHealth("player"), UnitHealthMax("player"), and the power/mana equivalent funcs.

2. I would then hook everything else, including text to the OnValueChanged() handler of the bars.

That way, only 1 object is calling the health funcs and the same on the power/mana side.

I say this because you said you have the bars set up already, so presumably you're addOn is already being fed all the information that it needs.

Hope that makes sense.

[Seerah]

Why hook your own code when you can just save the value to a variable?

[Aanson]

Originally Posted by Seerah Why hook your own code when you can just save the value to a variable?

Yeah true, you could always contain the data in local UpValues.

It makes little difference though because you'd still need to be constantly updating the value of your UpValues anyway.

Hooking to OnValueChanged just seems like the cleanest way to me. ie.

myHealthBar:SetScript("OnValueChanged", function(self, health)
    local _, maxHealth = self:GetMinMaxValues();
    healthText:SetFormattedText("%d/%d", health, maxHealth);
    -- update other things here too
end);

[10leej]

NO DON'T DO THIS TO ME I already got the fontstrings working as they are, not gonna fix it if they ain't broke, lmao

[Aanson]

Haha!! I'm sure it's 6 and half a dozen